1. 21 Aug, 2020 1 commit
    • Andronik Ordian's avatar
      utils: handle race condition gracefully (#1583) · 8e4e79f5
      Andronik Ordian authored
      * utils: handle race condition gracefully
      
      * utils: add a test
      
      * update Cargo.lock
      
      * utils: remove a warning
      
      * utils: init logger in tests
      
      * utils: update the outdated comment
      
      * util: wait for both subsystem and test_future to finish
      
      * Revert "util: wait for both subsystem and test_future to finish"
      
      This reverts commit 075b3924.
      8e4e79f5
  2. 20 Aug, 2020 1 commit
  3. 19 Aug, 2020 1 commit
  4. 18 Aug, 2020 3 commits
    • asynchronous rob's avatar
      Implement validation data refactor (#1585) · 8c881e45
      asynchronous rob authored
      
      
      * update primitives
      
      * correct parent_head field
      
      * make hrmp field pub
      
      * refactor validation data: runtime
      
      * refactor validation data: messages
      
      * add arguments to full_validation_data runtime API
      
      * port runtime API
      
      * mostly port over candidate validation
      
      * remove some parameters from ValidationParams
      
      * guide: update candidate validation
      
      * update candidate outputs
      
      * update ValidationOutputs in primitives
      
      * port over candidate validation
      
      * add a new test for no-transient behavior
      
      * update util runtime API wrappers
      
      * candidate backing
      
      * fix missing imports
      
      * change some fields of validation data around
      
      * runtime API impl
      
      * update candidate validation
      
      * fix backing tests
      
      * grumbles from review
      
      * fix av-store tests
      
      * fix some more crates
      
      * fix provisioner tests
      
      * fix availability distribution tests
      
      * port collation-generation to new validation data
      
      * fix overseer tests
      
      * Update roadmap/implementers-guide/src/node/utility/candidate-validation.md
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
      8c881e45
    • Andronik Ordian's avatar
      initial prometheus metrics (#1536) · 804958ab
      Andronik Ordian authored
      * service-new: cosmetic changes
      
      * overseer: draft of prometheus metrics
      
      * metrics: update active_leaves metrics
      
      * metrics: extract into functions
      
      * metrics: resolve XXX
      
      * metrics: it's ugly, but it works
      
      * Bump Substrate
      
      * metrics: move a bunch of code around
      
      * Bumb substrate again
      
      * metrics: fix a warning
      
      * fix a warning in runtime
      
      * metrics: statements signed
      
      * metrics: statements impl RegisterMetrics
      
      * metrics: refactor Metrics trait
      
      * metrics: add Metrics assoc type to JobTrait
      
      * metrics: move Metrics trait to util
      
      * metrics: fix overseer
      
      * metrics: fix backing
      
      * metrics: fix candidate validation
      
      * metrics: derive Default
      
      * metrics: docs
      
      * metrics: add stubs for other subsystems
      
      * metrics: add more stubs and fix compilation
      
      * metrics: fix doctest
      
      * metrics: move to subsystem
      
      * metrics: fix candidate validation
      
      * metrics: bitfield signing
      
      * metrics: av store
      
      * metrics: chain API
      
      * metrics: runtime API
      
      * metrics: stub for avad
      
      * metrics: candidates seconded
      
      * metrics: ok I gave up
      
      * metrics: provisioner
      
      * metrics: remove a clone by requiring Metrics: Sync
      
      * metrics: YAGNI
      
      * metrics: remove another TODO
      
      * metrics: for later
      
      * metrics: add parachain_ prefix
      
      * metrics: s/signed_statement/signed_statements
      
      * utils: add a comment for job metrics
      
      * metrics: address review comments
      
      * metrics: oops
      
      * metrics: make sure to save files before commit 😅
      
      
      
      * use _total suffix for requests metrics
      Co-authored-by: default avatarMax Inden <mail@max-inden.de>
      
      * metrics: add tests for overseer
      
      * update Cargo.lock
      
      * overseer: add a test for CollationGeneration
      
      * collation-generation: impl metrics
      
      * collation-generation: use kebab-case for name
      
      * collation-generation: add a constructor
      Co-authored-by: default avatarGav Wood <gavin@parity.io>
      Co-authored-by: default avatarAshley Ruglys <ashley.ruglys@gmail.com>
      Co-authored-by: default avatarMax Inden <mail@max-inden.de>
      804958ab
    • Shawn Tabrizi's avatar
      Companion for Substrate 6868 (WeightInfo for System, Utility, and Timestamp) (#1606) · 62b9d4a5
      Shawn Tabrizi authored
      * fix compile warning
      
      * remove tests for weights
      
      * add custom weights
      
      * "Update Substrate"
      
      Co-authored-by: parity-processbot <>
      62b9d4a5
  5. 17 Aug, 2020 3 commits
    • Andronik Ordian's avatar
      overseer: fix build (#1596) · c61d9076
      Andronik Ordian authored
      * overseer: add a test for CollationGeneration
      
      * fix build
      c61d9076
    • Wei Tang's avatar
      Companion PR for #6862 (#1564) · c435c187
      Wei Tang authored
      
      
      * Companion PR for #6862
      
      * Check in Cargo.lock for CI
      
      * "Update Substrate"
      
      * update substrate
      
      Co-authored-by: parity-processbot <>
      Co-authored-by: André Silva's avatarAndré Silva <andre.beat@gmail.com>
      c435c187
    • Peter Goodspeed-Niklaus's avatar
      implement collation generation subsystem (#1557) · e750a825
      Peter Goodspeed-Niklaus authored
      * start sketching out a collation generation subsystem
      
      * invent a basic strategy for double initialization
      
      * clean up warnings
      
      * impl util requests from runtime assuming a context instead of a FromJob sender
      
      * implement collation generation algorithm from guide
      
      * update AllMessages in tests
      
      * fix trivial review comments
      
      * remove another redundant declaration from merge
      
      * filter availability cores by para_id
      
      * handle new activations each in their own async task
      
      * update guide according to the actual current implementation
      
      * add initialization to guide
      
      * add general-purpose subsystem_test_harness helper
      
      * write first handle_new_activations test
      
      * add test that handle_new_activations filters local_validation_data requests
      
      * add (failing) test of collation distribution message sending
      
      * rustfmt
      
      * broken: work on fixing sender test
      
      Unfortunately, for reasons that are not yet clear, despite the public key
      and checked data being identical, the signer is not producing an identical
      signature. This commit produces this output (among more):
      
      signing with  Public(c4733ab0bbe3ba4c096685d1737a7f498cdbdd167a767d04a21dc7df12b8c858 (5GWHUNm5...))
      checking with Public(c4733ab0bbe3ba4c096685d1737a7f498cdbdd167a767d04a21dc7df12b8c858 (5GWHUNm5...))
      signed payload:  [4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 10, 0, 0, 0, c7, e5, c0, 64, 7a, db, fe, 44, 81, e5, 51, 11, 79, 9f, a5, 63, 93, 94, 3c, c4, 36, c6, 30, 36, c2, c5, 44, a2, 1b, db, b7, 82, 3, 17, a, 2e, 75, 97, b7, b7, e3, d8, 4c, 5, 39, 1d, 13, 9a, 62, b1, 57, e7, 87, 86, d8, c0, 82, f2, 9d, cf, 4c, 11, 13, 14]
      checked payload: [4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 10, 0, 0, 0, c7, e5, c0, 64, 7a, db, fe, 44, 81, e5, 51, 11, 79, 9f, a5, 63, 93, 94, 3c, c4, 36, c6, 30, 36, c2, c5, 44, a2, 1b, db, b7, 82, 3, 17, a, 2e, 75, 97, b7, b7, e3, d8, 4c, 5, 39, 1d, 13, 9a, 62, b1, 57, e7, 87, 86, d8, c0, 82, f2, 9d, cf, 4c, 11, 13, 14]
      
      * fix broken test
      
      * collation function returns commitments hash
      
      It doesn't look like we use the actual commitments data anywhere, and
      it's not obvious if there are any fields of `CandidateCommitments`
      not available to the collator, so this commit just assigns them the
      entire responsibility of generating the hash.
      
      * add missing overseer impls
      
      * calculating erasure coding is polkadot's responsibility, not cumulus
      
      * concurrentize per-relay_parent requests
      e750a825
  6. 15 Aug, 2020 1 commit
  7. 14 Aug, 2020 1 commit
  8. 13 Aug, 2020 3 commits
    • Cecile Tonglet's avatar
      ae445efc
    • asynchronous rob's avatar
      Remove v0 parachains runtime (#1501) · ae5990c7
      asynchronous rob authored
      * remove v0 parachains modules and switch to v1 primitives
      
      * get tests compiling for runtime-common
      
      * remove registrar module
      
      * Add a dummy module
      
      * remove runtime-parachains
      
      * mostly remove old parachains code from polkadot-runtime
      
      * remove slots::Trait implementation
      
      * remove sp_std prelude import
      
      * add a ZeroSizedTypeDifferentiator to dummy
      
      * finish porting over polkadot runtime
      
      * ZeroSizedTypeDifferentiator was actually unnecessary
      
      * westend
      
      * kusama
      
      * test-runtime (no dummy modules)
      
      * fix warning
      
      * fix chain-specs
      
      * fix test-service
      
      * test-client
      
      * remove dead import
      
      * remove unused needed_extrinsics parameter
      
      * runtimes compile
      
      * remove rococo-v0
      
      * remove remaining references to Rococo
      
      * bump versions
      ae5990c7
    • Cecile Tonglet's avatar
      Allow using any polkadot client instead of enum Client (#1575) · 3b623579
      Cecile Tonglet authored
      * WIP
      
      Forked at: e9164236
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e9164236
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e9164236
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e9164236
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e9164236
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e9164236
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e9164236
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e9164236
      Parent branch: origin/rococo-branch
      
      * Apply suggestions from code review
      
      * WIP
      
      Forked at: e9164236
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e9164236
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e9164236
      Parent branch: origin/rococo-branch
      
      * CLEANUP
      
      Forked at: e9164236
      Parent branch: origin/rococo-branch
      
      * link in doc
      
      * doc
      3b623579
  9. 12 Aug, 2020 3 commits
    • Max Inden's avatar
      service/src/lib: Update authority discovery construction (#1563) · f73f2a86
      Max Inden authored
      * service/src/lib: Update authority discovery construction
      
      https://github.com/paritytech/substrate/pull/6760 introduces the concept
      of an authority discovery `Service` allowing one to communicate with an
      authority discovery `Worker`, e.g. to learn the `Multiaddr`s for a given
      `AuthorityId`.
      
      Along with the new `Service` structure it also alters the authority
      discovery constructor to return both a worker and a service. This
      commit adjusts the callside of the constructor, ignoring the `Service`
      for now.
      
      * "Update Substrate"
      
      * Revert ""Update Substrate""
      
      This reverts commit 04fb79c4.
      
      * Update Substrate
      
      Co-authored-by: parity-processbot <>
      f73f2a86
    • mattrutherford's avatar
      Companion PR for substrate #6672 (#1560) · 48678513
      mattrutherford authored
      
      
      * update Cargo.lock
      
      * "Update Substrate"
      Co-authored-by: default avatarMatt Rutherford <mattrutherford@users.noreply.github.com>
      Co-authored-by: parity-processbot <>
      48678513
    • asynchronous rob's avatar
      Network bridge refactoring impl (#1537) · 1e9c0540
      asynchronous rob authored
      * update networking types
      
      * port over overseer-protocol message types
      
      * Add the collation protocol to network bridge
      
      * message sending
      
      * stub for ConnectToValidators
      
      * add some helper traits and methods to protocol types
      
      * add collator protocol message
      
      * leaves-updating
      
      * peer connection and disconnection
      
      * add utilities for dispatching multiple events
      
      * implement message handling
      
      * add an observedrole enum with equality and no sentry nodes
      
      * derive partial-eq on network bridge event
      
      * add PartialEq impls for network message types
      
      * add Into implementation for observedrole
      
      * port over existing network bridge tests
      
      * add some more tests
      
      * port bitfield distribution
      
      * port over bitfield distribution tests
      
      * add codec indices
      
      * port PoV distribution
      
      * port over PoV distribution tests
      
      * port over statement distribution
      
      * port over statement distribution tests
      
      * update overseer and service-new
      
      * address review comments
      
      * port availability distribution
      
      * port over availability distribution tests
      1e9c0540
  10. 10 Aug, 2020 2 commits
  11. 07 Aug, 2020 1 commit
  12. 06 Aug, 2020 3 commits
    • Peter Goodspeed-Niklaus's avatar
      implement provisioner (#1473) · a39d8803
      Peter Goodspeed-Niklaus authored
      * sketch out provisioner basics
      
      * handle provisionable data
      
      * stub out select_inherent_data
      
      * split runtime APIs into sub-chapters to improve linkability
      
      * explain SignedAvailabilityBitfield semantics
      
      * add internal link to further documentation
      
      * some more work figuring out how the provisioner can do its thing
      
      * fix broken link
      
      * don't import enum variants where it's one layer deep
      
      * make request_availability_cores a free fn in util
      
      * document more precisely what should happen on block production
      
      * finish first-draft implementation of provisioner
      
      * start working on the full and proper backed candidate selection rule
      
      * Pass number of block under construction via RequestInherentData
      
      * Revert "Pass number of block under construction via RequestInherentData"
      
      This reverts commit 850fe62c.
      
      That initially looked like the better approach--it spent the time
      budget for fetching the block number in the proposer, instead of
      the provisioner, and that felt more appropriate--but it turns out
      not to be obvious how to get the block number of the block under
      construction from within the proposer. The Chain API may be less
      ideal, but it should be easier to implement.
      
      * wip: get the block under production from the Chain API
      
      * add ChainApiMessage to AllMessages
      
      * don't break the run loop if a provisionable data channel closes
      
      * clone only those backed candidates which are coherent
      
      * propagate chain_api subsystem through various locations
      
      * add delegated_subsystem! macro to ease delegating subsystems
      
      Unfortunately, it doesn't work right:
      
      ```
      error[E0446]: private type `CandidateBackingJob` in public interface
         --> node/core/backing/src/lib.rs:775:1
          |
      86  | struct CandidateBackingJob {
          | - `CandidateBackingJob` declared as private
      ...
      775 | delegated_subsystem!(CandidateBackingJob as CandidateBackingSubsystem);
          | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak private type
      ```
      
      I'm not sure precisely what's going wrong, here; I suspect the problem is
      the use of `$job as JobTrait>::RunArgs` and `::ToJob`; the failure would be
      that it's not reifying the types to verify that the actual types are public,
      but instead referring to them via `CandidateBackingJob`, which is in fact private;
      that privacy is the point.
      
      Going to see if I can generic my way out of this, but we may be headed for a
      quick revert here.
      
      * fix delegated_subsystem
      
      The invocation is a bit more verbose than I'd prefer, but it's also
      more explicit about what types need to be public. I'll take it as a win.
      
      * add provisioning subsystem; reduce public interface of provisioner
      
      * deny missing docs in provisioner
      
      * refactor core selection per code review suggestion
      
      This is twice as much code when measured by line, but IMO it is
      in fact somewhat clearer to read, so overall a win.
      
      Also adds an improved rule for selecting availability bitfields,
      which (unlike the previous implementation) guarantees that the
      appropriate postconditions hold there.
      
      * fix bad merge double-declaration
      
      * update guide with (hopefully) complete provisioner candidate selection procedure
      
      * clarify candidate selection algorithm
      
      * Revert "clarify candidate selection algorithm"
      
      This reverts commit c68a02ac.
      
      * clarify candidate selection algorithm
      
      * update provisioner to implement candidate selection per the guide
      
      * add test that no more than one bitfield is selected per validator
      
      * add test that each selected bitfield corresponds to an occupied core
      
      * add test that more set bits win conflicts
      
      * add macro for specializing runtime requests; specailize all runtime requests
      
      * add tests harness for select_candidates tests
      
      * add first real select_candidates test, fix test_harness
      
      * add mock overseer and test that success is possible
      
      * add test that the candidate selection algorithm picks the right ones
      
      * make candidate selection test somewhat more stringent
      a39d8803
    • Gavin Wood's avatar
      Bump Substrate (#1548) · c6ee8675
      Gavin Wood authored
      
      
      * Bump Substrate
      
      * Bumb substrate again
      Co-authored-by: default avatarAshley Ruglys <ashley.ruglys@gmail.com>
      c6ee8675
    • Cecile Tonglet's avatar
      Add SyncOracle to network's Service (#1543) · 9c04ebb5
      Cecile Tonglet authored
      * WIP
      
      * WIP
      
      Forked at: e9164236
      Parent branch: origin/rococo-branch
      
      * WIP
      
      Forked at: e9164236
      Parent branch: origin/rococo-branch
      
      * Apply suggestions from code review
      
      * Update collator/src/lib.rs
      
      * Update collator/src/lib.rs
      
      * Update network/src/protocol/mod.rs
      9c04ebb5
  13. 05 Aug, 2020 1 commit
  14. 04 Aug, 2020 4 commits
  15. 03 Aug, 2020 2 commits
  16. 02 Aug, 2020 1 commit
  17. 31 Jul, 2020 2 commits
    • Fedor Sakharov's avatar
      Parachains-runtime (#1505) · eca01a8c
      Fedor Sakharov authored
      * Initial commit
      
      * v0 to v1 primitives and remove attestations
      
      * Review fixes
      
      * implement candidate_events
      
      * remove dead code
      eca01a8c
    • Andronik Ordian's avatar
      Chain API subsystem (#1498) · d4022633
      Andronik Ordian authored
      * chain-api subsystem skeleton
      
      * chain-api subsystem: draft impl
      
      * chain-api subsystem: mock testclient
      
      * chain-api subsystem: impl HeaderBacked for TestClient
      
      * chain-api subsystem: impl basic tests
      
      * chain-api subsystem: tiny guide
      
      * chain-api subsystem: rename ChainApiRequestMessage to ChainApiMessage
      
      * chain-api subsystem: add the page to the ToC
      
      * chain-api subsystem: proper error type
      
      * chain-api subsystem: impl ancestors request
      
      * chain-api subsystem: tests for ancestors request
      
      * guide: fix ancestor return type
      
      * runtime-api subsystem: remove unused dep
      
      * fix fmt
      
      * fix outdated comment
      
      * chain-api subsystem: s/format/to_string
      
      * lower-case subsystem names
      
      * chain-api subsystem: resolve Finalized todo
      
      * chain-api subsystem: remove TODO
      
      * extract request errors into a module
      
      * remove caching TODO
      
      * fix imports
      d4022633
  18. 30 Jul, 2020 5 commits
    • asynchronous rob's avatar
      Candidate Validation Subsystem (#1432) · cdb5c408
      asynchronous rob authored
      * skeleton for candidate-validation
      
      * add to workspace
      
      * implement candidate validation logic
      
      * guide: note occupied-core assumption for candidate validation
      
      * adjust message doc
      
      * wire together `run` asynchronously
      
      * add a Subsystem implementation
      
      * clean up a couple warnings
      
      * fix compilation errors due to merge
      
      * improve candidate-validation.md
      
      * remove old reference to subsystem-test helpers crate
      
      * update Cargo.lock
      
      * add a couple new Runtime API methods
      
      * add a candidate validation message
      
      * fetch validation data from the chain state
      
      * some tests for assumption checking
      
      * make spawn_validate_exhaustive mockable
      
      * more tests on the error handling side
      
      * fix all other grumbles except for wasm validation API change
      
      * wrap a SpawnNamed in candidate-validation
      
      * warn
      
      * amend guide
      
      * squanch warning
      
      * remove duplicate after merge
      cdb5c408
    • asynchronous rob's avatar
      Implement the Runtime API subsystem (#1494) · f772196f
      asynchronous rob authored
      * type defaults for ParachainHost
      
      * add ValidationCode message
      
      * implement core loop of runtime API subsystem
      
      * subsystem trait implementation for runtime API subsystem
      
      * implement a mock runtime API
      
      * some tests that ensure requests are forwarded to runtime API correctly
      
      * fix dependency grumbles
      
      * improve RuntimeApiError API
      f772196f
    • Shawn Tabrizi's avatar
      Companion for #6610 (Balances Weight Trait) (#1425) · 7cffb429
      Shawn Tabrizi authored
      * Update for balances weights
      
      * remove unneeded tests
      
      * Add file headers
      
      * cargo update -p sp-io
      7cffb429
    • Ashley's avatar
      Add a default trie-memory-tracker feature to the cli (#1502) · 2ebe7f7d
      Ashley authored
      
      
      * Update substrate and add a trie-memory-tracker feature to the cli
      
      * Update cli/Cargo.toml
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
      2ebe7f7d
    • Ashley's avatar
      Companion PR for `Add a `DefaultQueue` type alias to remove the need to use... · fe98d73f
      Ashley authored
      Companion PR for `Add a `DefaultQueue` type alias to remove the need to use `sp_api::TransactionFor`` (#1499)
      
      * BabeImportQueue -> DefaultImportQueue
      
      * Use DefaultImportQueue from the top level of consensus_common
      
      * 'Update substrate'
      
      Co-authored-by: parity-processbot <>
      fe98d73f
  19. 29 Jul, 2020 2 commits