Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
parity
Mirrored projects
polkadot
Commits
ff5dee10
Unverified
Commit
ff5dee10
authored
Sep 10, 2020
by
Sergey Pepyakin
Committed by
GitHub
Sep 10, 2020
Browse files
Limit the maximum size of a downward message (#1690)
parent
d6ce4c00
Pipeline
#106223
canceled with stages
in 4 minutes and 35 seconds
Changes
3
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
roadmap/implementers-guide/src/runtime/router.md
View file @
ff5dee10
...
...
@@ -260,6 +260,7 @@ any of dispatchables return an error.
Utility routines.
`queue_downward_message(P: ParaId, M: DownwardMessage)`
:
1.
Check if the serialized size of
`M`
exceeds the
`config.critical_downward_message_size`
. If so, return an error.
1.
Wrap
`M`
into
`InboundDownwardMessage`
using the current block number for
`sent_at`
.
1.
Obtain a new MQC link for the resulting
`InboundDownwardMessage`
and replace
`DownwardMessageQueueHeads`
for
`P`
with the resulting hash.
1.
Add the resulting
`InboundDownwardMessage`
into
`DownwardMessageQueues`
for
`P`
.
...
...
roadmap/implementers-guide/src/types/messages.md
View file @
ff5dee10
...
...
@@ -108,10 +108,12 @@ struct InboundHrmpMessage {
## Downward Message
`DownwardMessage`
- is a message that goes down from the relay chain to a parachain. Such a message
`DownwardMessage`
- is a message that goes down from the relay chain to a parachain. Such a message
could be seen as a notification, however, it is conceivable that they might be used by the relay
chain to send a request to the parachain (likely, through the
`ParachainSpecific`
variant).
The serialized size of the message is limited by the
`config.critical_downward_message_size`
parameter.
```
rust,ignore
enum
DownwardMessage
{
/// Some funds were transferred into the parachain's account. The hash is the identifier that
...
...
roadmap/implementers-guide/src/types/runtime.md
View file @
ff5dee10
...
...
@@ -56,6 +56,13 @@ struct HostConfiguration {
pub
dispatchable_upward_message_critical_weight
:
u32
,
/// The maximum number of messages that a candidate can contain.
pub
max_upward_message_num_per_candidate
:
u32
,
/// The maximum size of a message that can be put in a downward message queue.
///
/// Since we require receiving at least one DMP message the obvious upper bound of the size is
/// the PoV size. Of course, there is a lot of other different things that a parachain may
/// decide to do with its PoV so this value in practice will be picked as a fraction of the PoV
/// size.
pub
critical_downward_message_size
:
u32
,
/// Number of sessions after which an HRMP open channel request expires.
pub
hrmp_open_request_ttl
:
u32
,
/// The deposit that the sender should provide for opening an HRMP channel.
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment