Rewrite some functions as async

collator/src/lib.rs

@@ -48,6 +48,7 @@ use std::collections::HashSet;
 use std::fmt;
 use std::sync::Arc;
 use std::time::Duration;
+use std::pin::Pin;
 
 use futures::{future, Future, Stream, FutureExt, TryFutureExt, StreamExt, task::Spawn};
 use log::{warn, error};
@@ -242,20 +243,26 @@ impl<P: 'static, E: 'static, SP: 'static> RelayChainContext for ApiContext<P, E,
 	SP: Spawn + Clone + Send + Sync
 {
 	type Error = String;
-	type FutureEgress = Box<dyn Future<Output=Result<ConsolidatedIngress, String>> + Unpin + Send>;
+	type FutureEgress = Pin<Box<dyn Future<Output=Result<ConsolidatedIngress, String>> + Send>>;
 
 	fn unrouted_egress(&self, _id: ParaId) -> Self::FutureEgress {
-		// TODO: https://github.com/paritytech/polkadot/issues/253
-		//
-		// Fetch ingress and accumulate all unrounted egress
-		let _session = self.network.instantiate_leaf_work(LeafWorkParams {
-			local_session_key: None,
-			parent_hash: self.parent_hash,
-			authorities: self.validators.clone(),
-		})
-			.map_err(|e| format!("unable to instantiate validation session: {:?}", e));
-
-		Box::new(future::ok(ConsolidatedIngress(Vec::new())))
+		let network = self.network.clone();
+		let parent_hash = self.parent_hash;
+		let authorities = self.validators.clone();
+
+		async move {
+			// TODO: https://github.com/paritytech/polkadot/issues/253
+			//
+			// Fetch ingress and accumulate all unrounted egress
+			let _session = network.instantiate_leaf_work(LeafWorkParams {
+				local_session_key: None,
+				parent_hash,
+				authorities,
+			})
+				.map_err(|e| format!("unable to instantiate validation session: {:?}", e));
+
+			Ok(ConsolidatedIngress(Vec::new()))
+		}.boxed()
 	}
 }
 
@@ -425,7 +432,7 @@ impl<P, E> Worker for CollationNode<P, E> where
 							);
 
 							let exit = inner_exit_2.clone();
-							tokio::spawn(future::select(res, exit).map(drop));
+							tokio::spawn(future::select(res.boxed(), exit).map(drop));
 						})
 					});
 

network/src/lib.rs

@@ -28,7 +28,6 @@ pub mod gossip;
 use codec::{Decode, Encode};
 use futures::channel::{oneshot, mpsc};
 use futures::prelude::*;
-use futures::future::Either;
 use polkadot_primitives::{Block, Hash, Header};
 use polkadot_primitives::parachain::{
 	Id as ParaId, CollatorId, CandidateReceipt, Collation, PoVBlock,
@@ -837,25 +836,6 @@ impl PolkadotProtocol {
 		debug!(target: "p_net", "Importing local collation on relay parent {:?} and parachain {:?}",
 			relay_parent, collation.info.parachain_index);
 
-		let res = match self.availability_store {
-			Some(ref availability_store) => {
-				let availability_store_cloned = availability_store.clone();
-				let collation_cloned = collation.clone();
-				Either::Left((async move {
-						let _ = availability_store_cloned.make_available(av_store::Data {
-							relay_parent,
-							parachain_id: collation_cloned.info.parachain_index,
-							block_data: collation_cloned.pov.block_data.clone(),
-							outgoing_queues: Some(outgoing_targeted.clone().into()),
-						}).await;
-					}
-				)
-					.boxed()
-				)
-			}
-			None => Either::Right(futures::future::ready(())),
-		};
-
 		for (primary, cloned_collation) in self.local_collations.add_collation(relay_parent, targets, collation.clone()) {
 			match self.validators.get(&primary) {
 				Some(who) => {
@@ -871,7 +851,19 @@ impl PolkadotProtocol {
 			}
 		}
 
-		res
+		let availability_store = self.availability_store.clone();
+		let collation_cloned = collation.clone();
+
+		async move {
+			if let Some(availability_store) = availability_store {
+				let _ = availability_store.make_available(av_store::Data {
+					relay_parent,
+					parachain_id: collation_cloned.info.parachain_index,
+					block_data: collation_cloned.pov.block_data.clone(),
+					outgoing_queues: Some(outgoing_targeted.clone().into()),
+				}).await;
+			}
+		}
 	}
 
 	/// Give the network protocol a handle to an availability store, used for

network/src/router.rs

@@ -41,8 +41,9 @@ use log::{debug, trace};
 use std::collections::{HashMap, HashSet};
 use std::io;
 use std::sync::Arc;
+use std::pin::Pin;
 
-use crate::validation::{self, LeafWorkDataFetcher, Executor};
+use crate::validation::{LeafWorkDataFetcher, Executor};
 use crate::NetworkService;
 
 /// Compute the gossip topic for attestations on the given parent hash.
@@ -232,7 +233,7 @@ impl<P: ProvideRuntimeApi + Send, E, N, T> TableRouter for Router<P, E, N, T> wh
 	E: Future<Output=()> + Clone + Send + 'static,
 {
 	type Error = io::Error;
-	type FetchValidationProof = validation::PoVReceiver;
+	type FetchValidationProof = Pin<Box<dyn Future<Output = Result<PoVBlock, io::Error>> + Send>>;
 
 	// We have fetched from a collator and here the receipt should have been already formed.
 	fn local_collation(

network/src/tests/validation.rs

@@ -41,7 +41,7 @@ use std::collections::HashMap;
 use std::sync::Arc;
 use std::pin::Pin;
 use std::task::{Poll, Context};
-use futures::{prelude::*, channel::mpsc};
+use futures::{prelude::*, channel::mpsc, future::{select, Either}};
 use codec::Encode;
 
 use super::{TestContext, TestChainContext};
@@ -66,77 +66,48 @@ fn clone_gossip(n: &TopicNotification) -> TopicNotification {
 	}
 }
 
-struct GossipRouter {
-	incoming_messages: mpsc::UnboundedReceiver<(Hash, TopicNotification)>,
-	incoming_streams: mpsc::UnboundedReceiver<(Hash, mpsc::UnboundedSender<TopicNotification>)>,
-	outgoing: Vec<(Hash, mpsc::UnboundedSender<TopicNotification>)>,
-	messages: Vec<(Hash, TopicNotification)>,
-}
-
-impl GossipRouter {
-	fn add_message(&mut self, topic: Hash, message: TopicNotification) {
-		self.outgoing.retain(|&(ref o_topic, ref sender)| {
-			o_topic != &topic || sender.unbounded_send(clone_gossip(&message)).is_ok()
-		});
-		self.messages.push((topic, message));
-	}
-
-	fn add_outgoing(&mut self, topic: Hash, sender: mpsc::UnboundedSender<TopicNotification>) {
-		for message in self.messages.iter()
-			.filter(|&&(ref t, _)| t == &topic)
-			.map(|&(_, ref msg)| clone_gossip(msg))
-		{
-			if let Err(_) = sender.unbounded_send(message) { return }
-		}
-
-		self.outgoing.push((topic, sender));
-	}
-}
-
-impl Future for GossipRouter {
-	type Output = ();
-
-	fn poll(self: Pin<&mut Self>, cx: &mut Context) -> Poll<Self::Output> {
-		let this = Pin::into_inner(self);
-
-		loop {
-			match Pin::new(&mut this.incoming_messages).poll_next(cx) {
-				Poll::Ready(Some((topic, message))) => this.add_message(topic, message),
-				Poll::Ready(None) => panic!("ended early."),
-				Poll::Pending => break,
-			}
-		}
-
-		loop {
-			match Pin::new(&mut this.incoming_streams).poll_next(cx) {
-				Poll::Ready(Some((topic, sender))) => this.add_outgoing(topic, sender),
-				Poll::Ready(None) => panic!("ended early."),
-				Poll::Pending => break,
-			}
+async fn gossip_router(
+	mut incoming_messages: mpsc::UnboundedReceiver<(Hash, TopicNotification)>,
+	mut incoming_streams: mpsc::UnboundedReceiver<(Hash, mpsc::UnboundedSender<TopicNotification>)>
+) {
+	let mut outgoing: Vec<(Hash, mpsc::UnboundedSender<TopicNotification>)> = Vec::new();
+	let mut messages = Vec::new();
+
+	loop {
+		match select(incoming_messages.next(), incoming_streams.next()).await {
+			Either::Left((Some((topic, message)), _)) => {
+				outgoing.retain(|&(ref o_topic, ref sender)| {
+					o_topic != &topic || sender.unbounded_send(clone_gossip(&message)).is_ok()
+				});
+				messages.push((topic, message));
+			},
+			Either::Right((Some((topic, sender)), _)) => {
+				for message in messages.iter()
+					.filter(|&&(ref t, _)| t == &topic)
+					.map(|&(_, ref msg)| clone_gossip(msg))
+					{
+						if let Err(_) = sender.unbounded_send(message) { return }
+					}
+
+				outgoing.push((topic, sender));
+			},
+			Either::Left((None, _)) | Either::Right((None, _)) =>  panic!("ended early.")
 		}
-
-		Poll::Pending
 	}
 }
 
-
 #[derive(Clone)]
 struct GossipHandle {
 	send_message: mpsc::UnboundedSender<(Hash, TopicNotification)>,
 	send_listener: mpsc::UnboundedSender<(Hash, mpsc::UnboundedSender<TopicNotification>)>,
 }
 
-fn make_gossip() -> (GossipRouter, GossipHandle) {
+fn make_gossip() -> (impl Future<Output = ()>, GossipHandle) {
 	let (message_tx, message_rx) = mpsc::unbounded();
 	let (listener_tx, listener_rx) = mpsc::unbounded();
 
 	(
-		GossipRouter {
-			incoming_messages: message_rx,
-			incoming_streams: listener_rx,
-			outgoing: Vec::new(),
-			messages: Vec::new(),
-		},
+		gossip_router(message_rx, listener_rx),
 		GossipHandle { send_message: message_tx, send_listener: listener_tx },
 	)
 }
@@ -344,7 +315,7 @@ type TestValidationNetwork = crate::validation::ValidationNetwork<
 >;
 
 struct Built {
-	gossip: GossipRouter,
+	gossip: Pin<Box<dyn Future<Output = ()>>>,
 	api_handle: Arc<Mutex<ApiData>>,
 	networks: Vec<TestValidationNetwork>,
 }
@@ -377,7 +348,7 @@ fn build_network(n: usize, executor: TaskExecutor) -> Built {
 	let networks: Vec<_> = networks.collect();
 
 	Built {
-		gossip: gossip_router,
+		gossip: gossip_router.boxed(),
 		api_handle,
 		networks,
 	}

network/src/validation.rs

@@ -33,14 +33,13 @@ use polkadot_primitives::parachain::{
 use futures::prelude::*;
 use futures::task::SpawnExt;
 pub use futures::task::Spawn as Executor;
-use futures::channel::oneshot::{self, Receiver};
+use futures::channel::oneshot;
 use futures::future::{ready, select};
 
 use std::collections::hash_map::{HashMap, Entry};
 use std::io;
 use std::sync::Arc;
 use std::pin::Pin;
-use std::task::{Poll, Context};
 
 use arrayvec::ArrayVec;
 use parking_lot::Mutex;
@@ -242,47 +241,30 @@ impl<P, E, N, T> ParachainNetwork for ValidationNetwork<P, E, N, T> where
 #[derive(Clone, Copy, Debug, PartialEq, Eq)]
 pub struct NetworkDown;
 
-/// A future that resolves when a collation is received.
-pub struct AwaitingCollation {
-	outer: oneshot::Receiver<oneshot::Receiver<Collation>>,
-	inner: Option<oneshot::Receiver<Collation>>
-}
-
-impl Future for AwaitingCollation {
-	type Output = Result<Collation, NetworkDown>;
-
-	fn poll(self: Pin<&mut Self>, cx: &mut Context) -> Poll<Self::Output> {
-		let this = Pin::into_inner(self);
-
-		if let Some(ref mut inner) = this.inner {
-			return Pin::new(inner).poll(cx).map_err(|_| NetworkDown)
-		}
-		match Pin::new(&mut this.outer).poll(cx) {
-			Poll::Ready(Ok(inner)) => {
-				this.inner = Some(inner);
-				Pin::new(this).poll(cx)
-			},
-			Poll::Ready(Err(_)) => Poll::Ready(Err(NetworkDown)),
-			Poll::Pending => Poll::Pending,
-		}
-	}
-}
-
 impl<P, E: Clone, N, T: Clone> Collators for ValidationNetwork<P, E, N, T> where
 	P: ProvideRuntimeApi + Send + Sync + 'static,
 	P::Api: ParachainHost<Block>,
 	N: NetworkService,
 {
 	type Error = NetworkDown;
-	type Collation = AwaitingCollation;
+	type Collation = Pin<Box<dyn Future<Output = Result<Collation, NetworkDown>> + Send>>;
 
 	fn collate(&self, parachain: ParaId, relay_parent: Hash) -> Self::Collation {
 		let (tx, rx) = oneshot::channel();
-		self.network.with_spec(move |spec, _| {
-			let collation = spec.await_collation(relay_parent, parachain);
-			let _ = tx.send(collation);
-		});
-		AwaitingCollation{outer: rx, inner: None}
+		let network = self.network.clone();
+
+		// A future that resolves when a collation is received.
+		async move {
+			network.with_spec(move |spec, _| {
+				let collation = spec.await_collation(relay_parent, parachain);
+				let _ = tx.send(collation);
+			});
+
+			rx.await
+				.map_err(|_| NetworkDown)?
+				.await
+				.map_err(|_| NetworkDown)
+		}.boxed()
 	}
 
 
@@ -348,27 +330,6 @@ impl Knowledge {
 	}
 }
 
-/// receiver for incoming data.
-#[derive(Clone)]
-pub struct IncomingReceiver {
-	inner: future::Shared<Receiver<Incoming>>
-}
-
-impl Future for IncomingReceiver {
-	type Output = Result<Incoming, io::Error>;
-
-	fn poll(self: Pin<&mut Self>, cx: &mut Context) -> Poll<Self::Output> {
-		match Pin::new(&mut Pin::into_inner(self).inner).poll(cx) {
-			Poll::Ready(Ok(i)) => Poll::Ready(Ok(Incoming::clone(&i))),
-			Poll::Ready(Err(_)) => Poll::Ready(Err(io::Error::new(
-				io::ErrorKind::Other,
-				"Sending end of channel hung up",
-			))),
-			Poll::Pending => Poll::Pending,
-		}
-	}
-}
-
 /// A current validation leaf-work instance
 #[derive(Clone)]
 pub(crate) struct LiveValidationLeaf {
@@ -564,36 +525,6 @@ impl LiveValidationLeaves {
 	}
 }
 
-/// Receiver for block data.
-pub struct PoVReceiver {
-	outer: Receiver<Receiver<PoVBlock>>,
-	inner: Option<Receiver<PoVBlock>>
-}
-
-impl Future for PoVReceiver {
-	type Output = Result<PoVBlock, io::Error>;
-
-	fn poll(self: Pin<&mut Self>, cx: &mut Context) -> Poll<Self::Output> {
-		let this = Pin::into_inner(self);
-
-		let map_err = |_| io::Error::new(
-			io::ErrorKind::Other,
-			"Sending end of channel hung up",
-		);
-
-		if let Some(ref mut inner) = this.inner {
-			return Pin::new(inner).poll(cx).map_err(map_err);
-		}
-		match Pin::new(&mut this.outer).poll(cx).map_err(map_err)? {
-			Poll::Ready(inner) => {
-				this.inner = Some(inner);
-				Pin::new(this).poll(cx)
-			}
-			Poll::Pending => Poll::Pending,
-		}
-	}
-}
-
 /// Can fetch data for a given validation leaf-work instance.
 pub struct LeafWorkDataFetcher<P, E, N: NetworkService, T> {
 	network: Arc<N>,
@@ -658,9 +589,14 @@ impl<P: ProvideRuntimeApi + Send, E, N, T> LeafWorkDataFetcher<P, E, N, T> where
 	E: Future<Output=()> + Clone + Send + 'static,
 {
 	/// Fetch PoV block for the given candidate receipt.
-	pub fn fetch_pov_block(&self, candidate: &CandidateReceipt) -> PoVReceiver {
+	pub fn fetch_pov_block(&self, candidate: &CandidateReceipt)
+		-> Pin<Box<dyn Future<Output = Result<PoVBlock, io::Error>> + Send>> {
+
 		let parachain = candidate.parachain_index;
 		let parent_hash = self.parent_hash;
+		let network = self.network.clone();
+		let candidate = candidate.clone();
+		let (tx, rx) = oneshot::channel();
 
 		let canon_roots = self.api.runtime_api().ingress(
 			&BlockId::hash(parent_hash),
@@ -676,15 +612,24 @@ impl<P: ProvideRuntimeApi + Send, E, N, T> LeafWorkDataFetcher<P, E, N, T> where
 				)
 			);
 
-		let candidate = candidate.clone();
-		let (tx, rx) = oneshot::channel();
-		self.network.with_spec(move |spec, ctx| {
-			if let Ok(Some(canon_roots)) = canon_roots {
-				let inner_rx = spec.fetch_pov_block(ctx, &candidate, parent_hash, canon_roots);
-				let _ = tx.send(inner_rx);
-			}
-		});
-		PoVReceiver { outer: rx, inner: None }
+		async move {
+			network.with_spec(move |spec, ctx| {
+				if let Ok(Some(canon_roots)) = canon_roots {
+					let inner_rx = spec.fetch_pov_block(ctx, &candidate, parent_hash, canon_roots);
+					let _ = tx.send(inner_rx);
+				}
+			});
+
+			let map_err = |_| io::Error::new(
+				io::ErrorKind::Other,
+				"Sending end of channel hung up",
+			);
+
+			rx.await
+				.map_err(map_err)?
+				.await
+				.map_err(map_err)
+		}.boxed()
 	}
 }
 

validation/src/collation.rs

@@ -32,8 +32,6 @@ use parachain::{wasm_executor::{self, ExternalitiesError, ExecutionMode}, Messag
 use trie::TrieConfiguration;
 use futures::prelude::*;
 use log::debug;
-use std::task::{Poll, Context};
-use std::pin::Pin;
 
 /// Encapsulates connections to collators and allows collation on any parachain.
 ///
@@ -58,94 +56,41 @@ pub trait Collators: Clone {
 }
 
 /// A future which resolves when a collation is available.
-///
-/// This future is fused.
-pub struct CollationFetch<C: Collators, P> {
+pub async fn collation_fetch<C: Collators, P>(
 	parachain: ParaId,
 	relay_parent_hash: Hash,
-	relay_parent: BlockId,
 	collators: C,
-	live_fetch: Option<C::Collation>,
 	client: Arc<P>,
 	max_block_data_size: Option<u64>,
-}
-
-impl<C: Collators, P> CollationFetch<C, P> {
-	/// Create a new collation fetcher for the given chain.
-	pub fn new(
-		parachain: ParaId,
-		relay_parent_hash: Hash,
-		collators: C,
-		client: Arc<P>,
-		max_block_data_size: Option<u64>,
-	) -> Self {
-		CollationFetch {
-			relay_parent: BlockId::hash(relay_parent_hash),
-			relay_parent_hash,
-			collators,
-			client,
-			parachain,
-			live_fetch: None,
-			max_block_data_size,
-		}
-	}
-
-	/// Access the underlying relay parent hash.
-	pub fn relay_parent(&self) -> Hash {
-		self.relay_parent_hash
-	}
-
-	/// Access the local parachain ID.
-	pub fn parachain(&self) -> ParaId {
-		self.parachain
-	}
-}
-
-impl<C, P> Future for CollationFetch<C, P>
+) -> Result<(Collation, OutgoingMessages, Balance),C::Error>
 	where
 		P::Api: ParachainHost<Block, Error = sp_blockchain::Error>,
 		C: Collators + Unpin,
 		P: ProvideRuntimeApi,
 		<C as Collators>::Collation: Unpin,
 {
-	type Output = Result<(Collation, OutgoingMessages, Balance),C::Error>;
-
-	fn poll(self: Pin<&mut Self>, cx: &mut Context) -> Poll<Self::Output> {
-		let this = Pin::into_inner(self);
-
-		loop {
-			let collation = {
-				let parachain = this.parachain.clone();
-				let (r, c)  = (this.relay_parent_hash, &this.collators);
+	let relay_parent = BlockId::hash(relay_parent_hash);
 
-				let future = this.live_fetch
-					.get_or_insert_with(move || c.collate(parachain, r));
-
-				match Pin::new(future).poll(cx) {
-					Poll::Ready(Ok(c)) => c,
-					Poll::Ready(Err(err)) => return Poll::Ready(Err(err)),
-					Poll::Pending => return Poll::Pending
-				}
-			};
+	loop {
+		let collation = collators.collate(parachain, relay_parent_hash)
+			.await?;
 
-			let res = validate_collation(
-				&*this.client,
-				&this.relay_parent,
-				&collation,
-				this.max_block_data_size,
-			);
+		let res = validate_collation(
+			&*client,
+			&relay_parent,
+			&collation,
+			max_block_data_size,
+		);
 
-			match res {
-				Ok((messages, fees)) => {
-					return Poll::Ready(Ok((collation, messages, fees)))
-				}
-				Err(e) => {
-					debug!("Failed to validate parachain due to API error: {}", e);
+		match res {
+			Ok((messages, fees)) => {
+				return Ok((collation, messages, fees))
+			}
+			Err(e) => {
+				debug!("Failed to validate parachain due to API error: {}", e);
 
-					// just continue if we got a bad collation or failed to validate
-					this.live_fetch = None;
-					this.collators.note_bad_collator(collation.info.collator)
-				}
+				// just continue if we got a bad collation or failed to validate
+				collators.note_bad_collator(collation.info.collator)
 			}
 		}
 	}

validation/src/lib.rs

@@ -34,8 +34,6 @@ use std::{
 	pin::Pin,
 	sync::Arc,
 	time::{self, Duration, Instant},
-	task::{Poll, Context},
-	mem,
 };
 
 use babe_primitives::BabeApi;
@@ -60,8 +58,8 @@ use txpool_api::{TransactionPool, InPoolTransaction};
 
 use attestation_service::ServiceHandle;
 use futures::prelude::*;
-use futures::{future::{self, Either, select, ready}, stream::unfold, task::{Spawn, SpawnExt}};
-use collation::CollationFetch;
+use futures::{future::{select, ready}, stream::unfold, task::{Spawn, SpawnExt}};
+use collation::collation_fetch;
 use dynamic_inclusion::DynamicInclusion;
 use inherents::InherentData;
 use sp_timestamp::TimestampInherentData;
@@ -396,7 +394,7 @@ impl<C, N, P> ParachainValidation<C, N, P> where
 
 		let with_router = move |router: N::TableRouter| {
 			// fetch a local collation from connected collators.
-			let collation_work = CollationFetch::new(
+			let collation_work = collation_fetch(