Unverified Commit d3a0c571 authored by Andronik Ordian's avatar Andronik Ordian Committed by GitHub
Browse files

guide: minor fixes approval distribution (#2129)

* guide: add missing ApprovalDistributionMessage variant

* guide: deduplicate sensence
parent 20c3d634
Pipeline #117465 passed with stages
in 21 minutes and 17 seconds
......@@ -16,7 +16,7 @@ Approval messages should always follow assignments, so we need to be able to dis
1. Is a particular assignment relevant under a given `View`?
2. Is a particular approval relevant to any assignment in a set?
It is acceptable for these two queries to yield false negatives with respect to our peers' views. For our own local view, they must not yield false negatives. When applied to our peers' views, it is acceptable for them to yield false negatives. The reason for that is that our peers' views may be beyond ours, and we are not capable of fully evaluating them. Once we have caught up, we can check again for false negatives to continue distributing.
For our own local view, these two queries must not yield false negatives. When applied to our peers' views, it is acceptable for them to yield false negatives. The reason for that is that our peers' views may be beyond ours, and we are not capable of fully evaluating them. Once we have caught up, we can check again for false negatives to continue distributing.
For assignments, what we need to be checking is whether we are aware of the (block, candidate) pair that the assignment references. For approvals, we need to be aware of an assignment by the same validator which references the candidate being approved.
......
......@@ -115,6 +115,8 @@ enum ApprovalDistributionMessage {
/// valid, relevant, and the corresponding approval already issued. If not, the subsystem is free to drop
/// the message.
DistributeApproval(IndirectSignedApprovalVote),
/// An update from the network bridge.
NetworkBridgeUpdateV1(NetworkBridgeEvent<ApprovalDistributionV1Message>),
}
```
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment