Skip to content
GitLab
Unverified Commit ad985e61 authored by Arkadiy Paronyan's avatar Arkadiy Paronyan Committed by GitHub
Browse files

Additional logging (#2693)

parent d2d50352
Pipeline #130332 failed with stages
in 15 minutes and 12 seconds
Hide whitespace changes
Inline Side-by-side
node/network/approval-distribution/src/lib.rs
View file @ ad985e61
......@@ -410,6 +410,14 @@ impl State {
Some(entry) => entry,
None => {
if let Some(peer_id) = source.peer_id() {
tracing::debug!(
target: LOG_TARGET,
?source,
?peer_id,
?block_hash,
?validator_index,
"Unexpected assignment",
);
modify_reputation(ctx, peer_id, COST_UNEXPECTED_MESSAGE).await;
}
return;
......@@ -428,11 +436,25 @@ impl State {
match entry.known_by.entry(peer_id.clone()) {
hash_map::Entry::Occupied(knowledge) => {
if knowledge.get().known_messages.contains(&fingerprint) {
tracing::debug!(
target: LOG_TARGET,
?source,
?peer_id,
?fingerprint,
"Duplicate assignment",
);
modify_reputation(ctx, peer_id, COST_DUPLICATE_MESSAGE).await;
return;
}
}
hash_map::Entry::Vacant(_) => {
tracing::debug!(
target: LOG_TARGET,
?source,
?peer_id,
?fingerprint,
"Assignment from unknown peer",
);
modify_reputation(ctx, peer_id.clone(), COST_UNEXPECTED_MESSAGE).await;
}
}
......@@ -441,6 +463,13 @@ impl State {
if entry.knowledge.known_messages.contains(&fingerprint) {
modify_reputation(ctx, peer_id.clone(), BENEFIT_VALID_MESSAGE).await;
if let Some(peer_knowledge) = entry.known_by.get_mut(&peer_id) {
tracing::trace!(
target: LOG_TARGET,
?source,
?peer_id,
?fingerprint,
"Known assignment",
);
peer_knowledge.known_messages.insert(fingerprint.clone());
}
return;
......@@ -465,6 +494,14 @@ impl State {
}
};
tracing::trace!(
target: LOG_TARGET,
?source,
?peer_id,
?fingerprint,
?result,
"Checked assignment",
);
match result {
AssignmentCheckResult::Accepted => {
modify_reputation(ctx, peer_id.clone(), BENEFIT_VALID_MESSAGE_FIRST).await;
......@@ -488,11 +525,6 @@ impl State {
}
AssignmentCheckResult::Bad => {
modify_reputation(ctx, peer_id, COST_INVALID_MESSAGE).await;
tracing::info!(
target: LOG_TARGET,
?peer_id,
"Got a bad assignment from peer",
);
return;
}
}
......@@ -599,6 +631,13 @@ impl State {
);
if !entry.knowledge.known_messages.contains(&assignment_fingerprint) {
tracing::debug!(
target: LOG_TARGET,
?source,
?peer_id,
?fingerprint,
"Unknown approval assignment",
);
modify_reputation(ctx, peer_id, COST_UNEXPECTED_MESSAGE).await;
return;
}
......@@ -606,18 +645,39 @@ impl State {
// check if our knowledge of the peer already contains this approval
match entry.known_by.entry(peer_id.clone()) {
hash_map::Entry::Occupied(knowledge) => {
tracing::debug!(
target: LOG_TARGET,
?source,
?peer_id,
?fingerprint,
"Duplicate approval",
);
if knowledge.get().known_messages.contains(&fingerprint) {
modify_reputation(ctx, peer_id, COST_DUPLICATE_MESSAGE).await;
return;
}
}
hash_map::Entry::Vacant(_) => {
tracing::debug!(
target: LOG_TARGET,
?source,
?peer_id,
?fingerprint,
"Approval from unknown peer",
);
modify_reputation(ctx, peer_id.clone(), COST_UNEXPECTED_MESSAGE).await;
}
}
// if the approval is known to be valid, reward the peer
if entry.knowledge.known_messages.contains(&fingerprint) {
tracing::trace!(
target: LOG_TARGET,
?source,
?peer_id,
?fingerprint,
"Known approval",
);
modify_reputation(ctx, peer_id.clone(), BENEFIT_VALID_MESSAGE).await;
if let Some(peer_knowledge) = entry.known_by.get_mut(&peer_id) {
peer_knowledge.known_messages.insert(fingerprint.clone());
......@@ -643,6 +703,14 @@ impl State {
}
};
tracing::trace!(
target: LOG_TARGET,
?source,
?peer_id,
?fingerprint,
?result,
"Checked approval",
);
match result {
ApprovalCheckResult::Accepted => {
modify_reputation(ctx, peer_id.clone(), BENEFIT_VALID_MESSAGE_FIRST).await;
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment