Unverified Commit a218a1fe authored by asynchronous rob's avatar asynchronous rob Committed by GitHub
Browse files

use a gauge for approval lag (#2725)

parent be096891
Pipeline #130938 canceled with stages
in 5 minutes and 45 seconds
...@@ -42,7 +42,7 @@ use { ...@@ -42,7 +42,7 @@ use {
#[cfg(feature = "real-overseer")] #[cfg(feature = "real-overseer")]
#[derive(Clone)] #[derive(Clone)]
pub(crate) struct ApprovalCheckingDiagnostic { pub(crate) struct ApprovalCheckingDiagnostic {
checking_lag: Option<prometheus_endpoint::Histogram>, checking_lag: Option<prometheus_endpoint::Gauge<prometheus_endpoint::U64>>,
overseer: OverseerHandler, overseer: OverseerHandler,
} }
...@@ -55,11 +55,11 @@ impl ApprovalCheckingDiagnostic { ...@@ -55,11 +55,11 @@ impl ApprovalCheckingDiagnostic {
Ok(ApprovalCheckingDiagnostic { Ok(ApprovalCheckingDiagnostic {
checking_lag: if let Some(registry) = registry { checking_lag: if let Some(registry) = registry {
Some(prometheus_endpoint::register( Some(prometheus_endpoint::register(
prometheus_endpoint::Histogram::with_opts( prometheus_endpoint::Gauge::with_opts(
prometheus_endpoint::HistogramOpts::new( prometheus_endpoint::Opts::new(
"parachain_approval_checking_finality_lag", "parachain_approval_checking_finality_lag",
"How far behind the head of the chain the Approval Checking protocol wants to vote", "How far behind the head of the chain the Approval Checking protocol wants to vote",
).buckets(vec![1.0, 2.0, 3.0, 4.0, 5.0, 10.0, 20.0, 30.0, 40.0, 50.0]) )
)?, )?,
registry, registry,
)?) )?)
...@@ -154,7 +154,7 @@ impl<B> grandpa::VotingRule<PolkadotBlock, B> for ApprovalCheckingDiagnostic ...@@ -154,7 +154,7 @@ impl<B> grandpa::VotingRule<PolkadotBlock, B> for ApprovalCheckingDiagnostic
); );
if let Some(ref checking_lag) = checking_lag { if let Some(ref checking_lag) = checking_lag {
checking_lag.observe(approval_checking_subsystem_lag as _); checking_lag.set(approval_checking_subsystem_lag as _);
} }
tracing::debug!( tracing::debug!(
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment