Unverified Commit 9e8b26fe authored by sandreim's avatar sandreim Committed by GitHub
Browse files

Per subsystem CPU usage tracking (#4239)



* SubsystemContext: add subsystem name str

Signed-off-by: sandreim's avatarAndrei Sandu <sandu.andrei@gmail.com>

* Overseer builder proc macro changes

* initilize SubsystemContext name field.
* Add subsystem name in TaskKind::launch_task()

Signed-off-by: sandreim's avatarAndrei Sandu <sandu.andrei@gmail.com>

* Update ToOverseer enum

Signed-off-by: sandreim's avatarAndrei Sandu <sandu.andrei@gmail.com>

* Assign subsystem names to orphan tasks

Signed-off-by: sandreim's avatarAndrei Sandu <sandu.andrei@gmail.com>

* cargo fmt

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* SubsystemContext: add subsystem name str

Signed-off-by: sandreim's avatarAndrei Sandu <sandu.andrei@gmail.com>

* Overseer builder proc macro changes

* initilize SubsystemContext name field.
* Add subsystem name in TaskKind::launch_task()

Signed-off-by: sandreim's avatarAndrei Sandu <sandu.andrei@gmail.com>

* Update ToOverseer enum

Signed-off-by: sandreim's avatarAndrei Sandu <sandu.andrei@gmail.com>

* Assign subsystem names to orphan tasks

Signed-off-by: sandreim's avatarAndrei Sandu <sandu.andrei@gmail.com>

* cargo fmt

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Rebase changes for new spawn() group param

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Add subsystem constat in JobTrait

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Add subsystem string

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Fix tests

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Fix spawn() calls

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* cargo fmt

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Fix

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Fix tests

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* fix

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Fix more tests

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Address PR review feedback #1



Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Address PR review round 2

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* Fixes
- remove JobTrait::Subsystem
- fix tests

Signed-off-by: default avatarAndrei Sandu <andrei-mihail@parity.io>

* update Cargo.lock

Co-authored-by: Andronik Ordian's avatarAndronik Ordian <write@reusable.software>
parent 83e5955b
Pipeline #165611 failed with stages
in 36 minutes and 32 seconds
......@@ -62,7 +62,7 @@ impl JobTrait for FakeCollatorProtocolJob {
type RunArgs = bool;
type Metrics = ();
const NAME: &'static str = "FakeCollatorProtocolJob";
const NAME: &'static str = "fake-collator-protocol-job";
/// Run a job for the parent block indicated
//
......@@ -199,7 +199,7 @@ fn test_subsystem_impl_and_name_derivation() {
let SpawnedSubsystem { name, .. } =
FakeCollatorProtocolSubsystem::new(pool, false, ()).start(context);
assert_eq!(name, "FakeCollatorProtocol");
assert_eq!(name, "fake-collator-protocol");
}
#[test]
......
......@@ -186,6 +186,7 @@ impl Collator {
let seconded_collations = seconded_collations.clone();
spawner.spawn(
"adder-collator-seconded",
None,
async move {
if let Ok(res) = recv.await {
if !matches!(
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment