Commit 82fab47e authored by joe petrowski's avatar joe petrowski Committed by Bastian Köcher
Browse files

Correct FIXME/TODO in service module (#164)

* remove TODO

TODO should have been removed after the last update

* add issue link to grandpa config

* add todo with link

* update issue link to substrate
parent 0149005a
Pipeline #31821 passed with stages
in 9 minutes and 34 seconds
......@@ -54,7 +54,8 @@ fn staging_testnet_config_genesis() -> GenesisConfig {
const DAYS: u64 = HOURS * 24;
GenesisConfig {
consensus: Some(ConsensusConfig {
code: include_bytes!("../../runtime/wasm/target/wasm32-unknown-unknown/release/polkadot_runtime.compact.wasm").to_vec(), // TODO change
// TODO: Change after Substrate 1252 is fixed (https://github.com/paritytech/substrate/issues/1252)
code: include_bytes!("../../runtime/wasm/target/wasm32-unknown-unknown/release/polkadot_runtime.compact.wasm").to_vec(),
authorities: initial_authorities.clone(),
}),
system: None,
......
......@@ -178,7 +178,9 @@ construct_service_factory! {
{
let voter = grandpa::run_grandpa(
grandpa::Config {
gossip_duration: Duration::new(4, 0), // FIXME: make this available through chainspec?
// TODO: make gossip_duration available through chainspec
// https://github.com/paritytech/substrate/issues/1578
gossip_duration: Duration::new(4, 0),
local_key: key.clone(),
justification_period: 4096,
name: Some(service.config.name.clone()),
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment