Commit 80d7e03c authored by Bastian Köcher's avatar Bastian Köcher Committed by GitHub
Browse files

Be specific about the `BitVec` generic arguments (#830)

* Be specific about the `BitVec` generic arguments

Currently we use the default generic arguments for `BitVec`. This means
we use `BigEndian` and `u8`. These default values are not stable, with
`0.17` of the `BitVec` crate this changes. To make sure we don't break
anything in the future, make sure we explictly set the generics.

* Update `spec_version`
parent 8303f7d5
Pipeline #78126 passed with stages
in 23 minutes and 50 seconds
......@@ -516,7 +516,7 @@ pub struct AttestedCandidate {
/// Validity attestations.
pub validity_votes: Vec<ValidityAttestation>,
/// Indices of the corresponding validity votes.
pub validator_indices: BitVec,
pub validator_indices: BitVec<bitvec::cursor::LittleEndian, u8>,
}
impl AttestedCandidate {
......
......@@ -862,7 +862,7 @@ mod tests {
.collect(),
validator_indices: roster.iter()
.map(|i| i == &Chain::Parachain(id))
.collect::<BitVec>(),
.collect::<BitVec::<_, _>>(),
}
}
......
......@@ -77,7 +77,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
spec_name: create_runtime_str!("kusama"),
impl_name: create_runtime_str!("parity-kusama"),
authoring_version: 2,
spec_version: 1046,
spec_version: 1047,
impl_version: 0,
apis: RUNTIME_API_VERSIONS,
};
......
......@@ -519,7 +519,11 @@ impl SharedTable {
}).collect();
validity_votes.sort_by(|(id1, _), (id2, _)| id1.cmp(id2));
let mut validator_indices = bitvec![0; validity_votes.last().map(|(i, _)| i + 1).unwrap_or_default()];
let mut validator_indices = bitvec![
bitvec::cursor::LittleEndian, u8;
0;
validity_votes.last().map(|(i, _)| i + 1).unwrap_or_default()
];
for (id, _) in &validity_votes {
validator_indices.set(*id, true);
}
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment