Unverified Commit 7a7d41c2 authored by Cecile Tonglet's avatar Cecile Tonglet Committed by GitHub
Browse files

Use spawner to spawn work task instead of tokio (#1328)

* Use spawner to spawn work task instead of tokio

This allows the caller to choose the runtime they want (instead of tokio).

* Replace generic by actual type
parent f930c7bd
Pipeline #98834 passed with stages
in 22 minutes and 56 seconds
...@@ -81,6 +81,7 @@ use polkadot_service_new::{ ...@@ -81,6 +81,7 @@ use polkadot_service_new::{
self as polkadot_service, self as polkadot_service,
Error as ServiceError, FullNodeHandles, PolkadotClient, Error as ServiceError, FullNodeHandles, PolkadotClient,
}; };
use sc_service::SpawnTaskHandle;
const COLLATION_TIMEOUT: Duration = Duration::from_secs(30); const COLLATION_TIMEOUT: Duration = Duration::from_secs(30);
...@@ -236,8 +237,8 @@ fn build_collator_service<SP, P, C, R, Extrinsic>( ...@@ -236,8 +237,8 @@ fn build_collator_service<SP, P, C, R, Extrinsic>(
#[cfg(not(feature = "service-rewr"))] #[cfg(not(feature = "service-rewr"))]
fn build_collator_service<SP, P, C, R, Extrinsic>( fn build_collator_service<P, C, R, Extrinsic>(
spawner: SP, spawner: SpawnTaskHandle,
handles: FullNodeHandles, handles: FullNodeHandles,
client: Arc<C>, client: Arc<C>,
para_id: ParaId, para_id: ParaId,
...@@ -265,7 +266,6 @@ fn build_collator_service<SP, P, C, R, Extrinsic>( ...@@ -265,7 +266,6 @@ fn build_collator_service<SP, P, C, R, Extrinsic>(
P::ParachainContext: Send + 'static, P::ParachainContext: Send + 'static,
<P::ParachainContext as ParachainContext>::ProduceCandidate: Send, <P::ParachainContext as ParachainContext>::ProduceCandidate: Send,
Extrinsic: service::Codec + Send + Sync + 'static, Extrinsic: service::Codec + Send + Sync + 'static,
SP: Spawn + Clone + Send + Sync + 'static,
{ {
let polkadot_network = handles.polkadot_network let polkadot_network = handles.polkadot_network
.ok_or_else(|| "Collator cannot run when Polkadot-specific networking has not been started")?; .ok_or_else(|| "Collator cannot run when Polkadot-specific networking has not been started")?;
...@@ -278,7 +278,7 @@ fn build_collator_service<SP, P, C, R, Extrinsic>( ...@@ -278,7 +278,7 @@ fn build_collator_service<SP, P, C, R, Extrinsic>(
let parachain_context = match build_parachain_context.build( let parachain_context = match build_parachain_context.build(
client.clone(), client.clone(),
spawner, spawner.clone(),
polkadot_network.clone(), polkadot_network.clone(),
) { ) {
Ok(ctx) => ctx, Ok(ctx) => ctx,
...@@ -359,7 +359,7 @@ fn build_collator_service<SP, P, C, R, Extrinsic>( ...@@ -359,7 +359,7 @@ fn build_collator_service<SP, P, C, R, Extrinsic>(
let future = silenced.map(drop); let future = silenced.map(drop);
tokio::spawn(future); spawner.spawn("collation-work", future);
} }
}.boxed(); }.boxed();
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment