Unverified Commit 6cb31e50 authored by Bastian Köcher's avatar Bastian Köcher Committed by GitHub
Browse files

Fix unoccupied bitfields (#4004)

* Fix unoccupied bitfields

If there is an unoccupied bitfield set, we should just ignore it and not
keep it for the rest of the logic in `process_bitfields`.

* Bring back test, but this time corrected

* Remove incorrect code
parent f9518071
Pipeline #160441 passed with stages
in 53 minutes and 35 seconds
......@@ -180,8 +180,6 @@ pub mod pallet {
NotCollatorSigned,
/// The validation data hash does not match expected.
ValidationDataHashMismatch,
/// Internal error only returned when compiled with debug assertions.
InternalError,
/// The downward message queue is not processed correctly.
IncorrectDownwardMessageHandling,
/// At least one upward message sent does not pass the acceptance criteria.
......@@ -328,8 +326,6 @@ impl<T: Config> Pallet<T> {
candidate_pending_availability.availability_votes.get_mut(val_idx)
}) {
*bit = true;
} else if cfg!(debug_assertions) {
ensure!(false, Error::<T>::InternalError);
}
}
......@@ -1412,13 +1408,14 @@ mod tests {
bare_bitfield,
&signing_context,
));
assert!(ParaInclusion::process_bitfields(
expected_bits(),
vec![signed.into()],
&core_lookup,
)
.is_err());
assert_eq!(
ParaInclusion::process_bitfields(
expected_bits(),
vec![signed.into()],
&core_lookup,
),
Ok(vec![])
);
}
// empty bitfield signed: always OK, but kind of useless.
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment