Unverified Commit 592fd7b1 authored by Bastian Köcher's avatar Bastian Köcher Committed by GitHub
Browse files

Fix proposer factory prometheus registration (#1862)

The proposer wasn't registered in prometheus and thus, we could not see
its metrics.
parent 69902e05
Pipeline #112297 canceled with stages
in 9 minutes and 48 seconds
......@@ -4980,6 +4980,7 @@ dependencies = [
"sp-inherents",
"sp-runtime",
"sp-transaction-pool",
"substrate-prometheus-endpoint",
"wasm-timer",
]
......
......@@ -20,4 +20,5 @@ sp-core = { git = "https://github.com/paritytech/substrate", branch = "master" }
sp-inherents = { git = "https://github.com/paritytech/substrate", branch = "master" }
sp-runtime = { git = "https://github.com/paritytech/substrate", branch = "master" }
sp-transaction-pool = { git = "https://github.com/paritytech/substrate", branch = "master" }
prometheus-endpoint = { package = "substrate-prometheus-endpoint", git = "https://github.com/paritytech/substrate", branch = "master" }
wasm-timer = "0.2.4"
......@@ -33,6 +33,7 @@ use sp_consensus::{Proposal, RecordProof};
use sp_inherents::InherentData;
use sp_runtime::traits::{DigestFor, HashFor};
use sp_transaction_pool::TransactionPool;
use prometheus_endpoint::Registry as PrometheusRegistry;
use std::{fmt, pin::Pin, sync::Arc, time};
/// How long proposal can take before we give up and err out
......@@ -50,13 +51,14 @@ impl<TxPool, Backend, Client> ProposerFactory<TxPool, Backend, Client> {
client: Arc<Client>,
transaction_pool: Arc<TxPool>,
overseer: OverseerHandler,
prometheus: Option<&PrometheusRegistry>,
) -> Self {
ProposerFactory {
inner: sc_basic_authorship::ProposerFactory::new(
spawn_handle,
client,
transaction_pool,
None,
prometheus,
),
overseer,
}
......
......@@ -460,6 +460,7 @@ pub fn new_full<RuntimeApi, Executor>(
client.clone(),
transaction_pool,
overseer_handler.clone(),
prometheus_registry.as_ref(),
);
let babe_config = babe::BabeParams {
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment