Unverified Commit 54b773ee authored by Andronik Ordian's avatar Andronik Ordian Committed by GitHub
Browse files

approval-distribution: add an assertion (#2761)

parent c8e11982
Pipeline #131783 failed with stages
in 29 minutes and 55 seconds
...@@ -848,12 +848,19 @@ impl State { ...@@ -848,12 +848,19 @@ impl State {
(ApprovalState::Approved(cert, vote.signature.clone()), local_source), (ApprovalState::Approved(cert, vote.signature.clone()), local_source),
); );
} }
_ => { Some((ApprovalState::Approved(..), _)) => {
unreachable!(
"we only insert it after the fingerprint, checked the fingerprint above; qed"
);
}
None => {
// this would indicate a bug in approval-voting
tracing::warn!( tracing::warn!(
target: LOG_TARGET, target: LOG_TARGET,
hash = ?block_hash, hash = ?block_hash,
?candidate_index, ?candidate_index,
"Expected a candidate entry with `ApprovalState::Assigned`", ?validator_index,
"Importing an approval we don't have an assignment for",
); );
} }
} }
...@@ -863,6 +870,7 @@ impl State { ...@@ -863,6 +870,7 @@ impl State {
target: LOG_TARGET, target: LOG_TARGET,
hash = ?block_hash, hash = ?block_hash,
?candidate_index, ?candidate_index,
?validator_index,
"Expected a candidate entry on import_and_circulate_approval", "Expected a candidate entry on import_and_circulate_approval",
); );
} }
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment