lib.rs 26 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
// Copyright 2020 Parity Technologies (UK) Ltd.
// This file is part of Polkadot.

// Polkadot is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.

// Polkadot is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
// GNU General Public License for more details.

// You should have received a copy of the GNU General Public License
// along with Polkadot.  If not, see <http://www.gnu.org/licenses/>.

//! The Candidate Validation subsystem.
//!
//! This handles incoming requests from other subsystems to validate candidates
//! according to a validation function. This delegates validation to an underlying
//! pool of processes used for execution of the Wasm.

23
24
25
#![deny(unused_crate_dependencies, unused_results)]
#![warn(missing_docs)]

26
use polkadot_subsystem::{
27
	Subsystem, SubsystemContext, SpawnedSubsystem, SubsystemResult, SubsystemError,
28
	FromOverseer, OverseerSignal,
29
30
31
32
	messages::{
		AllMessages, CandidateValidationMessage, RuntimeApiMessage,
		ValidationFailed, RuntimeApiRequest,
	},
33
34
};
use polkadot_node_subsystem_util::{
35
	metrics::{self, prometheus},
36
};
Andronik Ordian's avatar
Andronik Ordian committed
37
use polkadot_subsystem::errors::RuntimeApiError;
38
use polkadot_node_primitives::{ValidationResult, InvalidCandidate};
39
use polkadot_primitives::v1::{
40
41
	ValidationCode, PoV, CandidateDescriptor, PersistedValidationData,
	OccupiedCoreAssumption, Hash, ValidationOutputs,
42
};
43
44
use polkadot_parachain::wasm_executor::{
	self, ValidationPool, ExecutionMode, ValidationError,
45
	InvalidCandidate as WasmInvalidCandidate,
46
};
47
48
49
50
51
52
53
54
55
56
use polkadot_parachain::primitives::{ValidationResult as WasmValidationResult, ValidationParams};

use parity_scale_codec::Encode;
use sp_core::traits::SpawnNamed;

use futures::channel::oneshot;
use futures::prelude::*;

use std::sync::Arc;

57
58
const LOG_TARGET: &'static str = "candidate_validation";

59
/// The candidate validation subsystem.
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
pub struct CandidateValidationSubsystem<S> {
	spawn: S,
	metrics: Metrics,
}

#[derive(Clone)]
struct MetricsInner {
	validation_requests: prometheus::CounterVec<prometheus::U64>,
}

/// Candidate validation metrics.
#[derive(Default, Clone)]
pub struct Metrics(Option<MetricsInner>);

impl Metrics {
	fn on_validation_event(&self, event: &Result<ValidationResult, ValidationFailed>) {
		if let Some(metrics) = &self.0 {
			match event {
78
				Ok(ValidationResult::Valid(_, _)) => {
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
					metrics.validation_requests.with_label_values(&["valid"]).inc();
				},
				Ok(ValidationResult::Invalid(_)) => {
					metrics.validation_requests.with_label_values(&["invalid"]).inc();
				},
				Err(_) => {
					metrics.validation_requests.with_label_values(&["failed"]).inc();
				},
			}
		}
	}
}

impl metrics::Metrics for Metrics {
	fn try_register(registry: &prometheus::Registry) -> Result<Self, prometheus::PrometheusError> {
		let metrics = MetricsInner {
			validation_requests: prometheus::register(
				prometheus::CounterVec::new(
					prometheus::Opts::new(
						"parachain_validation_requests_total",
						"Number of validation requests served.",
					),
					&["valid", "invalid", "failed"],
				)?,
				registry,
			)?,
		};
		Ok(Metrics(Some(metrics)))
	}
}
109
110
111

impl<S> CandidateValidationSubsystem<S> {
	/// Create a new `CandidateValidationSubsystem` with the given task spawner.
112
113
	pub fn new(spawn: S, metrics: Metrics) -> Self {
		CandidateValidationSubsystem { spawn, metrics }
114
115
116
117
118
119
120
121
	}
}

impl<S, C> Subsystem<C> for CandidateValidationSubsystem<S> where
	C: SubsystemContext<Message = CandidateValidationMessage>,
	S: SpawnNamed + Clone + 'static,
{
	fn start(self, ctx: C) -> SpawnedSubsystem {
122
123
124
125
		let future = run(ctx, self.spawn, self.metrics)
			.map_err(|e| SubsystemError::with_origin("candidate-validation", e))
			.map(|_| ())
			.boxed();
126
127
		SpawnedSubsystem {
			name: "candidate-validation-subsystem",
128
			future,
129
130
131
132
133
134
135
		}
	}
}

async fn run(
	mut ctx: impl SubsystemContext<Message = CandidateValidationMessage>,
	spawn: impl SpawnNamed + Clone + 'static,
136
	metrics: Metrics,
137
138
139
)
	-> SubsystemResult<()>
{
140
	let execution_mode = ExecutionMode::ExternalProcessSelfHost(ValidationPool::new());
141
142
143
144
145
146
147
148
149
150
151
152
153
154

	loop {
		match ctx.recv().await? {
			FromOverseer::Signal(OverseerSignal::ActiveLeaves(_)) => {}
			FromOverseer::Signal(OverseerSignal::BlockFinalized(_)) => {}
			FromOverseer::Signal(OverseerSignal::Conclude) => return Ok(()),
			FromOverseer::Communication { msg } => match msg {
				CandidateValidationMessage::ValidateFromChainState(
					descriptor,
					pov,
					response_sender,
				) => {
					let res = spawn_validate_from_chain_state(
						&mut ctx,
155
						execution_mode.clone(),
156
157
158
159
160
161
						descriptor,
						pov,
						spawn.clone(),
					).await;

					match res {
162
163
164
165
166
						Ok(x) => {
							metrics.on_validation_event(&x);
							let _ = response_sender.send(x);
						}
						Err(e) => return Err(e),
167
168
169
					}
				}
				CandidateValidationMessage::ValidateFromExhaustive(
170
					persisted_validation_data,
171
172
173
174
175
176
177
					validation_code,
					descriptor,
					pov,
					response_sender,
				) => {
					let res = spawn_validate_exhaustive(
						&mut ctx,
178
						execution_mode.clone(),
179
						persisted_validation_data,
180
181
182
183
184
185
186
						validation_code,
						descriptor,
						pov,
						spawn.clone(),
					).await;

					match res {
187
188
189
190
191
192
193
194
						Ok(x) => {
							metrics.on_validation_event(&x);
							if let Err(_e) = response_sender.send(x) {
								log::warn!(
									target: LOG_TARGET,
									"Requester of candidate validation dropped",
								)
							}
195
						},
196
						Err(e) => return Err(e),
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
					}
				}
			}
		}
	}
}

async fn runtime_api_request<T>(
	ctx: &mut impl SubsystemContext<Message = CandidateValidationMessage>,
	relay_parent: Hash,
	request: RuntimeApiRequest,
	receiver: oneshot::Receiver<Result<T, RuntimeApiError>>,
) -> SubsystemResult<Result<T, RuntimeApiError>> {
	ctx.send_message(
		AllMessages::RuntimeApi(RuntimeApiMessage::Request(
			relay_parent,
			request,
		))
	).await?;

	receiver.await.map_err(Into::into)
}

#[derive(Debug)]
enum AssumptionCheckOutcome {
222
	Matches(PersistedValidationData, ValidationCode),
223
224
225
226
227
228
229
230
231
	DoesNotMatch,
	BadRequest,
}

async fn check_assumption_validation_data(
	ctx: &mut impl SubsystemContext<Message = CandidateValidationMessage>,
	descriptor: &CandidateDescriptor,
	assumption: OccupiedCoreAssumption,
) -> SubsystemResult<AssumptionCheckOutcome> {
232
	let validation_data = {
233
234
235
236
		let (tx, rx) = oneshot::channel();
		let d = runtime_api_request(
			ctx,
			descriptor.relay_parent,
237
			RuntimeApiRequest::PersistedValidationData(
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
				descriptor.para_id,
				assumption,
				tx,
			),
			rx,
		).await?;

		match d {
			Ok(None) | Err(_) => {
				return Ok(AssumptionCheckOutcome::BadRequest);
			}
			Ok(Some(d)) => d,
		}
	};

253
	let persisted_validation_data_hash = validation_data.hash();
254

255
	SubsystemResult::Ok(if descriptor.persisted_validation_data_hash == persisted_validation_data_hash {
256
257
258
259
260
261
262
263
264
265
266
267
268
269
		let (code_tx, code_rx) = oneshot::channel();
		let validation_code = runtime_api_request(
			ctx,
			descriptor.relay_parent,
			RuntimeApiRequest::ValidationCode(
				descriptor.para_id,
				OccupiedCoreAssumption::Included,
				code_tx,
			),
			code_rx,
		).await?;

		match validation_code {
			Ok(None) | Err(_) => AssumptionCheckOutcome::BadRequest,
270
			Ok(Some(v)) => AssumptionCheckOutcome::Matches(validation_data, v),
271
272
273
274
275
276
		}
	} else {
		AssumptionCheckOutcome::DoesNotMatch
	})
}

277
async fn find_assumed_validation_data(
278
	ctx: &mut impl SubsystemContext<Message = CandidateValidationMessage>,
279
280
	descriptor: &CandidateDescriptor,
) -> SubsystemResult<AssumptionCheckOutcome> {
281
	// The candidate descriptor has a `persisted_validation_data_hash` which corresponds to
282
	// one of up to two possible values that we can derive from the state of the
283
284
	// relay-parent. We can fetch these values by getting the persisted validation data
	// based on the different `OccupiedCoreAssumption`s.
285
286

	const ASSUMPTIONS: &[OccupiedCoreAssumption] = &[
287
		OccupiedCoreAssumption::Included,
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
		OccupiedCoreAssumption::TimedOut,
		// TODO: Why don't we check `Free`? The guide assumes there are only two possible assumptions.
		//
		// Source that info and leave a comment here.
	];

	// Consider running these checks in parallel to reduce validation latency.
	for assumption in ASSUMPTIONS {
		let outcome = check_assumption_validation_data(ctx, descriptor, *assumption).await?;

		let () = match outcome {
			AssumptionCheckOutcome::Matches(_, _) => return Ok(outcome),
			AssumptionCheckOutcome::BadRequest => return Ok(outcome),
			AssumptionCheckOutcome::DoesNotMatch => continue,
		};
303
304
	}

305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
	Ok(AssumptionCheckOutcome::DoesNotMatch)
}

async fn spawn_validate_from_chain_state(
	ctx: &mut impl SubsystemContext<Message = CandidateValidationMessage>,
	execution_mode: ExecutionMode,
	descriptor: CandidateDescriptor,
	pov: Arc<PoV>,
	spawn: impl SpawnNamed + 'static,
) -> SubsystemResult<Result<ValidationResult, ValidationFailed>> {
	let (validation_data, validation_code) =
		match find_assumed_validation_data(ctx, &descriptor).await? {
			AssumptionCheckOutcome::Matches(validation_data, validation_code) => {
				(validation_data, validation_code)
			}
			AssumptionCheckOutcome::DoesNotMatch => {
				// If neither the assumption of the occupied core having the para included or the assumption
				// of the occupied core timing out are valid, then the persisted_validation_data_hash in the descriptor
				// is not based on the relay parent and is thus invalid.
				return Ok(Ok(ValidationResult::Invalid(InvalidCandidate::BadParent)));
			}
			AssumptionCheckOutcome::BadRequest => {
				return Ok(Err(ValidationFailed("Assumption Check: Bad request".into())));
			}
		};

	let validation_result = spawn_validate_exhaustive(
332
		ctx,
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
		execution_mode,
		validation_data,
		validation_code,
		descriptor.clone(),
		pov,
		spawn,
	)
	.await;

	if let Ok(Ok(ValidationResult::Valid(ref outputs, _))) = validation_result {
		let (tx, rx) = oneshot::channel();
		match runtime_api_request(
			ctx,
			descriptor.relay_parent,
			RuntimeApiRequest::CheckValidationOutputs(descriptor.para_id, outputs.clone(), tx),
			rx,
		)
		.await?
		{
			Ok(true) => {}
			Ok(false) => {
				return Ok(Ok(ValidationResult::Invalid(
					InvalidCandidate::InvalidOutputs,
				)));
			}
			Err(_) => {
				return Ok(Err(ValidationFailed("Check Validation Outputs: Bad request".into())));
			}
361
362
363
		}
	}

364
	validation_result
365
366
367
368
}

async fn spawn_validate_exhaustive(
	ctx: &mut impl SubsystemContext<Message = CandidateValidationMessage>,
369
	execution_mode: ExecutionMode,
370
	persisted_validation_data: PersistedValidationData,
371
372
373
374
375
376
377
378
	validation_code: ValidationCode,
	descriptor: CandidateDescriptor,
	pov: Arc<PoV>,
	spawn: impl SpawnNamed + 'static,
) -> SubsystemResult<Result<ValidationResult, ValidationFailed>> {
	let (tx, rx) = oneshot::channel();
	let fut = async move {
		let res = validate_candidate_exhaustive::<RealValidationBackend, _>(
379
			execution_mode,
380
			persisted_validation_data,
381
382
383
384
385
386
387
388
389
			validation_code,
			descriptor,
			pov,
			spawn,
		);

		let _ = tx.send(res);
	};

390
	ctx.spawn_blocking("blocking-candidate-validation-task", fut.boxed()).await?;
391
392
393
	rx.await.map_err(Into::into)
}

394
395
396
/// Does basic checks of a candidate. Provide the encoded PoV-block. Returns `Ok` if basic checks
/// are passed, `Err` otherwise.
fn perform_basic_checks(
397
398
399
	candidate: &CandidateDescriptor,
	max_block_data_size: Option<u64>,
	pov: &PoV,
400
) -> Result<(), InvalidCandidate> {
401
402
403
404
405
	let encoded_pov = pov.encode();
	let hash = pov.hash();

	if let Some(max_size) = max_block_data_size {
		if encoded_pov.len() as u64 > max_size {
406
			return Err(InvalidCandidate::ParamsTooLarge(encoded_pov.len() as u64));
407
408
409
410
		}
	}

	if hash != candidate.pov_hash {
411
		return Err(InvalidCandidate::HashMismatch);
412
413
414
	}

	if let Err(()) = candidate.check_collator_signature() {
415
		return Err(InvalidCandidate::BadSignature);
416
417
	}

418
	Ok(())
419
420
421
422
423
424
425
426
427
428
}

trait ValidationBackend {
	type Arg;

	fn validate<S: SpawnNamed + 'static>(
		arg: Self::Arg,
		validation_code: &ValidationCode,
		params: ValidationParams,
		spawn: S,
429
	) -> Result<WasmValidationResult, ValidationError>;
430
431
432
433
434
}

struct RealValidationBackend;

impl ValidationBackend for RealValidationBackend {
435
	type Arg = ExecutionMode;
436
437

	fn validate<S: SpawnNamed + 'static>(
438
		execution_mode: ExecutionMode,
439
440
441
		validation_code: &ValidationCode,
		params: ValidationParams,
		spawn: S,
442
	) -> Result<WasmValidationResult, ValidationError> {
443
444
445
		wasm_executor::validate_candidate(
			&validation_code.0,
			params,
446
			&execution_mode,
447
448
449
450
451
452
453
454
455
456
			spawn,
		)
	}
}

/// Validates the candidate from exhaustive parameters.
///
/// Sends the result of validation on the channel once complete.
fn validate_candidate_exhaustive<B: ValidationBackend, S: SpawnNamed + 'static>(
	backend_arg: B::Arg,
457
	persisted_validation_data: PersistedValidationData,
458
459
460
461
462
	validation_code: ValidationCode,
	descriptor: CandidateDescriptor,
	pov: Arc<PoV>,
	spawn: S,
) -> Result<ValidationResult, ValidationFailed> {
463
464
	if let Err(e) = perform_basic_checks(&descriptor, None, &*pov) {
		return Ok(ValidationResult::Invalid(e))
465
466
467
	}

	let params = ValidationParams {
468
		parent_head: persisted_validation_data.parent_head.clone(),
469
		block_data: pov.block_data.clone(),
470
471
		relay_chain_height: persisted_validation_data.block_number,
		hrmp_mqc_heads: persisted_validation_data.hrmp_mqc_heads.clone(),
472
473
474
	};

	match B::validate(backend_arg, &validation_code, params, spawn) {
475
476
477
478
479
480
481
482
483
484
485
486
487
		Err(ValidationError::InvalidCandidate(WasmInvalidCandidate::Timeout)) =>
			Ok(ValidationResult::Invalid(InvalidCandidate::Timeout)),
		Err(ValidationError::InvalidCandidate(WasmInvalidCandidate::ParamsTooLarge(l))) =>
			Ok(ValidationResult::Invalid(InvalidCandidate::ParamsTooLarge(l as u64))),
		Err(ValidationError::InvalidCandidate(WasmInvalidCandidate::CodeTooLarge(l))) =>
			Ok(ValidationResult::Invalid(InvalidCandidate::CodeTooLarge(l as u64))),
		Err(ValidationError::InvalidCandidate(WasmInvalidCandidate::BadReturn)) =>
			Ok(ValidationResult::Invalid(InvalidCandidate::BadReturn)),
		Err(ValidationError::InvalidCandidate(WasmInvalidCandidate::WasmExecutor(e))) =>
			Ok(ValidationResult::Invalid(InvalidCandidate::ExecutionError(e.to_string()))),
		Err(ValidationError::InvalidCandidate(WasmInvalidCandidate::ExternalWasmExecutor(e))) =>
			Ok(ValidationResult::Invalid(InvalidCandidate::ExecutionError(e.to_string()))),
		Err(ValidationError::Internal(e)) => Err(ValidationFailed(e.to_string())),
488
		Ok(res) => {
489
490
491
492
493
			let outputs = ValidationOutputs {
				head_data: res.head_data,
				upward_messages: res.upward_messages,
				fees: 0,
				new_validation_code: res.new_validation_code,
494
			};
495
			Ok(ValidationResult::Valid(outputs, persisted_validation_data))
496
497
498
499
500
501
502
		}
	}
}

#[cfg(test)]
mod tests {
	use super::*;
503
	use polkadot_node_subsystem_test_helpers as test_helpers;
504
505
506
507
508
509
510
511
512
	use polkadot_primitives::v1::{HeadData, BlockData};
	use sp_core::testing::TaskExecutor;
	use futures::executor;
	use assert_matches::assert_matches;
	use sp_keyring::Sr25519Keyring;

	struct MockValidationBackend;

	struct MockValidationArg {
513
		result: Result<WasmValidationResult, ValidationError>,
514
515
516
517
518
519
520
521
522
523
	}

	impl ValidationBackend for MockValidationBackend {
		type Arg = MockValidationArg;

		fn validate<S: SpawnNamed + 'static>(
			arg: Self::Arg,
			_validation_code: &ValidationCode,
			_params: ValidationParams,
			_spawn: S,
524
		) -> Result<WasmValidationResult, ValidationError> {
525
526
527
528
529
530
531
532
533
			arg.result
		}
	}

	fn collator_sign(descriptor: &mut CandidateDescriptor, collator: Sr25519Keyring) {
		descriptor.collator = collator.public().into();
		let payload = polkadot_primitives::v1::collator_signature_payload(
			&descriptor.relay_parent,
			&descriptor.para_id,
534
			&descriptor.persisted_validation_data_hash,
535
536
537
538
539
540
541
542
543
			&descriptor.pov_hash,
		);

		descriptor.signature = collator.sign(&payload[..]).into();
		assert!(descriptor.check_collator_signature().is_ok());
	}

	#[test]
	fn correctly_checks_included_assumption() {
544
		let validation_data: PersistedValidationData = Default::default();
545
546
		let validation_code: ValidationCode = vec![1, 2, 3].into();

547
		let persisted_validation_data_hash = validation_data.hash();
548
549
550
551
552
		let relay_parent = [2; 32].into();
		let para_id = 5.into();

		let mut candidate = CandidateDescriptor::default();
		candidate.relay_parent = relay_parent;
553
		candidate.persisted_validation_data_hash = persisted_validation_data_hash;
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
		candidate.para_id = para_id;

		let pool = TaskExecutor::new();
		let (mut ctx, mut ctx_handle) = test_helpers::make_subsystem_context(pool.clone());

		let (check_fut, check_result) = check_assumption_validation_data(
			&mut ctx,
			&candidate,
			OccupiedCoreAssumption::Included,
		).remote_handle();

		let test_fut = async move {
			assert_matches!(
				ctx_handle.recv().await,
				AllMessages::RuntimeApi(RuntimeApiMessage::Request(
					rp,
570
571
572
573
574
					RuntimeApiRequest::PersistedValidationData(
						p,
						OccupiedCoreAssumption::Included,
						tx
					),
575
576
577
578
				)) => {
					assert_eq!(rp, relay_parent);
					assert_eq!(p, para_id);

579
					let _ = tx.send(Ok(Some(validation_data.clone())));
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
				}
			);

			assert_matches!(
				ctx_handle.recv().await,
				AllMessages::RuntimeApi(RuntimeApiMessage::Request(
					rp,
					RuntimeApiRequest::ValidationCode(p, OccupiedCoreAssumption::Included, tx)
				)) => {
					assert_eq!(rp, relay_parent);
					assert_eq!(p, para_id);

					let _ = tx.send(Ok(Some(validation_code.clone())));
				}
			);

			assert_matches!(check_result.await.unwrap(), AssumptionCheckOutcome::Matches(o, v) => {
597
				assert_eq!(o, validation_data);
598
599
600
601
602
603
604
605
606
607
				assert_eq!(v, validation_code);
			});
		};

		let test_fut = future::join(test_fut, check_fut);
		executor::block_on(test_fut);
	}

	#[test]
	fn correctly_checks_timed_out_assumption() {
608
		let validation_data: PersistedValidationData = Default::default();
609
610
		let validation_code: ValidationCode = vec![1, 2, 3].into();

611
		let persisted_validation_data_hash = validation_data.hash();
612
613
614
615
616
		let relay_parent = [2; 32].into();
		let para_id = 5.into();

		let mut candidate = CandidateDescriptor::default();
		candidate.relay_parent = relay_parent;
617
		candidate.persisted_validation_data_hash = persisted_validation_data_hash;
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
		candidate.para_id = para_id;

		let pool = TaskExecutor::new();
		let (mut ctx, mut ctx_handle) = test_helpers::make_subsystem_context(pool.clone());

		let (check_fut, check_result) = check_assumption_validation_data(
			&mut ctx,
			&candidate,
			OccupiedCoreAssumption::TimedOut,
		).remote_handle();

		let test_fut = async move {
			assert_matches!(
				ctx_handle.recv().await,
				AllMessages::RuntimeApi(RuntimeApiMessage::Request(
					rp,
634
635
636
637
638
					RuntimeApiRequest::PersistedValidationData(
						p,
						OccupiedCoreAssumption::TimedOut,
						tx
					),
639
640
641
642
				)) => {
					assert_eq!(rp, relay_parent);
					assert_eq!(p, para_id);

643
					let _ = tx.send(Ok(Some(validation_data.clone())));
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
				}
			);

			assert_matches!(
				ctx_handle.recv().await,
				AllMessages::RuntimeApi(RuntimeApiMessage::Request(
					rp,
					RuntimeApiRequest::ValidationCode(p, OccupiedCoreAssumption::Included, tx)
				)) => {
					assert_eq!(rp, relay_parent);
					assert_eq!(p, para_id);

					let _ = tx.send(Ok(Some(validation_code.clone())));
				}
			);

			assert_matches!(check_result.await.unwrap(), AssumptionCheckOutcome::Matches(o, v) => {
661
				assert_eq!(o, validation_data);
662
663
664
665
666
667
668
669
670
671
				assert_eq!(v, validation_code);
			});
		};

		let test_fut = future::join(test_fut, check_fut);
		executor::block_on(test_fut);
	}

	#[test]
	fn check_is_bad_request_if_no_validation_data() {
672
673
		let validation_data: PersistedValidationData = Default::default();
		let persisted_validation_data_hash = validation_data.hash();
674
675
676
677
678
		let relay_parent = [2; 32].into();
		let para_id = 5.into();

		let mut candidate = CandidateDescriptor::default();
		candidate.relay_parent = relay_parent;
679
		candidate.persisted_validation_data_hash = persisted_validation_data_hash;
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
		candidate.para_id = para_id;

		let pool = TaskExecutor::new();
		let (mut ctx, mut ctx_handle) = test_helpers::make_subsystem_context(pool.clone());

		let (check_fut, check_result) = check_assumption_validation_data(
			&mut ctx,
			&candidate,
			OccupiedCoreAssumption::Included,
		).remote_handle();

		let test_fut = async move {
			assert_matches!(
				ctx_handle.recv().await,
				AllMessages::RuntimeApi(RuntimeApiMessage::Request(
					rp,
696
697
698
699
700
					RuntimeApiRequest::PersistedValidationData(
						p,
						OccupiedCoreAssumption::Included,
						tx
					),
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
				)) => {
					assert_eq!(rp, relay_parent);
					assert_eq!(p, para_id);

					let _ = tx.send(Ok(None));
				}
			);

			assert_matches!(check_result.await.unwrap(), AssumptionCheckOutcome::BadRequest);
		};

		let test_fut = future::join(test_fut, check_fut);
		executor::block_on(test_fut);
	}

	#[test]
	fn check_is_bad_request_if_no_validation_code() {
718
719
		let validation_data: PersistedValidationData = Default::default();
		let persisted_validation_data_hash = validation_data.hash();
720
721
722
723
724
		let relay_parent = [2; 32].into();
		let para_id = 5.into();

		let mut candidate = CandidateDescriptor::default();
		candidate.relay_parent = relay_parent;
725
		candidate.persisted_validation_data_hash = persisted_validation_data_hash;
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
		candidate.para_id = para_id;

		let pool = TaskExecutor::new();
		let (mut ctx, mut ctx_handle) = test_helpers::make_subsystem_context(pool.clone());

		let (check_fut, check_result) = check_assumption_validation_data(
			&mut ctx,
			&candidate,
			OccupiedCoreAssumption::TimedOut,
		).remote_handle();

		let test_fut = async move {
			assert_matches!(
				ctx_handle.recv().await,
				AllMessages::RuntimeApi(RuntimeApiMessage::Request(
					rp,
742
743
744
745
746
					RuntimeApiRequest::PersistedValidationData(
						p,
						OccupiedCoreAssumption::TimedOut,
						tx
					),
747
748
749
750
				)) => {
					assert_eq!(rp, relay_parent);
					assert_eq!(p, para_id);

751
					let _ = tx.send(Ok(Some(validation_data.clone())));
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
				}
			);

			assert_matches!(
				ctx_handle.recv().await,
				AllMessages::RuntimeApi(RuntimeApiMessage::Request(
					rp,
					RuntimeApiRequest::ValidationCode(p, OccupiedCoreAssumption::Included, tx)
				)) => {
					assert_eq!(rp, relay_parent);
					assert_eq!(p, para_id);

					let _ = tx.send(Ok(None));
				}
			);

			assert_matches!(check_result.await.unwrap(), AssumptionCheckOutcome::BadRequest);
		};

		let test_fut = future::join(test_fut, check_fut);
		executor::block_on(test_fut);
	}

	#[test]
	fn check_does_not_match() {
777
		let validation_data: PersistedValidationData = Default::default();
778
779
780
781
782
		let relay_parent = [2; 32].into();
		let para_id = 5.into();

		let mut candidate = CandidateDescriptor::default();
		candidate.relay_parent = relay_parent;
783
		candidate.persisted_validation_data_hash = [3; 32].into();
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
		candidate.para_id = para_id;

		let pool = TaskExecutor::new();
		let (mut ctx, mut ctx_handle) = test_helpers::make_subsystem_context(pool.clone());

		let (check_fut, check_result) = check_assumption_validation_data(
			&mut ctx,
			&candidate,
			OccupiedCoreAssumption::Included,
		).remote_handle();

		let test_fut = async move {
			assert_matches!(
				ctx_handle.recv().await,
				AllMessages::RuntimeApi(RuntimeApiMessage::Request(
					rp,
800
801
802
803
804
					RuntimeApiRequest::PersistedValidationData(
						p,
						OccupiedCoreAssumption::Included,
						tx
					),
805
806
807
808
				)) => {
					assert_eq!(rp, relay_parent);
					assert_eq!(p, para_id);

809
					let _ = tx.send(Ok(Some(validation_data.clone())));
810
811
812
813
814
815
816
817
818
819
820
821
				}
			);

			assert_matches!(check_result.await.unwrap(), AssumptionCheckOutcome::DoesNotMatch);
		};

		let test_fut = future::join(test_fut, check_fut);
		executor::block_on(test_fut);
	}

	#[test]
	fn candidate_validation_ok_is_ok() {
822
		let validation_data: PersistedValidationData = Default::default();
823
824
825
826
827
828
829

		let pov = PoV { block_data: BlockData(vec![1; 32]) };

		let mut descriptor = CandidateDescriptor::default();
		descriptor.pov_hash = pov.hash();
		collator_sign(&mut descriptor, Sr25519Keyring::Alice);

830
		assert!(perform_basic_checks(&descriptor, Some(1024), &pov).is_ok());
831
832
833
834
835
836
837
838
839
840

		let validation_result = WasmValidationResult {
			head_data: HeadData(vec![1, 1, 1]),
			new_validation_code: Some(vec![2, 2, 2].into()),
			upward_messages: Vec::new(),
			processed_downward_messages: 0,
		};

		let v = validate_candidate_exhaustive::<MockValidationBackend, _>(
			MockValidationArg { result: Ok(validation_result) },
841
			validation_data.clone(),
842
843
844
845
846
847
			vec![1, 2, 3].into(),
			descriptor,
			Arc::new(pov),
			TaskExecutor::new(),
		).unwrap();

848
		assert_matches!(v, ValidationResult::Valid(outputs, used_validation_data) => {
849
850
851
852
			assert_eq!(outputs.head_data, HeadData(vec![1, 1, 1]));
			assert_eq!(outputs.upward_messages, Vec::new());
			assert_eq!(outputs.fees, 0);
			assert_eq!(outputs.new_validation_code, Some(vec![2, 2, 2].into()));
853
			assert_eq!(used_validation_data, validation_data);
854
855
856
857
858
		});
	}

	#[test]
	fn candidate_validation_bad_return_is_invalid() {
859
		let validation_data: PersistedValidationData = Default::default();
860
861
862
863
864
865
866

		let pov = PoV { block_data: BlockData(vec![1; 32]) };

		let mut descriptor = CandidateDescriptor::default();
		descriptor.pov_hash = pov.hash();
		collator_sign(&mut descriptor, Sr25519Keyring::Alice);

867
		assert!(perform_basic_checks(&descriptor, Some(1024), &pov).is_ok());
868
869

		let v = validate_candidate_exhaustive::<MockValidationBackend, _>(
870
871
872
873
874
			MockValidationArg {
				result: Err(ValidationError::InvalidCandidate(
					WasmInvalidCandidate::BadReturn
				))
			},
875
			validation_data,
876
877
878
879
880
881
			vec![1, 2, 3].into(),
			descriptor,
			Arc::new(pov),
			TaskExecutor::new(),
		).unwrap();

882
		assert_matches!(v, ValidationResult::Invalid(InvalidCandidate::BadReturn));
883
884
885
886
	}

	#[test]
	fn candidate_validation_timeout_is_internal_error() {
887
		let validation_data: PersistedValidationData = Default::default();
888
889
890
891
892
893
894

		let pov = PoV { block_data: BlockData(vec![1; 32]) };

		let mut descriptor = CandidateDescriptor::default();
		descriptor.pov_hash = pov.hash();
		collator_sign(&mut descriptor, Sr25519Keyring::Alice);

895
		assert!(perform_basic_checks(&descriptor, Some(1024), &pov).is_ok());
896
897

		let v = validate_candidate_exhaustive::<MockValidationBackend, _>(
898
899
900
901
902
			MockValidationArg {
				result: Err(ValidationError::InvalidCandidate(
					WasmInvalidCandidate::Timeout
				))
			},
903
			validation_data,
904
905
906
907
908
909
			vec![1, 2, 3].into(),
			descriptor,
			Arc::new(pov),
			TaskExecutor::new(),
		);

910
		assert_matches!(v, Ok(ValidationResult::Invalid(InvalidCandidate::Timeout)));
911
912
	}
}