lib.rs 20.9 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
// Copyright 2020 Parity Technologies (UK) Ltd.
// This file is part of Polkadot.

// Polkadot is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.

// Polkadot is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
// GNU General Public License for more details.

// You should have received a copy of the GNU General Public License
// along with Polkadot.  If not, see <http://www.gnu.org/licenses/>.

//! The collation generation subsystem is the interface between polkadot and the collators.

#![deny(missing_docs)]

use futures::{
22
	channel::mpsc,
23
24
25
26
27
28
29
30
31
	future::FutureExt,
	join,
	select,
	sink::SinkExt,
	stream::StreamExt,
};
use polkadot_node_primitives::CollationGenerationConfig;
use polkadot_node_subsystem::{
	messages::{AllMessages, CollationGenerationMessage, CollatorProtocolMessage},
32
	FromOverseer, SpawnedSubsystem, Subsystem, SubsystemContext, SubsystemResult,
33
34
};
use polkadot_node_subsystem_util::{
35
	request_availability_cores_ctx, request_full_validation_data_ctx,
36
	request_validators_ctx,
37
	metrics::{self, prometheus},
38
39
};
use polkadot_primitives::v1::{
40
41
42
	collator_signature_payload, AvailableData, CandidateCommitments,
	CandidateDescriptor, CandidateReceipt, CoreState, Hash, OccupiedCoreAssumption,
	PersistedValidationData, PoV,
43
44
45
46
};
use sp_core::crypto::Pair;
use std::sync::Arc;

47
48
49
50
mod error;

const LOG_TARGET: &'static str = "collation_generation";

51
52
53
/// Collation Generation Subsystem
pub struct CollationGenerationSubsystem {
	config: Option<Arc<CollationGenerationConfig>>,
54
	metrics: Metrics,
55
56
57
}

impl CollationGenerationSubsystem {
58
59
60
61
62
63
64
65
	/// Create a new instance of the `CollationGenerationSubsystem`.
	pub fn new(metrics: Metrics) -> Self {
		Self {
			config: None,
			metrics,
		}
	}

66
67
68
69
70
71
72
73
74
75
76
	/// Run this subsystem
	///
	/// Conceptually, this is very simple: it just loops forever.
	///
	/// - On incoming overseer messages, it starts or stops jobs as appropriate.
	/// - On other incoming messages, if they can be converted into Job::ToJob and
	///   include a hash, then they're forwarded to the appropriate individual job.
	/// - On outgoing messages from the jobs, it forwards them to the overseer.
	///
	/// If `err_tx` is not `None`, errors are forwarded onto that channel as they occur.
	/// Otherwise, most are logged and then discarded.
77
	#[tracing::instrument(skip(self, ctx), fields(subsystem = LOG_TARGET))]
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
	async fn run<Context>(mut self, mut ctx: Context)
	where
		Context: SubsystemContext<Message = CollationGenerationMessage>,
	{
		// when we activate new leaves, we spawn a bunch of sub-tasks, each of which is
		// expected to generate precisely one message. We don't want to block the main loop
		// at any point waiting for them all, so instead, we create a channel on which they can
		// send those messages. We can then just monitor the channel and forward messages on it
		// to the overseer here, via the context.
		let (sender, mut receiver) = mpsc::channel(0);

		loop {
			select! {
				incoming = ctx.recv().fuse() => {
					if self.handle_incoming::<Context>(incoming, &mut ctx, &sender).await {
						break;
					}
				},
				msg = receiver.next().fuse() => {
					if let Some(msg) = msg {
						if let Err(err) = ctx.send_message(msg).await {
99
							tracing::warn!(target: LOG_TARGET, err = ?err, "failed to forward message to overseer");
100
101
102
103
104
105
106
107
108
109
110
111
							break;
						}
					}
				},
			}
		}
	}

	// handle an incoming message. return true if we should break afterwards.
	// note: this doesn't strictly need to be a separate function; it's more an administrative function
	// so that we don't clutter the run loop. It could in principle be inlined directly into there.
	// it should hopefully therefore be ok that it's an async function mutably borrowing self.
112
	#[tracing::instrument(level = "trace", skip(self, ctx, sender), fields(subsystem = LOG_TARGET))]
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
	async fn handle_incoming<Context>(
		&mut self,
		incoming: SubsystemResult<FromOverseer<Context::Message>>,
		ctx: &mut Context,
		sender: &mpsc::Sender<AllMessages>,
	) -> bool
	where
		Context: SubsystemContext<Message = CollationGenerationMessage>,
	{
		use polkadot_node_subsystem::ActiveLeavesUpdate;
		use polkadot_node_subsystem::FromOverseer::{Communication, Signal};
		use polkadot_node_subsystem::OverseerSignal::{ActiveLeaves, BlockFinalized, Conclude};

		match incoming {
			Ok(Signal(ActiveLeaves(ActiveLeavesUpdate { activated, .. }))) => {
				// follow the procedure from the guide
				if let Some(config) = &self.config {
130
					let metrics = self.metrics.clone();
131
					if let Err(err) =
132
						handle_new_activations(config.clone(), &activated, ctx, metrics, sender).await
133
					{
134
						tracing::warn!(target: LOG_TARGET, err = ?err, "failed to handle new activations");
135
136
137
138
139
140
141
142
143
					};
				}
				false
			}
			Ok(Signal(Conclude)) => true,
			Ok(Communication {
				msg: CollationGenerationMessage::Initialize(config),
			}) => {
				if self.config.is_some() {
144
					tracing::error!(target: LOG_TARGET, "double initialization");
145
146
147
				} else {
					self.config = Some(Arc::new(config));
				}
148
				false
149
150
151
			}
			Ok(Signal(BlockFinalized(_))) => false,
			Err(err) => {
152
				tracing::error!(
153
					target: LOG_TARGET,
154
					err = ?err,
155
156
157
					"error receiving message from subsystem context: {:?}",
					err
				);
158
159
160
161
162
163
164
165
166
167
				true
			}
		}
	}
}

impl<Context> Subsystem<Context> for CollationGenerationSubsystem
where
	Context: SubsystemContext<Message = CollationGenerationMessage>,
{
168
	fn start(self, ctx: Context) -> SpawnedSubsystem {
169
170
171
172
		let future = Box::pin(async move {
			self.run(ctx).await;
			Ok(())
		});
173
174

		SpawnedSubsystem {
175
			name: "collation-generation-subsystem",
176
177
178
179
180
			future,
		}
	}
}

181
#[tracing::instrument(level = "trace", skip(ctx, metrics, sender), fields(subsystem = LOG_TARGET))]
182
183
184
185
async fn handle_new_activations<Context: SubsystemContext>(
	config: Arc<CollationGenerationConfig>,
	activated: &[Hash],
	ctx: &mut Context,
186
	metrics: Metrics,
187
	sender: &mpsc::Sender<AllMessages>,
188
) -> crate::error::Result<()> {
189
190
191
192
193
194
	// follow the procedure from the guide:
	// https://w3f.github.io/parachain-implementers-guide/node/collators/collation-generation.html

	for relay_parent in activated.iter().copied() {
		// double-future magic happens here: the first layer of requests takes a mutable borrow of the context, and
		// returns a receiver. The second layer of requests actually polls those receivers to completion.
195
		let (availability_cores, validators) = join!(
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
			request_availability_cores_ctx(relay_parent, ctx).await?,
			request_validators_ctx(relay_parent, ctx).await?,
		);

		let availability_cores = availability_cores??;
		let n_validators = validators??.len();

		for core in availability_cores {
			let (scheduled_core, assumption) = match core {
				CoreState::Scheduled(scheduled_core) => {
					(scheduled_core, OccupiedCoreAssumption::Free)
				}
				CoreState::Occupied(_occupied_core) => {
					// TODO: https://github.com/paritytech/polkadot/issues/1573
					continue;
				}
				_ => continue,
			};

			if scheduled_core.para_id != config.para_id {
				continue;
			}

219
220
221
222
			// we get validation data synchronously for each core instead of
			// within the subtask loop, because we have only a single mutable handle to the
			// context, so the work can't really be distributed
			let validation_data = match request_full_validation_data_ctx(
223
224
225
226
227
228
229
230
				relay_parent,
				scheduled_core.para_id,
				assumption,
				ctx,
			)
			.await?
			.await??
			{
231
				Some(v) => v,
232
233
234
235
236
				None => continue,
			};

			let task_config = config.clone();
			let mut task_sender = sender.clone();
237
			let metrics = metrics.clone();
238
			ctx.spawn("collation generation collation builder", Box::pin(async move {
239
				let persisted_validation_data_hash = validation_data.persisted.hash();
240

241
				let collation = match (task_config.collator)(relay_parent, &validation_data).await {
242
243
					Some(collation) => collation,
					None => {
244
						tracing::debug!(
245
							target: LOG_TARGET,
246
247
							para_id = %scheduled_core.para_id,
							"collator returned no collation on collate",
248
249
250
251
						);
						return
					}
				};
252
253
254
255
256
257

				let pov_hash = collation.proof_of_validity.hash();

				let signature_payload = collator_signature_payload(
					&relay_parent,
					&scheduled_core.para_id,
258
					&persisted_validation_data_hash,
259
260
261
					&pov_hash,
				);

262
263
264
265
266
				let erasure_root = match erasure_root(
					n_validators,
					validation_data.persisted,
					collation.proof_of_validity.clone(),
				) {
267
268
					Ok(erasure_root) => erasure_root,
					Err(err) => {
269
						tracing::error!(
270
							target: LOG_TARGET,
271
272
273
							para_id = %scheduled_core.para_id,
							err = ?err,
							"failed to calculate erasure root",
274
						);
275
276
277
278
279
280
						return
					}
				};

				let commitments = CandidateCommitments {
					upward_messages: collation.upward_messages,
Sergey Pepyakin's avatar
Sergey Pepyakin committed
281
					horizontal_messages: collation.horizontal_messages,
282
283
284
					new_validation_code: collation.new_validation_code,
					head_data: collation.head_data,
					erasure_root,
285
					processed_downward_messages: collation.processed_downward_messages,
Sergey Pepyakin's avatar
Sergey Pepyakin committed
286
					hrmp_watermark: collation.hrmp_watermark,
287
288
289
290
291
292
293
294
295
				};

				let ccr = CandidateReceipt {
					commitments_hash: commitments.hash(),
					descriptor: CandidateDescriptor {
						signature: task_config.key.sign(&signature_payload),
						para_id: scheduled_core.para_id,
						relay_parent,
						collator: task_config.key.public(),
296
						persisted_validation_data_hash,
297
298
299
300
						pov_hash,
					},
				};

301
302
				metrics.on_collation_generated();

303
304
305
				if let Err(err) = task_sender.send(AllMessages::CollatorProtocol(
					CollatorProtocolMessage::DistributeCollation(ccr, collation.proof_of_validity)
				)).await {
306
					tracing::warn!(
307
						target: LOG_TARGET,
308
309
310
						para_id = %scheduled_core.para_id,
						err = ?err,
						"failed to send collation result",
311
					);
312
313
314
315
316
317
318
319
				}
			})).await?;
		}
	}

	Ok(())
}

320
#[tracing::instrument(level = "trace", fields(subsystem = LOG_TARGET))]
321
322
fn erasure_root(
	n_validators: usize,
323
	persisted_validation: PersistedValidationData,
324
	pov: PoV,
325
) -> crate::error::Result<Hash> {
326
	let available_data = AvailableData {
327
		validation_data: persisted_validation,
328
		pov: Arc::new(pov),
329
330
331
332
333
334
	};

	let chunks = polkadot_erasure_coding::obtain_chunks_v1(n_validators, &available_data)?;
	Ok(polkadot_erasure_coding::branches(&chunks).root())
}

335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
#[derive(Clone)]
struct MetricsInner {
	collations_generated_total: prometheus::Counter<prometheus::U64>,
}

/// CollationGenerationSubsystem metrics.
#[derive(Default, Clone)]
pub struct Metrics(Option<MetricsInner>);

impl Metrics {
	fn on_collation_generated(&self) {
		if let Some(metrics) = &self.0 {
			metrics.collations_generated_total.inc();
		}
	}
}

impl metrics::Metrics for Metrics {
353
	fn try_register(registry: &prometheus::Registry) -> Result<Self, prometheus::PrometheusError> {
354
355
356
357
358
359
360
361
362
363
364
365
366
		let metrics = MetricsInner {
			collations_generated_total: prometheus::register(
				prometheus::Counter::new(
					"parachain_collations_generated_total",
					"Number of collations generated."
				)?,
				registry,
			)?,
		};
		Ok(Metrics(Some(metrics)))
	}
}

367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
#[cfg(test)]
mod tests {
	mod handle_new_activations {
		use super::super::*;
		use futures::{
			lock::Mutex,
			task::{Context as FuturesContext, Poll},
			Future,
		};
		use polkadot_node_primitives::Collation;
		use polkadot_node_subsystem::messages::{
			AllMessages, RuntimeApiMessage, RuntimeApiRequest,
		};
		use polkadot_node_subsystem_test_helpers::{
			subsystem_test_harness, TestSubsystemContextHandle,
		};
		use polkadot_primitives::v1::{
384
385
			BlockData, BlockNumber, CollatorPair, Id as ParaId,
			PersistedValidationData, PoV, ScheduledCore, ValidationData,
386
387
388
389
390
391
		};
		use std::pin::Pin;

		fn test_collation() -> Collation {
			Collation {
				upward_messages: Default::default(),
Sergey Pepyakin's avatar
Sergey Pepyakin committed
392
				horizontal_messages: Default::default(),
393
394
395
396
397
				new_validation_code: Default::default(),
				head_data: Default::default(),
				proof_of_validity: PoV {
					block_data: BlockData(Vec::new()),
				},
398
				processed_downward_messages: Default::default(),
Sergey Pepyakin's avatar
Sergey Pepyakin committed
399
				hrmp_watermark: Default::default(),
400
401
402
403
404
405
406
			}
		}

		// Box<dyn Future<Output = Collation> + Unpin + Send
		struct TestCollator;

		impl Future for TestCollator {
407
			type Output = Option<Collation>;
408
409

			fn poll(self: Pin<&mut Self>, _cx: &mut FuturesContext) -> Poll<Self::Output> {
410
				Poll::Ready(Some(test_collation()))
411
412
413
414
415
416
417
418
			}
		}

		impl Unpin for TestCollator {}

		fn test_config<Id: Into<ParaId>>(para_id: Id) -> Arc<CollationGenerationConfig> {
			Arc::new(CollationGenerationConfig {
				key: CollatorPair::generate().0,
419
				collator: Box::new(|_: Hash, _vd: &ValidationData| {
420
					TestCollator.boxed()
421
422
423
424
425
426
427
428
429
430
431
432
433
				}),
				para_id: para_id.into(),
			})
		}

		fn scheduled_core_for<Id: Into<ParaId>>(para_id: Id) -> ScheduledCore {
			ScheduledCore {
				para_id: para_id.into(),
				collator: None,
			}
		}

		#[test]
434
		fn requests_availability_per_relay_parent() {
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
			let activated_hashes: Vec<Hash> = vec![
				[1; 32].into(),
				[4; 32].into(),
				[9; 32].into(),
				[16; 32].into(),
			];

			let requested_availability_cores = Arc::new(Mutex::new(Vec::new()));

			let overseer_requested_availability_cores = requested_availability_cores.clone();
			let overseer = |mut handle: TestSubsystemContextHandle<CollationGenerationMessage>| async move {
				loop {
					match handle.try_recv().await {
						None => break,
						Some(AllMessages::RuntimeApi(RuntimeApiMessage::Request(hash, RuntimeApiRequest::AvailabilityCores(tx)))) => {
							overseer_requested_availability_cores.lock().await.push(hash);
							tx.send(Ok(vec![])).unwrap();
						}
						Some(AllMessages::RuntimeApi(RuntimeApiMessage::Request(_hash, RuntimeApiRequest::Validators(tx)))) => {
							tx.send(Ok(vec![Default::default(); 3])).unwrap();
						}
						Some(msg) => panic!("didn't expect any other overseer requests given no availability cores; got {:?}", msg),
					}
				}
			};

			let (tx, _rx) = mpsc::channel(0);

			let subsystem_activated_hashes = activated_hashes.clone();
			subsystem_test_harness(overseer, |mut ctx| async move {
				handle_new_activations(
466
					test_config(123u32),
467
468
					&subsystem_activated_hashes,
					&mut ctx,
469
					Metrics(None),
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
					&tx,
				)
				.await
				.unwrap();
			});

			let mut requested_availability_cores = Arc::try_unwrap(requested_availability_cores)
				.expect("overseer should have shut down by now")
				.into_inner();
			requested_availability_cores.sort();

			assert_eq!(requested_availability_cores, activated_hashes);
		}

		#[test]
485
		fn requests_validation_data_for_scheduled_matches() {
486
487
488
489
490
491
492
			let activated_hashes: Vec<Hash> = vec![
				Hash::repeat_byte(1),
				Hash::repeat_byte(4),
				Hash::repeat_byte(9),
				Hash::repeat_byte(16),
			];

493
			let requested_full_validation_data = Arc::new(Mutex::new(Vec::new()));
494

495
			let overseer_requested_full_validation_data = requested_full_validation_data.clone();
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
			let overseer = |mut handle: TestSubsystemContextHandle<CollationGenerationMessage>| async move {
				loop {
					match handle.try_recv().await {
						None => break,
						Some(AllMessages::RuntimeApi(RuntimeApiMessage::Request(
							hash,
							RuntimeApiRequest::AvailabilityCores(tx),
						))) => {
							tx.send(Ok(vec![
								CoreState::Free,
								// this is weird, see explanation below
								CoreState::Scheduled(scheduled_core_for(
									(hash.as_fixed_bytes()[0] * 4) as u32,
								)),
								CoreState::Scheduled(scheduled_core_for(
									(hash.as_fixed_bytes()[0] * 5) as u32,
								)),
							]))
							.unwrap();
						}
						Some(AllMessages::RuntimeApi(RuntimeApiMessage::Request(
							hash,
518
							RuntimeApiRequest::FullValidationData(
519
520
521
522
523
								_para_id,
								_occupied_core_assumption,
								tx,
							),
						))) => {
524
							overseer_requested_full_validation_data
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
								.lock()
								.await
								.push(hash);
							tx.send(Ok(Default::default())).unwrap();
						}
						Some(AllMessages::RuntimeApi(RuntimeApiMessage::Request(
							_hash,
							RuntimeApiRequest::Validators(tx),
						))) => {
							tx.send(Ok(vec![Default::default(); 3])).unwrap();
						}
						Some(msg) => {
							panic!("didn't expect any other overseer requests; got {:?}", msg)
						}
					}
				}
			};

			let (tx, _rx) = mpsc::channel(0);

			subsystem_test_harness(overseer, |mut ctx| async move {
546
				handle_new_activations(test_config(16), &activated_hashes, &mut ctx, Metrics(None), &tx)
547
548
549
550
					.await
					.unwrap();
			});

551
			let requested_full_validation_data = Arc::try_unwrap(requested_full_validation_data)
552
553
554
555
556
557
558
				.expect("overseer should have shut down by now")
				.into_inner();

			// the only activated hash should be from the 4 hash:
			// each activated hash generates two scheduled cores: one with its value * 4, one with its value * 5
			// given that the test configuration has a para_id of 16, there's only one way to get that value: with the 4
			// hash.
559
			assert_eq!(requested_full_validation_data, vec![[4; 32].into()]);
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
		}

		#[test]
		fn sends_distribute_collation_message() {
			let activated_hashes: Vec<Hash> = vec![
				Hash::repeat_byte(1),
				Hash::repeat_byte(4),
				Hash::repeat_byte(9),
				Hash::repeat_byte(16),
			];

			let overseer = |mut handle: TestSubsystemContextHandle<CollationGenerationMessage>| async move {
				loop {
					match handle.try_recv().await {
						None => break,
						Some(AllMessages::RuntimeApi(RuntimeApiMessage::Request(
							hash,
							RuntimeApiRequest::AvailabilityCores(tx),
						))) => {
							tx.send(Ok(vec![
								CoreState::Free,
								// this is weird, see explanation below
								CoreState::Scheduled(scheduled_core_for(
									(hash.as_fixed_bytes()[0] * 4) as u32,
								)),
								CoreState::Scheduled(scheduled_core_for(
									(hash.as_fixed_bytes()[0] * 5) as u32,
								)),
							]))
							.unwrap();
						}
						Some(AllMessages::RuntimeApi(RuntimeApiMessage::Request(
							_hash,
593
							RuntimeApiRequest::FullValidationData(
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
								_para_id,
								_occupied_core_assumption,
								tx,
							),
						))) => {
							tx.send(Ok(Some(Default::default()))).unwrap();
						}
						Some(AllMessages::RuntimeApi(RuntimeApiMessage::Request(
							_hash,
							RuntimeApiRequest::Validators(tx),
						))) => {
							tx.send(Ok(vec![Default::default(); 3])).unwrap();
						}
						Some(msg) => {
							panic!("didn't expect any other overseer requests; got {:?}", msg)
						}
					}
				}
			};

			let config = test_config(16);
			let subsystem_config = config.clone();

			let (tx, rx) = mpsc::channel(0);

			// empty vec doesn't allocate on the heap, so it's ok we throw it away
			let sent_messages = Arc::new(Mutex::new(Vec::new()));
			let subsystem_sent_messages = sent_messages.clone();
			subsystem_test_harness(overseer, |mut ctx| async move {
623
				handle_new_activations(subsystem_config, &activated_hashes, &mut ctx, Metrics(None), &tx)
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
					.await
					.unwrap();

				std::mem::drop(tx);

				// collect all sent messages
				*subsystem_sent_messages.lock().await = rx.collect().await;
			});

			let sent_messages = Arc::try_unwrap(sent_messages)
				.expect("subsystem should have shut down by now")
				.into_inner();

			// we expect a single message to be sent, containing a candidate receipt.
			// we don't care too much about the commitments_hash right now, but let's ensure that we've calculated the
			// correct descriptor
			let expect_pov_hash = test_collation().proof_of_validity.hash();
641
642
			let expect_validation_data_hash
				= PersistedValidationData::<BlockNumber>::default().hash();
643
644
645
646
647
648
649
650
651
652
653
654
			let expect_relay_parent = Hash::repeat_byte(4);
			let expect_payload = collator_signature_payload(
				&expect_relay_parent,
				&config.para_id,
				&expect_validation_data_hash,
				&expect_pov_hash,
			);
			let expect_descriptor = CandidateDescriptor {
				signature: config.key.sign(&expect_payload),
				para_id: config.para_id,
				relay_parent: expect_relay_parent,
				collator: config.key.public(),
655
				persisted_validation_data_hash: expect_validation_data_hash,
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
				pov_hash: expect_pov_hash,
			};

			assert_eq!(sent_messages.len(), 1);
			match &sent_messages[0] {
				AllMessages::CollatorProtocol(CollatorProtocolMessage::DistributeCollation(
					CandidateReceipt { descriptor, .. },
					_pov,
				)) => {
					// signature generation is non-deterministic, so we can't just assert that the
					// expected descriptor is correct. What we can do is validate that the produced
					// descriptor has a valid signature, then just copy in the generated signature
					// and check the rest of the fields for equality.
					assert!(CollatorPair::verify(
						&descriptor.signature,
						&collator_signature_payload(
							&descriptor.relay_parent,
							&descriptor.para_id,
674
							&descriptor.persisted_validation_data_hash,
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
							&descriptor.pov_hash,
						)
						.as_ref(),
						&descriptor.collator,
					));
					let expect_descriptor = {
						let mut expect_descriptor = expect_descriptor;
						expect_descriptor.signature = descriptor.signature.clone();
						expect_descriptor
					};
					assert_eq!(descriptor, &expect_descriptor);
				}
				_ => panic!("received wrong message type"),
			}
		}
	}
}