lib.rs 30.5 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
// Copyright 2020 Parity Technologies (UK) Ltd.
// This file is part of Polkadot.

// Polkadot is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.

// Polkadot is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
// GNU General Public License for more details.

// You should have received a copy of the GNU General Public License
// along with Polkadot.  If not, see <http://www.gnu.org/licenses/>.

//! The Network Bridge Subsystem - protocol multiplexer for Polkadot.

19
#![deny(unused_crate_dependencies)]
20
21
#![warn(missing_docs)]

Shawn Tabrizi's avatar
Shawn Tabrizi committed
22
23
use futures::{prelude::*, stream::BoxStream};
use parity_scale_codec::{Decode, Encode};
24
25
use parking_lot::Mutex;
use sc_network::Event as NetworkEvent;
26
use sp_consensus::SyncOracle;
27

Shawn Tabrizi's avatar
Shawn Tabrizi committed
28
29
30
use polkadot_node_network_protocol::{
	peer_set::PeerSet, v1 as protocol_v1, ObservedRole, OurView, PeerId,
	UnifiedReputationChange as Rep, View,
31
};
Shawn Tabrizi's avatar
Shawn Tabrizi committed
32
33
34
use polkadot_node_subsystem_util::metrics::{self, prometheus};
use polkadot_overseer::gen::{OverseerError, Subsystem};
use polkadot_primitives::v1::{BlockNumber, Hash};
35
36
use polkadot_subsystem::{
	errors::{SubsystemError, SubsystemResult},
37
	messages::{AllMessages, CollatorProtocolMessage, NetworkBridgeEvent, NetworkBridgeMessage},
Shawn Tabrizi's avatar
Shawn Tabrizi committed
38
39
	overseer, ActivatedLeaf, ActiveLeavesUpdate, FromOverseer, OverseerSignal, SpawnedSubsystem,
	SubsystemContext, SubsystemSender,
40
};
41

Denis_P's avatar
Denis_P committed
42
/// Peer set info for network initialization.
43
44
///
/// To be added to [`NetworkConfiguration::extra_sets`].
45
pub use polkadot_node_network_protocol::peer_set::{peer_sets_info, IsAuthority};
46

Shawn Tabrizi's avatar
Shawn Tabrizi committed
47
48
49
50
use std::{
	collections::{hash_map, HashMap, HashSet},
	sync::Arc,
};
51

52
53
mod validator_discovery;

54
55
56
57
/// Actual interfacing to the network based on the `Network` trait.
///
/// Defines the `Network` trait with an implementation for an `Arc<NetworkService>`.
mod network;
Shawn Tabrizi's avatar
Shawn Tabrizi committed
58
use network::{send_message, Network};
59

60
61
use crate::network::get_peer_id_by_authority_id;

Andronik Ordian's avatar
Andronik Ordian committed
62
63
#[cfg(test)]
mod tests;
64

65
66
67
68
69
/// The maximum amount of heads a peer is allowed to have in their view at any time.
///
/// We use the same limit to compute the view sent to peers locally.
const MAX_VIEW_HEADS: usize = 5;

70
71
72
73
const MALFORMED_MESSAGE_COST: Rep = Rep::CostMajor("Malformed Network-bridge message");
const UNCONNECTED_PEERSET_COST: Rep = Rep::CostMinor("Message sent to un-connected peer-set");
const MALFORMED_VIEW_COST: Rep = Rep::CostMajor("Malformed view");
const EMPTY_VIEW_COST: Rep = Rep::CostMajor("Peer sent us an empty view");
74

75
// network bridge log target
76
const LOG_TARGET: &'static str = "parachain::network-bridge";
77

78
79
80
81
82
83
/// Metrics for the network bridge.
#[derive(Clone, Default)]
pub struct Metrics(Option<MetricsInner>);

impl Metrics {
	fn on_peer_connected(&self, peer_set: PeerSet) {
Shawn Tabrizi's avatar
Shawn Tabrizi committed
84
85
86
87
88
89
		self.0.as_ref().map(|metrics| {
			metrics
				.connected_events
				.with_label_values(&[peer_set.get_protocol_name_static()])
				.inc()
		});
90
91
92
	}

	fn on_peer_disconnected(&self, peer_set: PeerSet) {
Shawn Tabrizi's avatar
Shawn Tabrizi committed
93
94
95
96
97
98
		self.0.as_ref().map(|metrics| {
			metrics
				.disconnected_events
				.with_label_values(&[peer_set.get_protocol_name_static()])
				.inc()
		});
99
100
101
	}

	fn note_peer_count(&self, peer_set: PeerSet, count: usize) {
Shawn Tabrizi's avatar
Shawn Tabrizi committed
102
103
104
105
106
107
		self.0.as_ref().map(|metrics| {
			metrics
				.peer_count
				.with_label_values(&[peer_set.get_protocol_name_static()])
				.set(count as u64)
		});
108
109
110
111
	}

	fn on_notification_received(&self, peer_set: PeerSet, size: usize) {
		if let Some(metrics) = self.0.as_ref() {
Shawn Tabrizi's avatar
Shawn Tabrizi committed
112
113
			metrics
				.notifications_received
114
115
116
				.with_label_values(&[peer_set.get_protocol_name_static()])
				.inc();

Shawn Tabrizi's avatar
Shawn Tabrizi committed
117
118
			metrics
				.bytes_received
119
120
121
122
123
124
125
				.with_label_values(&[peer_set.get_protocol_name_static()])
				.inc_by(size as u64);
		}
	}

	fn on_notification_sent(&self, peer_set: PeerSet, size: usize, to_peers: usize) {
		if let Some(metrics) = self.0.as_ref() {
Shawn Tabrizi's avatar
Shawn Tabrizi committed
126
127
			metrics
				.notifications_sent
128
129
130
				.with_label_values(&[peer_set.get_protocol_name_static()])
				.inc_by(to_peers as u64);

Shawn Tabrizi's avatar
Shawn Tabrizi committed
131
132
			metrics
				.bytes_sent
133
134
135
136
				.with_label_values(&[peer_set.get_protocol_name_static()])
				.inc_by((size * to_peers) as u64);
		}
	}
137
138

	fn note_desired_peer_count(&self, peer_set: PeerSet, size: usize) {
Shawn Tabrizi's avatar
Shawn Tabrizi committed
139
140
141
142
143
144
		self.0.as_ref().map(|metrics| {
			metrics
				.desired_peer_count
				.with_label_values(&[peer_set.get_protocol_name_static()])
				.set(size as u64)
		});
145
	}
146
147
148
149
150
151
152
}

#[derive(Clone)]
struct MetricsInner {
	peer_count: prometheus::GaugeVec<prometheus::U64>,
	connected_events: prometheus::CounterVec<prometheus::U64>,
	disconnected_events: prometheus::CounterVec<prometheus::U64>,
153
	desired_peer_count: prometheus::GaugeVec<prometheus::U64>,
154
155
156
157
158
159
160
161
162

	notifications_received: prometheus::CounterVec<prometheus::U64>,
	notifications_sent: prometheus::CounterVec<prometheus::U64>,

	bytes_received: prometheus::CounterVec<prometheus::U64>,
	bytes_sent: prometheus::CounterVec<prometheus::U64>,
}

impl metrics::Metrics for Metrics {
Shawn Tabrizi's avatar
Shawn Tabrizi committed
163
164
165
	fn try_register(
		registry: &prometheus::Registry,
	) -> std::result::Result<Self, prometheus::PrometheusError> {
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
		let metrics = MetricsInner {
			peer_count: prometheus::register(
				prometheus::GaugeVec::new(
					prometheus::Opts::new(
						"parachain_peer_count",
						"The number of peers on a parachain-related peer-set",
					),
					&["protocol"]
				)?,
				registry,
			)?,
			connected_events: prometheus::register(
				prometheus::CounterVec::new(
					prometheus::Opts::new(
						"parachain_peer_connect_events_total",
						"The number of peer connect events on a parachain notifications protocol",
					),
					&["protocol"]
				)?,
				registry,
			)?,
			disconnected_events: prometheus::register(
				prometheus::CounterVec::new(
					prometheus::Opts::new(
						"parachain_peer_disconnect_events_total",
						"The number of peer disconnect events on a parachain notifications protocol",
					),
					&["protocol"]
				)?,
				registry,
			)?,
197
198
199
200
			desired_peer_count: prometheus::register(
				prometheus::GaugeVec::new(
					prometheus::Opts::new(
						"parachain_desired_peer_count",
201
						"The number of peers that the local node is expected to connect to on a parachain-related peer-set (either including or not including unresolvable authorities, depending on whether `ConnectToValidators` or `ConnectToValidatorsResolved` was used.)",
202
203
204
205
206
					),
					&["protocol"]
				)?,
				registry,
			)?,
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
			notifications_received: prometheus::register(
				prometheus::CounterVec::new(
					prometheus::Opts::new(
						"parachain_notifications_received_total",
						"The number of notifications received on a parachain protocol",
					),
					&["protocol"]
				)?,
				registry,
			)?,
			notifications_sent: prometheus::register(
				prometheus::CounterVec::new(
					prometheus::Opts::new(
						"parachain_notifications_sent_total",
						"The number of notifications sent on a parachain protocol",
					),
					&["protocol"]
				)?,
				registry,
			)?,
			bytes_received: prometheus::register(
				prometheus::CounterVec::new(
					prometheus::Opts::new(
						"parachain_notification_bytes_received_total",
						"The number of bytes received on a parachain notification protocol",
					),
					&["protocol"]
				)?,
				registry,
			)?,
			bytes_sent: prometheus::register(
				prometheus::CounterVec::new(
					prometheus::Opts::new(
						"parachain_notification_bytes_sent_total",
						"The number of bytes sent on a parachain notification protocol",
					),
					&["protocol"]
				)?,
				registry,
			)?,
		};

		Ok(Metrics(Some(metrics)))
	}
}

253
254
255
/// Messages from and to the network.
///
/// As transmitted to and received from subsystems.
256
#[derive(Debug, Encode, Decode, Clone)]
257
pub enum WireMessage<M> {
258
	/// A message from a peer on a specific protocol.
259
	#[codec(index = 1)]
260
	ProtocolMessage(M),
261
	/// A view update from a peer.
262
	#[codec(index = 2)]
263
264
265
266
	ViewUpdate(View),
}

/// The network bridge subsystem.
267
pub struct NetworkBridge<N, AD> {
268
	/// `Network` trait implementing type.
269
270
	network_service: N,
	authority_discovery_service: AD,
271
	sync_oracle: Box<dyn SyncOracle + Send>,
272
	metrics: Metrics,
273
}
274

275
276
impl<N, AD> NetworkBridge<N, AD> {
	/// Create a new network bridge subsystem with underlying network service and authority discovery service.
277
278
	///
	/// This assumes that the network service has had the notifications protocol for the network
279
	/// bridge already registered. See [`peers_sets_info`](peers_sets_info).
280
281
282
283
	pub fn new(
		network_service: N,
		authority_discovery_service: AD,
		sync_oracle: Box<dyn SyncOracle + Send>,
284
		metrics: Metrics,
285
	) -> Self {
286
		NetworkBridge { network_service, authority_discovery_service, sync_oracle, metrics }
287
288
289
	}
}

290
impl<Net, AD, Context> Subsystem<Context, SubsystemError> for NetworkBridge<Net, AD>
Shawn Tabrizi's avatar
Shawn Tabrizi committed
291
292
293
294
295
where
	Net: Network + Sync,
	AD: validator_discovery::AuthorityDiscovery + Clone,
	Context: SubsystemContext<Message = NetworkBridgeMessage>
		+ overseer::SubsystemContext<Message = NetworkBridgeMessage>,
296
{
297
298
299
300
301
	fn start(mut self, ctx: Context) -> SpawnedSubsystem {
		// The stream of networking events has to be created at initialization, otherwise the
		// networking might open connections before the stream of events has been grabbed.
		let network_stream = self.network_service.event_stream();

302
303
		// Swallow error because failure is fatal to the node and we log with more precision
		// within `run_network`.
304
		let future = run_network(self, ctx, network_stream)
Shawn Tabrizi's avatar
Shawn Tabrizi committed
305
			.map_err(|e| SubsystemError::with_origin("network-bridge", e))
306
			.boxed();
Shawn Tabrizi's avatar
Shawn Tabrizi committed
307
		SpawnedSubsystem { name: "network-bridge-subsystem", future }
308
309
310
311
	}
}

struct PeerData {
Bernhard Schuster's avatar
Bernhard Schuster committed
312
	/// The Latest view sent by the peer.
313
314
315
	view: View,
}

316
317
318
#[derive(Debug)]
enum UnexpectedAbort {
	/// Received error from overseer:
319
	SubsystemError(SubsystemError),
320
321
322
323
324
325
326
327
328
329
	/// The stream of incoming events concluded.
	EventStreamConcluded,
}

impl From<SubsystemError> for UnexpectedAbort {
	fn from(e: SubsystemError) -> Self {
		UnexpectedAbort::SubsystemError(e)
	}
}

330
331
332
333
334
335
impl From<OverseerError> for UnexpectedAbort {
	fn from(e: OverseerError) -> Self {
		UnexpectedAbort::SubsystemError(SubsystemError::from(e))
	}
}

336
337
338
339
340
#[derive(Default, Clone)]
struct Shared(Arc<Mutex<SharedInner>>);

#[derive(Default)]
struct SharedInner {
341
	local_view: Option<View>,
342
343
344
345
	validation_peers: HashMap<PeerId, PeerData>,
	collation_peers: HashMap<PeerId, PeerData>,
}

346
347
348
349
350
enum Mode {
	Syncing(Box<dyn SyncOracle + Send>),
	Active,
}

351
352
353
354
355
async fn handle_subsystem_messages<Context, N, AD>(
	mut ctx: Context,
	mut network_service: N,
	mut authority_discovery_service: AD,
	shared: Shared,
356
	sync_oracle: Box<dyn SyncOracle + Send>,
357
	metrics: Metrics,
358
) -> Result<(), UnexpectedAbort>
359
where
360
	Context: SubsystemContext<Message = NetworkBridgeMessage>,
361
	Context: overseer::SubsystemContext<Message = NetworkBridgeMessage>,
362
	N: Network,
363
	AD: validator_discovery::AuthorityDiscovery + Clone,
364
{
365
366
	// This is kept sorted, descending, by block number.
	let mut live_heads: Vec<ActivatedLeaf> = Vec::with_capacity(MAX_VIEW_HEADS);
367
368
369
	let mut finalized_number = 0;
	let mut validator_discovery = validator_discovery::Service::<N, AD>::new();

370
371
	let mut mode = Mode::Syncing(sync_oracle);

372
373
374
375
376
377
	loop {
		futures::select! {
			msg = ctx.recv().fuse() => match msg {
				Ok(FromOverseer::Signal(OverseerSignal::ActiveLeaves(active_leaves))) => {
					let ActiveLeavesUpdate { activated, deactivated } = active_leaves;
					tracing::trace!(
378
						target: LOG_TARGET,
379
						action = "ActiveLeaves",
380
						has_activated = activated.is_some(),
381
						num_deactivated = %deactivated.len(),
382
					);
383
384
385
386
387
388
389
390
391
392

					for activated in activated {
						let pos = live_heads
							.binary_search_by(|probe| probe.number.cmp(&activated.number).reverse())
							.unwrap_or_else(|i| i);

						live_heads.insert(pos, activated);
					}
					live_heads.retain(|h| !deactivated.contains(&h.hash));

393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
					// if we're done syncing, set the mode to `Mode::Active`.
					// Otherwise, we don't need to send view updates.
					{
						let is_done_syncing = match mode {
							Mode::Active => true,
							Mode::Syncing(ref mut sync_oracle) => !sync_oracle.is_major_syncing(),
						};

						if is_done_syncing {
							mode = Mode::Active;

							update_our_view(
								&mut network_service,
								&mut ctx,
								&live_heads,
								&shared,
								finalized_number,
410
								&metrics,
411
							);
412
413
						}
					}
414
				}
415
416
				Ok(FromOverseer::Signal(OverseerSignal::BlockFinalized(_hash, number))) => {
					tracing::trace!(
417
						target: LOG_TARGET,
418
						action = "BlockFinalized"
419
					);
420

421
					debug_assert!(finalized_number < number);
422

423
424
425
426
427
428
429
430
431
432
					// we don't send the view updates here, but delay them until the next `ActiveLeaves`
					// otherwise it might break assumptions of some of the subsystems
					// that we never send the same `ActiveLeavesUpdate`
					finalized_number = number;
				}
				Ok(FromOverseer::Signal(OverseerSignal::Conclude)) => {
					return Ok(());
				}
				Ok(FromOverseer::Communication { msg }) => match msg {
					NetworkBridgeMessage::ReportPeer(peer, rep) => {
433
434
435
						if !rep.is_benefit() {
							tracing::debug!(
								target: LOG_TARGET,
436
437
								?peer,
								?rep,
438
439
440
								action = "ReportPeer"
							);
						}
441
						network_service.report_peer(peer, rep);
442
443
444
445
446
447
448
449
					}
					NetworkBridgeMessage::DisconnectPeer(peer, peer_set) => {
						tracing::trace!(
							target: LOG_TARGET,
							action = "DisconnectPeer",
							?peer,
							peer_set = ?peer_set,
						);
450
						network_service.disconnect_peer(peer, peer_set);
451
452
453
454
455
456
457
458
459
460
					}
					NetworkBridgeMessage::SendValidationMessage(peers, msg) => {
						tracing::trace!(
							target: LOG_TARGET,
							action = "SendValidationMessages",
							num_messages = 1,
						);

						send_message(
							&mut network_service,
461
462
463
							peers,
							PeerSet::Validation,
							WireMessage::ProtocolMessage(msg),
464
							&metrics,
465
						);
466
467
468
469
470
471
472
473
474
475
476
477
478
479
					}
					NetworkBridgeMessage::SendValidationMessages(msgs) => {
						tracing::trace!(
							target: LOG_TARGET,
							action = "SendValidationMessages",
							num_messages = %msgs.len(),
						);

						for (peers, msg) in msgs {
							send_message(
								&mut network_service,
								peers,
								PeerSet::Validation,
								WireMessage::ProtocolMessage(msg),
480
								&metrics,
481
							);
482
483
484
485
486
487
488
489
490
491
492
						}
					}
					NetworkBridgeMessage::SendCollationMessage(peers, msg) => {
						tracing::trace!(
							target: LOG_TARGET,
							action = "SendCollationMessages",
							num_messages = 1,
						);

						send_message(
							&mut network_service,
493
494
495
							peers,
							PeerSet::Collation,
							WireMessage::ProtocolMessage(msg),
496
							&metrics,
497
						);
498
499
500
501
502
503
504
505
506
507
508
509
510
511
					}
					NetworkBridgeMessage::SendCollationMessages(msgs) => {
						tracing::trace!(
							target: LOG_TARGET,
							action = "SendCollationMessages",
							num_messages = %msgs.len(),
						);

						for (peers, msg) in msgs {
							send_message(
								&mut network_service,
								peers,
								PeerSet::Collation,
								WireMessage::ProtocolMessage(msg),
512
								&metrics,
513
							);
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
						}
					}
					NetworkBridgeMessage::SendRequests(reqs, if_disconnected) => {
						tracing::trace!(
							target: LOG_TARGET,
							action = "SendRequests",
							num_requests = %reqs.len(),
						);

						for req in reqs {
							network_service
								.start_request(&mut authority_discovery_service, req, if_disconnected)
								.await;
						}
					}
					NetworkBridgeMessage::ConnectToValidators {
						validator_ids,
						peer_set,
532
						failed,
533
534
535
536
537
538
539
540
541
					} => {
						tracing::trace!(
							target: LOG_TARGET,
							action = "ConnectToValidators",
							peer_set = ?peer_set,
							ids = ?validator_ids,
							"Received a validator connection request",
						);

542
543
						metrics.note_desired_peer_count(peer_set, validator_ids.len());

544
545
546
						let (ns, ads) = validator_discovery.on_request(
							validator_ids,
							peer_set,
547
							failed,
548
549
550
551
552
553
554
							network_service,
							authority_discovery_service,
						).await;

						network_service = ns;
						authority_discovery_service = ads;
					}
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
					NetworkBridgeMessage::ConnectToResolvedValidators {
						validator_addrs,
						peer_set,
					} => {
						tracing::trace!(
							target: LOG_TARGET,
							action = "ConnectToPeers",
							peer_set = ?peer_set,
							?validator_addrs,
							"Received a resolved validator connection request",
						);

						metrics.note_desired_peer_count(peer_set, validator_addrs.len());

						let all_addrs = validator_addrs.into_iter().flatten().collect();
						network_service = validator_discovery.on_resolved_request(
							all_addrs,
							peer_set,
							network_service,
						).await;
					}
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
					NetworkBridgeMessage::NewGossipTopology {
						our_neighbors,
					} => {
						tracing::debug!(
							target: LOG_TARGET,
							action = "NewGossipTopology",
							neighbors = our_neighbors.len(),
							"Gossip topology has changed",
						);

						let ads = &mut authority_discovery_service;
						let mut gossip_peers = HashSet::with_capacity(our_neighbors.len());
						for authority in our_neighbors {
							let addr = get_peer_id_by_authority_id(
								ads,
								authority.clone(),
							).await;

							if let Some(peer_id) = addr {
								gossip_peers.insert(peer_id);
							}
						}

						dispatch_validation_event_to_all_unbounded(
							NetworkBridgeEvent::NewGossipTopology(gossip_peers),
							ctx.sender(),
						);
					}
604
				}
605
606
607
608
609
				Err(e) => return Err(e.into()),
			},
		}
	}
}
610

611
async fn handle_network_messages<AD: validator_discovery::AuthorityDiscovery>(
612
613
	mut sender: impl SubsystemSender,
	mut network_service: impl Network,
614
	network_stream: BoxStream<'static, NetworkEvent>,
615
	mut authority_discovery_service: AD,
616
	metrics: Metrics,
617
618
	shared: Shared,
) -> Result<(), UnexpectedAbort> {
619
	let mut network_stream = network_stream.fuse();
620
	loop {
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
		match network_stream.next().await {
			None => return Err(UnexpectedAbort::EventStreamConcluded),
			Some(NetworkEvent::Dht(_)) |
			Some(NetworkEvent::SyncConnected { .. }) |
			Some(NetworkEvent::SyncDisconnected { .. }) => {},
			Some(NetworkEvent::NotificationStreamOpened {
				remote: peer, protocol, role, ..
			}) => {
				let role = ObservedRole::from(role);
				let peer_set = match PeerSet::try_from_protocol_name(&protocol) {
					None => continue,
					Some(peer_set) => peer_set,
				};

				tracing::debug!(
					target: LOG_TARGET,
					action = "PeerConnected",
					peer_set = ?peer_set,
					peer = ?peer,
					role = ?role
				);

				let local_view = {
					let mut shared = shared.0.lock();
					let peer_map = match peer_set {
						PeerSet::Validation => &mut shared.validation_peers,
						PeerSet::Collation => &mut shared.collation_peers,
648
649
					};

650
651
652
653
654
655
					match peer_map.entry(peer.clone()) {
						hash_map::Entry::Occupied(_) => continue,
						hash_map::Entry::Vacant(vacant) => {
							vacant.insert(PeerData { view: View::default() });
						},
					}
656

657
658
					metrics.on_peer_connected(peer_set);
					metrics.note_peer_count(peer_set, peer_map.len());
659

660
661
					shared.local_view.clone().unwrap_or(View::default())
				};
662

663
664
				let maybe_authority =
					authority_discovery_service.get_authority_id_by_peer_id(peer).await;
665

666
667
668
669
670
671
672
673
				match peer_set {
					PeerSet::Validation => {
						dispatch_validation_events_to_all(
							vec![
								NetworkBridgeEvent::PeerConnected(
									peer.clone(),
									role,
									maybe_authority,
674
								),
675
676
677
678
679
								NetworkBridgeEvent::PeerViewChange(peer.clone(), View::default()),
							],
							&mut sender,
						)
						.await;
680

681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
						send_message(
							&mut network_service,
							vec![peer],
							PeerSet::Validation,
							WireMessage::<protocol_v1::ValidationProtocol>::ViewUpdate(local_view),
							&metrics,
						);
					},
					PeerSet::Collation => {
						dispatch_collation_events_to_all(
							vec![
								NetworkBridgeEvent::PeerConnected(
									peer.clone(),
									role,
									maybe_authority,
696
								),
697
698
699
700
701
702
703
704
705
706
707
708
709
710
								NetworkBridgeEvent::PeerViewChange(peer.clone(), View::default()),
							],
							&mut sender,
						)
						.await;

						send_message(
							&mut network_service,
							vec![peer],
							PeerSet::Collation,
							WireMessage::<protocol_v1::CollationProtocol>::ViewUpdate(local_view),
							&metrics,
						);
					},
711
				}
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
			},
			Some(NetworkEvent::NotificationStreamClosed { remote: peer, protocol }) => {
				let peer_set = match PeerSet::try_from_protocol_name(&protocol) {
					None => continue,
					Some(peer_set) => peer_set,
				};

				tracing::debug!(
					target: LOG_TARGET,
					action = "PeerDisconnected",
					peer_set = ?peer_set,
					peer = ?peer
				);

				let was_connected = {
					let mut shared = shared.0.lock();
					let peer_map = match peer_set {
						PeerSet::Validation => &mut shared.validation_peers,
						PeerSet::Collation => &mut shared.collation_peers,
731
					};
732

733
					let w = peer_map.remove(&peer).is_some();
734

735
736
					metrics.on_peer_disconnected(peer_set);
					metrics.note_peer_count(peer_set, peer_map.len());
737

738
739
					w
				};
740

741
742
743
744
				if was_connected {
					match peer_set {
						PeerSet::Validation =>
							dispatch_validation_event_to_all(
745
746
								NetworkBridgeEvent::PeerDisconnected(peer),
								&mut sender,
747
748
749
750
							)
							.await,
						PeerSet::Collation =>
							dispatch_collation_event_to_all(
751
752
								NetworkBridgeEvent::PeerDisconnected(peer),
								&mut sender,
753
754
							)
							.await,
755
756
					}
				}
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
			},
			Some(NetworkEvent::NotificationsReceived { remote, messages }) => {
				let v_messages: Result<Vec<_>, _> = messages
					.iter()
					.filter(|(protocol, _)| protocol == &PeerSet::Validation.into_protocol_name())
					.map(|(_, msg_bytes)| {
						WireMessage::decode(&mut msg_bytes.as_ref()).map(|m| (m, msg_bytes.len()))
					})
					.collect();

				let v_messages = match v_messages {
					Err(_) => {
						tracing::debug!(target: LOG_TARGET, action = "ReportPeer");

						network_service.report_peer(remote, MALFORMED_MESSAGE_COST);
						continue
					},
					Ok(v) => v,
				};

				let c_messages: Result<Vec<_>, _> = messages
					.iter()
					.filter(|(protocol, _)| protocol == &PeerSet::Collation.into_protocol_name())
					.map(|(_, msg_bytes)| {
						WireMessage::decode(&mut msg_bytes.as_ref()).map(|m| (m, msg_bytes.len()))
					})
					.collect();

				match c_messages {
					Err(_) => {
						tracing::debug!(target: LOG_TARGET, action = "ReportPeer");

						network_service.report_peer(remote, MALFORMED_MESSAGE_COST);
						continue
					},
					Ok(c_messages) =>
						if v_messages.is_empty() && c_messages.is_empty() {
							continue
						} else {
							tracing::trace!(
797
								target: LOG_TARGET,
798
799
800
801
								action = "PeerMessages",
								peer = ?remote,
								num_validation_messages = %v_messages.len(),
								num_collation_messages = %c_messages.len()
802
803
							);

804
805
806
807
808
809
810
							if !v_messages.is_empty() {
								let (events, reports) = handle_peer_messages(
									remote.clone(),
									PeerSet::Validation,
									&mut shared.0.lock().validation_peers,
									v_messages,
									&metrics,
811
812
								);

813
814
								for report in reports {
									network_service.report_peer(remote.clone(), report);
815
816
								}

817
818
								dispatch_validation_events_to_all(events, &mut sender).await;
							}
819

820
821
822
823
824
825
826
827
							if !c_messages.is_empty() {
								let (events, reports) = handle_peer_messages(
									remote.clone(),
									PeerSet::Collation,
									&mut shared.0.lock().collation_peers,
									c_messages,
									&metrics,
								);
828

829
830
								for report in reports {
									network_service.report_peer(remote.clone(), report);
831
								}
832
833

								dispatch_collation_events_to_all(events, &mut sender).await;
834
							}
835
						},
836
837
				}
			},
838
		}
839
840
841
842
843
844
845
846
847
848
849
850
851
852
	}
}

/// Main driver, processing network events and messages from other subsystems.
///
/// THIS IS A HACK. We need to ensure we never hold the mutex across a `.await` boundary
/// and `parking_lot` currently does not provide `Send`, which helps us enforce that.
/// If this breaks, we need to find another way to protect ourselves.
///
/// ```compile_fail
/// #use parking_lot::MutexGuard;
/// #fn is_send<T: Send>();
/// #is_send::<parking_lot::MutexGuard<'static, ()>();
/// ```
853
async fn run_network<N, AD, Context>(
854
	bridge: NetworkBridge<N, AD>,
855
	mut ctx: Context,
856
	network_stream: BoxStream<'static, NetworkEvent>,
857
858
) -> SubsystemResult<()>
where
859
	N: Network,
860
	AD: validator_discovery::AuthorityDiscovery + Clone,
Shawn Tabrizi's avatar
Shawn Tabrizi committed
861
862
	Context: SubsystemContext<Message = NetworkBridgeMessage>
		+ overseer::SubsystemContext<Message = NetworkBridgeMessage>,
863
864
865
{
	let shared = Shared::default();

866
867
	let NetworkBridge { network_service, authority_discovery_service, metrics, sync_oracle } =
		bridge;
868

Shawn Tabrizi's avatar
Shawn Tabrizi committed
869
	let (remote, network_event_handler) = handle_network_messages(
870
871
		ctx.sender().clone(),
		network_service.clone(),
872
		network_stream,
873
		authority_discovery_service.clone(),
874
		metrics.clone(),
875
		shared.clone(),
Shawn Tabrizi's avatar
Shawn Tabrizi committed
876
877
	)
	.remote_handle();
878

879
	ctx.spawn("network-bridge-network-worker", Box::pin(remote))?;
880
881
882
883
884
885

	let subsystem_event_handler = handle_subsystem_messages(
		ctx,
		network_service,
		authority_discovery_service,
		shared,
886
		sync_oracle,
887
		metrics,
888
	);
889

890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
	futures::pin_mut!(subsystem_event_handler);

	match futures::future::select(subsystem_event_handler, network_event_handler)
		.await
		.factor_first()
		.0
	{
		Ok(()) => Ok(()),
		Err(UnexpectedAbort::SubsystemError(err)) => {
			tracing::warn!(
				target: LOG_TARGET,
				err = ?err,
				"Shutting down Network Bridge due to error"
			);

			Err(SubsystemError::Context(format!(
				"Received SubsystemError from overseer: {:?}",
				err
			)))
Shawn Tabrizi's avatar
Shawn Tabrizi committed
909
		},
910
911
912
913
914
		Err(UnexpectedAbort::EventStreamConcluded) => {
			tracing::info!(
				target: LOG_TARGET,
				"Shutting down Network Bridge: underlying request stream concluded"
			);
Shawn Tabrizi's avatar
Shawn Tabrizi committed
915
916
			Err(SubsystemError::Context("Incoming network event stream concluded.".to_string()))
		},
917
918
919
	}
}

Shawn Tabrizi's avatar
Shawn Tabrizi committed
920
921
922
923
924
fn construct_view(
	live_heads: impl DoubleEndedIterator<Item = Hash>,
	finalized_number: BlockNumber,
) -> View {
	View::new(live_heads.take(MAX_VIEW_HEADS), finalized_number)
925
926
}

927
fn update_our_view(
928
	net: &mut impl Network,
Shawn Tabrizi's avatar
Shawn Tabrizi committed
929
	ctx: &mut impl SubsystemContext<Message = NetworkBridgeMessage, AllMessages = AllMessages>,
930
	live_heads: &[ActivatedLeaf],
931
	shared: &Shared,
932
	finalized_number: BlockNumber,
933
	metrics: &Metrics,
934
) {
935
	let new_view = construct_view(live_heads.iter().map(|v| v.hash), finalized_number);
936

937
938
	let (validation_peers, collation_peers) = {
		let mut shared = shared.0.lock();
939

940
941
		// We only want to send a view update when the heads changed.
		// A change in finalized block number only is _not_ sufficient.
942
943
944
945
		//
		// If this is the first view update since becoming active, but our view is empty,
		// there is no need to send anything.
		match shared.local_view {
Shawn Tabrizi's avatar
Shawn Tabrizi committed
946
			Some(ref v) if v.check_heads_eq(&new_view) => return,
947
948
			None if live_heads.is_empty() => {
				shared.local_view = Some(new_view);
Shawn Tabrizi's avatar
Shawn Tabrizi committed
949
950
				return
			},
951
952
			_ => {
				shared.local_view = Some(new_view.clone());
Shawn Tabrizi's avatar
Shawn Tabrizi committed
953
			},
954
		}
955
956
957
958
959
960

		(
			shared.validation_peers.keys().cloned().collect::<Vec<_>>(),
			shared.collation_peers.keys().cloned().collect::<Vec<_>>(),
		)
	};
961

962
963
	send_validation_message(
		net,
964
		validation_peers,
965
		WireMessage::ViewUpdate(new_view.clone()),
966
		metrics,
967
	);
968

Shawn Tabrizi's avatar
Shawn Tabrizi committed
969
	send_collation_message(net, collation_peers, WireMessage::ViewUpdate(new_view), metrics);
970

971
972
973
974
	let our_view = OurView::new(
		live_heads.iter().take(MAX_VIEW_HEADS).cloned().map(|a| (a.hash, a.span)),
		finalized_number,
	);
975

976
977
978
979
	dispatch_validation_event_to_all_unbounded(
		NetworkBridgeEvent::OurViewChange(our_view.clone()),
		ctx.sender(),
	);
980

981
982
983
984
	dispatch_collation_event_to_all_unbounded(
		NetworkBridgeEvent::OurViewChange(our_view),
		ctx.sender(),
	);
985
986
987
988
}

// Handle messages on a specific peer-set. The peer is expected to be connected on that
// peer-set.
989
fn handle_peer_messages<M>(
990
	peer: PeerId,
991
	peer_set: PeerSet,
992
	peers: &mut HashMap<PeerId, PeerData>,
993
994
	messages: Vec<(WireMessage<M>, usize)>,
	metrics: &Metrics,
995
) -> (Vec<NetworkBridgeEvent<M>>, Vec<Rep>) {
996
	let peer_data = match peers.get_mut(&peer) {
Shawn Tabrizi's avatar
Shawn Tabrizi committed
997
		None => return (Vec::new(), vec![UNCONNECTED_PEERSET_COST]),
998
999
1000
		Some(d) => d,
	};

For faster browsing, not all history is shown. View entire blame