// This file is part of Substrate. // Copyright (C) Parity Technologies (UK) Ltd. // SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0 // This program is free software: you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation, either version 3 of the License, or // (at your option) any later version. // This program is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. // You should have received a copy of the GNU General Public License // along with this program. If not, see . use codec::DecodeAll; use sp_consensus::Error as ConsensusError; use sp_consensus_beefy::{ ecdsa_crypto::{AuthorityId, Signature}, BeefySignatureHasher, KnownSignature, ValidatorSet, ValidatorSetId, VersionedFinalityProof, }; use sp_runtime::traits::{Block as BlockT, NumberFor}; /// A finality proof with matching BEEFY authorities' signatures. pub type BeefyVersionedFinalityProof = VersionedFinalityProof, Signature>; pub(crate) fn proof_block_num_and_set_id( proof: &BeefyVersionedFinalityProof, ) -> (NumberFor, ValidatorSetId) { match proof { VersionedFinalityProof::V1(sc) => (sc.commitment.block_number, sc.commitment.validator_set_id), } } /// Decode and verify a Beefy FinalityProof. pub(crate) fn decode_and_verify_finality_proof( encoded: &[u8], target_number: NumberFor, validator_set: &ValidatorSet, ) -> Result, (ConsensusError, u32)> { let proof = >::decode_all(&mut &*encoded) .map_err(|_| (ConsensusError::InvalidJustification, 0))?; verify_with_validator_set::(target_number, validator_set, &proof)?; Ok(proof) } /// Verify the Beefy finality proof against the validator set at the block it was generated. pub(crate) fn verify_with_validator_set<'a, Block: BlockT>( target_number: NumberFor, validator_set: &'a ValidatorSet, proof: &'a BeefyVersionedFinalityProof, ) -> Result>, (ConsensusError, u32)> { match proof { VersionedFinalityProof::V1(signed_commitment) => { let signatories = signed_commitment .verify_signatures::<_, BeefySignatureHasher>(target_number, validator_set) .map_err(|checked_signatures| { (ConsensusError::InvalidJustification, checked_signatures) })?; if signatories.len() >= crate::round::threshold(validator_set.len()) { Ok(signatories) } else { Err(( ConsensusError::InvalidJustification, signed_commitment.signature_count() as u32, )) } }, } } #[cfg(test)] pub(crate) mod tests { use codec::Encode; use sp_consensus_beefy::{ known_payloads, test_utils::Keyring, Commitment, Payload, SignedCommitment, VersionedFinalityProof, }; use substrate_test_runtime_client::runtime::Block; use super::*; use crate::tests::make_beefy_ids; pub(crate) fn new_finality_proof( block_num: NumberFor, validator_set: &ValidatorSet, keys: &[Keyring], ) -> BeefyVersionedFinalityProof { let commitment = Commitment { payload: Payload::from_single_entry(known_payloads::MMR_ROOT_ID, vec![]), block_number: block_num, validator_set_id: validator_set.id(), }; let message = commitment.encode(); let signatures = keys.iter().map(|key| Some(key.sign(&message))).collect(); VersionedFinalityProof::V1(SignedCommitment { commitment, signatures }) } #[test] fn should_verify_with_validator_set() { let keys = &[Keyring::Alice, Keyring::Bob, Keyring::Charlie]; let validator_set = ValidatorSet::new(make_beefy_ids(keys), 0).unwrap(); // build valid justification let block_num = 42; let proof = new_finality_proof(block_num, &validator_set, keys); let good_proof = proof.clone().into(); // should verify successfully verify_with_validator_set::(block_num, &validator_set, &good_proof).unwrap(); // wrong block number -> should fail verification let good_proof = proof.clone().into(); match verify_with_validator_set::(block_num + 1, &validator_set, &good_proof) { Err((ConsensusError::InvalidJustification, 0)) => (), e => assert!(false, "Got unexpected {:?}", e), }; // wrong validator set id -> should fail verification let good_proof = proof.clone().into(); let other = ValidatorSet::new(make_beefy_ids(keys), 1).unwrap(); match verify_with_validator_set::(block_num, &other, &good_proof) { Err((ConsensusError::InvalidJustification, 0)) => (), e => assert!(false, "Got unexpected {:?}", e), }; // wrong signatures length -> should fail verification let mut bad_proof = proof.clone(); // change length of signatures let bad_signed_commitment = match bad_proof { VersionedFinalityProof::V1(ref mut sc) => sc, }; bad_signed_commitment.signatures.pop().flatten().unwrap(); match verify_with_validator_set::(block_num + 1, &validator_set, &bad_proof.into()) { Err((ConsensusError::InvalidJustification, 0)) => (), e => assert!(false, "Got unexpected {:?}", e), }; // not enough signatures -> should fail verification let mut bad_proof = proof.clone(); let bad_signed_commitment = match bad_proof { VersionedFinalityProof::V1(ref mut sc) => sc, }; // remove a signature (but same length) *bad_signed_commitment.signatures.first_mut().unwrap() = None; match verify_with_validator_set::(block_num, &validator_set, &bad_proof.into()) { Err((ConsensusError::InvalidJustification, 2)) => (), e => assert!(false, "Got unexpected {:?}", e), }; // not enough _correct_ signatures -> should fail verification let mut bad_proof = proof.clone(); let bad_signed_commitment = match bad_proof { VersionedFinalityProof::V1(ref mut sc) => sc, }; // change a signature to a different key *bad_signed_commitment.signatures.first_mut().unwrap() = Some(Keyring::::Dave.sign(&bad_signed_commitment.commitment.encode())); match verify_with_validator_set::(block_num, &validator_set, &bad_proof.into()) { Err((ConsensusError::InvalidJustification, 3)) => (), e => assert!(false, "Got unexpected {:?}", e), }; } #[test] fn should_decode_and_verify_finality_proof() { let keys = &[Keyring::Alice, Keyring::Bob]; let validator_set = ValidatorSet::new(make_beefy_ids(keys), 0).unwrap(); let block_num = 1; // build valid justification let proof = new_finality_proof(block_num, &validator_set, keys); let versioned_proof: BeefyVersionedFinalityProof = proof.into(); let encoded = versioned_proof.encode(); // should successfully decode and verify let verified = decode_and_verify_finality_proof::(&encoded, block_num, &validator_set).unwrap(); assert_eq!(verified, versioned_proof); } }