From f7119e40fac5eac9e6f4fd9b16ea4dea99d7472b Mon Sep 17 00:00:00 2001
From: Branislav Kontur <bkontur@gmail.com>
Date: Tue, 15 Oct 2024 09:01:20 +0200
Subject: [PATCH] Remove `check-migrations` for rococo chain (#6061)
This PR removes the `check-migrations` pipelines for all Rococo chains
because they are going down:
https://github.com/paritytech/devops/issues/3589, and these checks are
starting to fail, e.g.:
https://github.com/paritytech/polkadot-sdk/actions/runs/11339904745/job/31535485254?pr=4982
https://github.com/paritytech/polkadot-sdk/actions/runs/11339904745/job/31535486189?pr=4982
https://github.com/paritytech/polkadot-sdk/actions/runs/11339904745/job/31535486471?pr=4982
Additionally, `coretime-westend` was added to the `check-migrations`
matrix.
---
.github/workflows/check-runtime-migration.yml | 48 +++++--------------
.../coretime/coretime-westend/src/lib.rs | 1 +
prdoc/pr_6061.prdoc | 10 ++++
3 files changed, 22 insertions(+), 37 deletions(-)
create mode 100644 prdoc/pr_6061.prdoc
diff --git a/.github/workflows/check-runtime-migration.yml b/.github/workflows/check-runtime-migration.yml
index 39a1c4d0348..758de0e7b43 100644
--- a/.github/workflows/check-runtime-migration.yml
+++ b/.github/workflows/check-runtime-migration.yml
@@ -36,14 +36,10 @@ jobs:
network:
[
westend,
- rococo,
asset-hub-westend,
- asset-hub-rococo,
bridge-hub-westend,
- bridge-hub-rococo,
- contracts-rococo,
collectives-westend,
- coretime-rococo,
+ coretime-westend,
]
include:
- network: westend
@@ -52,49 +48,27 @@ jobs:
uri: "wss://try-runtime-westend.polkadot.io:443"
subcommand_extra_args: "--no-weight-warnings --blocktime 6000"
command_extra_args: ""
- - network: rococo
- package: rococo-runtime
- wasm: rococo_runtime.compact.compressed.wasm
- uri: "wss://try-runtime-rococo.polkadot.io:443"
- subcommand_extra_args: "--no-weight-warnings --blocktime 6000"
- command_extra_args: ""
- network: asset-hub-westend
package: asset-hub-westend-runtime
wasm: asset_hub_westend_runtime.compact.compressed.wasm
uri: "wss://westend-asset-hub-rpc.polkadot.io:443"
subcommand_extra_args: " --blocktime 6000"
command_extra_args: ""
- - network: "asset-hub-rococo"
- package: "asset-hub-rococo-runtime"
- wasm: "asset_hub_rococo_runtime.compact.compressed.wasm"
- uri: "wss://rococo-asset-hub-rpc.polkadot.io:443"
- subcommand_extra_args: " --blocktime 6000"
- command_extra_args: ""
- - network: "bridge-hub-westend"
- package: "bridge-hub-westend-runtime"
- wasm: "bridge_hub_westend_runtime.compact.compressed.wasm"
+ - network: bridge-hub-westend
+ package: bridge-hub-westend-runtime
+ wasm: bridge_hub_westend_runtime.compact.compressed.wasm
uri: "wss://westend-bridge-hub-rpc.polkadot.io:443"
subcommand_extra_args: " --blocktime 6000"
- - network: "bridge-hub-rococo"
- package: "bridge-hub-rococo-runtime"
- wasm: "bridge_hub_rococo_runtime.compact.compressed.wasm"
- uri: "wss://rococo-bridge-hub-rpc.polkadot.io:443"
- subcommand_extra_args: " --blocktime 6000"
- - network: "contracts-rococo"
- package: "contracts-rococo-runtime"
- wasm: "contracts_rococo_runtime.compact.compressed.wasm"
- uri: "wss://rococo-contracts-rpc.polkadot.io:443"
- subcommand_extra_args: " --blocktime 6000"
- - network: "collectives-westend"
- package: "collectives-westend-runtime"
- wasm: "collectives_westend_runtime.compact.compressed.wasm"
+ - network: collectives-westend
+ package: collectives-westend-runtime
+ wasm: collectives_westend_runtime.compact.compressed.wasm
uri: "wss://westend-collectives-rpc.polkadot.io:443"
command_extra_args: "--disable-spec-name-check"
subcommand_extra_args: " --blocktime 6000"
- - network: "coretime-rococo"
- package: "coretime-rococo-runtime"
- wasm: "coretime_rococo_runtime.compact.compressed.wasm"
- uri: "wss://rococo-coretime-rpc.polkadot.io:443"
+ - network: coretime-westend
+ package: coretime-westend-runtime
+ wasm: coretime_westend_runtime.compact.compressed.wasm
+ uri: "wss://westend-coretime-rpc.polkadot.io:443"
subcommand_extra_args: " --blocktime 6000"
steps:
- name: Checkout
diff --git a/cumulus/parachains/runtimes/coretime/coretime-westend/src/lib.rs b/cumulus/parachains/runtimes/coretime/coretime-westend/src/lib.rs
index e909b804587..187856b6c61 100644
--- a/cumulus/parachains/runtimes/coretime/coretime-westend/src/lib.rs
+++ b/cumulus/parachains/runtimes/coretime/coretime-westend/src/lib.rs
@@ -120,6 +120,7 @@ pub type UncheckedExtrinsic =
pub type Migrations = (
pallet_collator_selection::migration::v2::MigrationToV2<Runtime>,
cumulus_pallet_xcmp_queue::migration::v4::MigrationToV4<Runtime>,
+ cumulus_pallet_xcmp_queue::migration::v5::MigrateV4ToV5<Runtime>,
pallet_broker::migration::MigrateV0ToV1<Runtime>,
pallet_broker::migration::MigrateV1ToV2<Runtime>,
pallet_broker::migration::MigrateV2ToV3<Runtime>,
diff --git a/prdoc/pr_6061.prdoc b/prdoc/pr_6061.prdoc
new file mode 100644
index 00000000000..742e69ea9ec
--- /dev/null
+++ b/prdoc/pr_6061.prdoc
@@ -0,0 +1,10 @@
+title: Remove check-migrations for rococo chain
+
+doc:
+ - audience: [Runtime User]
+ description: |
+ This PR adds the missing `cumulus_pallet_xcmp_queue` v5 migration to the coretime-westend runtime.
+
+crates:
+- name: coretime-westend-runtime
+ bump: none
--
GitLab