From e9e6916596b59c8f0356d38aec6997b53451dcf0 Mon Sep 17 00:00:00 2001
From: Niklas Adolfsson <niklasadolfsson1@gmail.com>
Date: Tue, 14 Jun 2022 10:17:58 +0200
Subject: [PATCH] remove flaky rpc subscription tests (#11653)
---
substrate/client/beefy/rpc/src/lib.rs | 28 -------------------
.../client/finality-grandpa/rpc/src/lib.rs | 27 ------------------
2 files changed, 55 deletions(-)
diff --git a/substrate/client/beefy/rpc/src/lib.rs b/substrate/client/beefy/rpc/src/lib.rs
index c248d33cb6c..2c3ffda056c 100644
--- a/substrate/client/beefy/rpc/src/lib.rs
+++ b/substrate/client/beefy/rpc/src/lib.rs
@@ -241,34 +241,6 @@ mod tests {
);
}
- #[tokio::test]
- async fn subscribe_and_unsubscribe_to_justifications() {
- let (rpc, _) = setup_io_handler();
-
- // Subscribe call.
- let sub = rpc
- .subscribe("beefy_subscribeJustifications", EmptyParams::new())
- .await
- .unwrap();
-
- let ser_id = serde_json::to_string(sub.subscription_id()).unwrap();
-
- // Unsubscribe
- let unsub_req = format!(
- "{{\"jsonrpc\":\"2.0\",\"method\":\"beefy_unsubscribeJustifications\",\"params\":[{}],\"id\":1}}",
- ser_id
- );
- let (response, _) = rpc.raw_json_request(&unsub_req).await.unwrap();
-
- assert_eq!(response, r#"{"jsonrpc":"2.0","result":true,"id":1}"#);
-
- // Unsubscribe again and fail
- let (response, _) = rpc.raw_json_request(&unsub_req).await.unwrap();
- let expected = r#"{"jsonrpc":"2.0","result":false,"id":1}"#;
-
- assert_eq!(response, expected);
- }
-
#[tokio::test]
async fn subscribe_and_unsubscribe_with_wrong_id() {
let (rpc, _) = setup_io_handler();
diff --git a/substrate/client/finality-grandpa/rpc/src/lib.rs b/substrate/client/finality-grandpa/rpc/src/lib.rs
index bdb86c125e2..1cf23a18c79 100644
--- a/substrate/client/finality-grandpa/rpc/src/lib.rs
+++ b/substrate/client/finality-grandpa/rpc/src/lib.rs
@@ -310,33 +310,6 @@ mod tests {
assert_eq!(expected_response, result);
}
- #[tokio::test]
- async fn subscribe_and_unsubscribe_to_justifications() {
- let (rpc, _) = setup_io_handler(TestVoterState);
- // Subscribe call.
- let sub = rpc
- .subscribe("grandpa_subscribeJustifications", EmptyParams::new())
- .await
- .unwrap();
-
- let ser_id = serde_json::to_string(sub.subscription_id()).unwrap();
-
- // Unsubscribe
- let unsub_req = format!(
- "{{\"jsonrpc\":\"2.0\",\"method\":\"grandpa_unsubscribeJustifications\",\"params\":[{}],\"id\":1}}",
- ser_id
- );
- let (response, _) = rpc.raw_json_request(&unsub_req).await.unwrap();
-
- assert_eq!(response, r#"{"jsonrpc":"2.0","result":true,"id":1}"#);
-
- // Unsubscribe again and fail
- let (response, _) = rpc.raw_json_request(&unsub_req).await.unwrap();
- let expected = r#"{"jsonrpc":"2.0","result":false,"id":1}"#;
-
- assert_eq!(response, expected);
- }
-
#[tokio::test]
async fn subscribe_and_unsubscribe_with_wrong_id() {
let (rpc, _) = setup_io_handler(TestVoterState);
--
GitLab