From d656b4e0e0cf69776ee819dfe7e73cb9072f3192 Mon Sep 17 00:00:00 2001
From: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
Date: Thu, 6 Feb 2025 13:42:40 +0200
Subject: [PATCH] litep2p: Increase keep-alive to 10 seconds to mirror libp2p
(#7488)
This PR ensures that litep2p will keep an idle connection alive for 10
seconds.
The bump from 5 seconds is done to mirror the libp2p behavior and
potentially improve connection stability:
https://github.com/paritytech/polkadot-sdk/blob/a07fb323bc0cfb5c2fb4c8fbe9d20e344cc8eeaf/substrate/client/network/src/service.rs#L542-L549
cc @paritytech/networking
---------
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
---
prdoc/pr_7488.prdoc | 10 ++++++++++
substrate/client/network/src/litep2p/mod.rs | 6 ++++++
2 files changed, 16 insertions(+)
create mode 100644 prdoc/pr_7488.prdoc
diff --git a/prdoc/pr_7488.prdoc b/prdoc/pr_7488.prdoc
new file mode 100644
index 00000000000..55ce87d42d8
--- /dev/null
+++ b/prdoc/pr_7488.prdoc
@@ -0,0 +1,10 @@
+title: Increase litep2p keep-alive to 10 seconds to mirror libp2p
+
+doc:
+ - audience: [Node Dev, Node Operator]
+ description: |
+ Increase litep2p keep-alive to 10 seconds to mirror libp2p behavior.
+
+crates:
+ - name: sc-network
+ bump: patch
diff --git a/substrate/client/network/src/litep2p/mod.rs b/substrate/client/network/src/litep2p/mod.rs
index fc4cce47628..e8e132228ca 100644
--- a/substrate/client/network/src/litep2p/mod.rs
+++ b/substrate/client/network/src/litep2p/mod.rs
@@ -100,6 +100,9 @@ mod peerstore;
mod service;
mod shim;
+/// Timeout for connection waiting new substreams.
+const KEEP_ALIVE_TIMEOUT: Duration = Duration::from_secs(10);
+
/// Litep2p bandwidth sink.
struct Litep2pBandwidthSink {
sink: litep2p::BandwidthSink,
@@ -566,6 +569,9 @@ impl<B: BlockT + 'static, H: ExHashT> NetworkBackend<B, H> for Litep2pNetworkBac
.with_connection_limits(ConnectionLimitsConfig::default().max_incoming_connections(
Some(crate::MAX_CONNECTIONS_ESTABLISHED_INCOMING as usize),
))
+ // This has the same effect as `libp2p::Swarm::with_idle_connection_timeout` which is
+ // set to 10 seconds as well.
+ .with_keep_alive_timeout(KEEP_ALIVE_TIMEOUT)
.with_executor(executor);
if let Some(config) = maybe_mdns_config {
--
GitLab