diff --git a/substrate/bin/node/runtime/src/lib.rs b/substrate/bin/node/runtime/src/lib.rs index e91eca4e400cd78ac10953490d5d9fc1ed2dcef3..980f033024d6a32b567ec22ea226244626c65fbc 100644 --- a/substrate/bin/node/runtime/src/lib.rs +++ b/substrate/bin/node/runtime/src/lib.rs @@ -82,7 +82,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { // implementation changes and behavior does not, then leave spec_version as // is and increment impl_version. spec_version: 225, - impl_version: 0, + impl_version: 1, apis: RUNTIME_API_VERSIONS, }; @@ -819,7 +819,7 @@ impl_runtime_apis! { fn dispatch_benchmark( module: Vec<u8>, extrinsic: Vec<u8>, - steps: u32, + steps: Vec<u32>, repeat: u32, ) -> Option<Vec<frame_benchmarking::BenchmarkResults>> { use frame_benchmarking::Benchmarking; diff --git a/substrate/frame/benchmarking/src/lib.rs b/substrate/frame/benchmarking/src/lib.rs index 3ad4a9a8a0736b94b10b2ffc403e35910184392e..e6b6a4f3f59eca79f0d6f428897e6645bbc31383 100644 --- a/substrate/frame/benchmarking/src/lib.rs +++ b/substrate/frame/benchmarking/src/lib.rs @@ -140,7 +140,7 @@ macro_rules! impl_benchmark { $( $name:ident ),* ) => { impl<T: Trait> $crate::Benchmarking<$crate::BenchmarkResults> for Module<T> { - fn run_benchmark(extrinsic: Vec<u8>, steps: u32, repeat: u32) -> Result<Vec<$crate::BenchmarkResults>, &'static str> { + fn run_benchmark(extrinsic: Vec<u8>, steps: Vec<u32>, repeat: u32) -> Result<Vec<$crate::BenchmarkResults>, &'static str> { // Map the input to the selected benchmark. let extrinsic = sp_std::str::from_utf8(extrinsic.as_slice()) .map_err(|_| "Could not find extrinsic")?; @@ -153,15 +153,21 @@ macro_rules! impl_benchmark { $crate::benchmarking::commit_db(); $crate::benchmarking::wipe_db(); - // first one is set_identity. let components = <SelectedBenchmark as $crate::BenchmarkingSetup<T, crate::Call<T>, RawOrigin<T::AccountId>>>::components(&selected_benchmark); - // results go here let mut results: Vec<$crate::BenchmarkResults> = Vec::new(); + + // Default number of steps for a component. + let mut prev_steps = &10; + // Select the component we will be benchmarking. Each component will be benchmarked. - for (name, low, high) in components.iter() { + for (idx, (name, low, high)) in components.iter().enumerate() { + // Get the number of steps for this component. + let steps = steps.get(idx).unwrap_or(&prev_steps); + prev_steps = steps; + // Create up to `STEPS` steps for that component between high and low. let step_size = ((high - low) / steps).max(1); - let num_of_steps = (high - low) / step_size; + let num_of_steps = (high - low) / step_size + 1; for s in 0..num_of_steps { // This is the value we will be testing for component `name` let component_value = low + step_size * s; @@ -169,7 +175,7 @@ macro_rules! impl_benchmark { // Select the mid value for all the other components. let c: Vec<($crate::BenchmarkParameter, u32)> = components.iter() .map(|(n, l, h)| - (*n, if n == name { component_value } else { (h - l) / 2 + l }) + (*n, if n == name { component_value } else { *h }) ).collect(); // Run the benchmark `repeat` times. diff --git a/substrate/frame/benchmarking/src/utils.rs b/substrate/frame/benchmarking/src/utils.rs index 5a67ea6943181edbbf7087622007f6ac05c5fd64..9db981a61c84133576e6ae2fcab9244d2c95ebdc 100644 --- a/substrate/frame/benchmarking/src/utils.rs +++ b/substrate/frame/benchmarking/src/utils.rs @@ -40,7 +40,7 @@ sp_api::decl_runtime_apis! { fn dispatch_benchmark( module: Vec<u8>, extrinsic: Vec<u8>, - steps: u32, + steps: Vec<u32>, repeat: u32, ) -> Option<Vec<BenchmarkResults>>; } @@ -78,7 +78,7 @@ pub trait Benchmarking<T> { /// - `extrinsic`: The name of extrinsic function you want to benchmark encoded as bytes. /// - `steps`: The number of sample points you want to take across the range of parameters. /// - `repeat`: The number of times you want to repeat a benchmark. - fn run_benchmark(extrinsic: Vec<u8>, steps: u32, repeat: u32) -> Result<Vec<T>, &'static str>; + fn run_benchmark(extrinsic: Vec<u8>, steps: Vec<u32>, repeat: u32) -> Result<Vec<T>, &'static str>; } /// The required setup for creating a benchmark. diff --git a/substrate/utils/frame/benchmarking-cli/src/lib.rs b/substrate/utils/frame/benchmarking-cli/src/lib.rs index 816ce5213108191ae29f8168aef1013403061612..b2f360e584e870970534f66058268350d0faa63a 100644 --- a/substrate/utils/frame/benchmarking-cli/src/lib.rs +++ b/substrate/utils/frame/benchmarking-cli/src/lib.rs @@ -36,8 +36,8 @@ pub struct BenchmarkCmd { pub extrinsic: String, /// Select how many samples we should take across the variable components. - #[structopt(short, long, default_value = "1")] - pub steps: u32, + #[structopt(short, long, use_delimiter = true)] + pub steps: Vec<u32>, /// Select how many repetitions of this benchmark should run. #[structopt(short, long, default_value = "1")] @@ -97,13 +97,14 @@ impl BenchmarkCmd { wasm_method, None, // heap pages ); + let result = StateMachine::<_, _, NumberFor<BB>, _>::new( &state, None, &mut changes, &executor, "Benchmark_dispatch_benchmark", - &(&self.pallet, &self.extrinsic, self.steps, self.repeat).encode(), + &(&self.pallet, &self.extrinsic, self.steps.clone(), self.repeat).encode(), Default::default(), ) .execute(strategy.into())