From cbae45a27d36d5f68ce302a6af081980300415e3 Mon Sep 17 00:00:00 2001
From: WMQ <46511820+wangminqi@users.noreply.github.com>
Date: Tue, 25 Jan 2022 19:50:00 +0800
Subject: [PATCH] fix: remove duplicate event of pallet_balances (#933)
* fix: remove duplicate event of pallet_balances
https://github.com/paritytech/substrate/blob/master/frame/support/src/traits/tokens/currency.rs#L158
https://github.com/paritytech/substrate/blob/master/frame/balances/src/lib.rs#L1647
Since 0.9.12 of substrate, there is no need for a separate of balances event in runtime.
* Update impls.rs
---
cumulus/polkadot-parachains/parachains-common/src/impls.rs | 5 -----
1 file changed, 5 deletions(-)
diff --git a/cumulus/polkadot-parachains/parachains-common/src/impls.rs b/cumulus/polkadot-parachains/parachains-common/src/impls.rs
index f6afb1a9b33..b5919f736c9 100644
--- a/cumulus/polkadot-parachains/parachains-common/src/impls.rs
+++ b/cumulus/polkadot-parachains/parachains-common/src/impls.rs
@@ -44,13 +44,8 @@ where
<R as frame_system::Config>::Event: From<pallet_balances::Event<R>>,
{
fn on_nonzero_unbalanced(amount: NegativeImbalance<R>) {
- let numeric_amount = amount.peek();
let staking_pot = <pallet_collator_selection::Pallet<R>>::account_id();
<pallet_balances::Pallet<R>>::resolve_creating(&staking_pot, amount);
- <frame_system::Pallet<R>>::deposit_event(pallet_balances::Event::Deposit {
- who: staking_pot,
- amount: numeric_amount,
- });
}
}
--
GitLab