From ca779b36da50205f3b2af9f3f619ed031cb2bdfe Mon Sep 17 00:00:00 2001
From: Mrisho Lukamba <69342343+MrishoLukamba@users.noreply.github.com>
Date: Fri, 28 Oct 2022 15:16:18 +0300
Subject: [PATCH] replaced println with log Closes #12338 (#12348)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* replaced println with log Closes #12338
* fixed println
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <git@kchr.de>
* Update utils/frame/benchmarking-cli/src/pallet/command.rs
* Apply suggestions from code review
* ".git/.scripts/fmt.sh" 1
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: command-bot <>
---
.../frame/benchmarking-cli/src/pallet/command.rs | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/substrate/utils/frame/benchmarking-cli/src/pallet/command.rs b/substrate/utils/frame/benchmarking-cli/src/pallet/command.rs
index 6e413bdf7e2..242f0e68529 100644
--- a/substrate/utils/frame/benchmarking-cli/src/pallet/command.rs
+++ b/substrate/utils/frame/benchmarking-cli/src/pallet/command.rs
@@ -40,6 +40,9 @@ use sp_runtime::traits::{Block as BlockT, Header as HeaderT};
use sp_state_machine::StateMachine;
use std::{collections::HashMap, fmt::Debug, fs, sync::Arc, time};
+/// Logging target
+const LOG_TARGET: &'static str = "frame::benchmark::pallet";
+
/// The inclusive range of a component.
#[derive(Serialize, Debug, Clone, Eq, PartialEq)]
pub(crate) struct ComponentRange {
@@ -242,7 +245,8 @@ impl PalletCmd {
let mut component_ranges = HashMap::<(Vec<u8>, Vec<u8>), Vec<ComponentRange>>::new();
for (pallet, extrinsic, components) in benchmarks_to_run {
- println!(
+ log::info!(
+ target: LOG_TARGET,
"Starting benchmark: {}::{}",
String::from_utf8(pallet.clone()).expect("Encoded from String; qed"),
String::from_utf8(extrinsic.clone()).expect("Encoded from String; qed"),
@@ -402,7 +406,9 @@ impl PalletCmd {
if let Ok(elapsed) = timer.elapsed() {
if elapsed >= time::Duration::from_secs(5) {
timer = time::SystemTime::now();
- println!(
+
+ log::info!(
+ target: LOG_TARGET,
"Running Benchmark: {}.{}({} args) {}/{} {}/{}",
String::from_utf8(pallet.clone())
.expect("Encoded from String; qed"),
@@ -492,7 +498,7 @@ impl PalletCmd {
if let Some(path) = &self.json_file {
fs::write(path, json)?;
} else {
- println!("{}", json);
+ print!("{json}");
return Ok(true)
}
}
--
GitLab