From c6a9b81fadedcda1943aca1c48554b6a77252042 Mon Sep 17 00:00:00 2001
From: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Date: Fri, 24 Mar 2023 16:09:34 +0100
Subject: [PATCH] try-runtime: run migration checks per default (#13684)
* try-runtime: run migration checks per default
The current behaviour of having to explicetly specify --checks seems
to cause confusion. Therefore bringing back the old behaviour of
running the pre- and post-upgrade checks per default.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
* Fix docs
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
---------
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
---
.../try-runtime/cli/src/commands/on_runtime_upgrade.rs | 4 ++--
substrate/utils/frame/try-runtime/cli/src/lib.rs | 10 +++++-----
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/substrate/utils/frame/try-runtime/cli/src/commands/on_runtime_upgrade.rs b/substrate/utils/frame/try-runtime/cli/src/commands/on_runtime_upgrade.rs
index c8582ea4d2a..948ff9c030e 100644
--- a/substrate/utils/frame/try-runtime/cli/src/commands/on_runtime_upgrade.rs
+++ b/substrate/utils/frame/try-runtime/cli/src/commands/on_runtime_upgrade.rs
@@ -40,8 +40,8 @@ pub struct OnRuntimeUpgradeCmd {
/// Performing any checks will potentially invalidate the measured PoV/Weight.
// NOTE: The clap attributes make it backwards compatible with the previous `--checks` flag.
#[clap(long,
- default_value = "None",
- default_missing_value = "All",
+ default_value = "pre-and-post",
+ default_missing_value = "all",
num_args = 0..=1,
require_equals = true,
verbatim_doc_comment)]
diff --git a/substrate/utils/frame/try-runtime/cli/src/lib.rs b/substrate/utils/frame/try-runtime/cli/src/lib.rs
index 0a521d12155..bc9fd99d3e6 100644
--- a/substrate/utils/frame/try-runtime/cli/src/lib.rs
+++ b/substrate/utils/frame/try-runtime/cli/src/lib.rs
@@ -134,10 +134,10 @@
//!
//! ```ignore
//!
-//! #[cfg(feature = try-runtime)]
+//! #[cfg(feature = "try-runtime")]
//! fn pre_upgrade() -> Result<Vec<u8>, &'static str> {}
//!
-//! #[cfg(feature = try-runtime)]
+//! #[cfg(feature = "try-runtime")]
//! fn post_upgrade(state: Vec<u8>) -> Result<(), &'static str> {}
//! ```
//!
@@ -152,9 +152,9 @@
//!
//! Similarly, each pallet can expose a function in `#[pallet::hooks]` section as follows:
//!
-//! ```
-//! #[cfg(feature = try-runtime)]
-//! fn try_state(_) -> Result<(), &'static str> {}
+//! ```ignore
+//! #[cfg(feature = "try-runtime")]
+//! fn try_state(_: BlockNumber) -> Result<(), &'static str> {}
//! ```
//!
//! which is called on numerous code paths in the try-runtime tool. These checks should ensure that
--
GitLab