From a5780527041e39268fc8b05b0f3d098cde204883 Mon Sep 17 00:00:00 2001
From: Iulian Barbu <14218860+iulianbarbu@users.noreply.github.com>
Date: Tue, 7 Jan 2025 17:25:16 +0200
Subject: [PATCH] release: unset SKIP_WASM_BUILD (#7074)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
# Description
Seems like I added `SKIP_WASM_BUILD=1` 💀 for arch64 binaries, which
results in various errors like:
https://github.com/paritytech/polkadot-sdk/issues/6966. This PR unsets
the variable.
Closes #6966.
## Integration
People who found workarounds as in #6966 can consume the fixed binaries
again.
## Review Notes
I introduced SKIP_WASM_BUILD=1 for some reason for aarch64 (probably to
speed up testing) and forgot to remove it. It slipped through and
interfered with `stable2412` release artifacts. Needs backporting to
`stable2412` and then rebuilding/overwriting the aarch64 artifacts.
---------
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
---
.github/workflows/release-reusable-rc-buid.yml | 1 -
prdoc/pr_7074.prdoc | 13 +++++++++++++
2 files changed, 13 insertions(+), 1 deletion(-)
create mode 100644 prdoc/pr_7074.prdoc
diff --git a/.github/workflows/release-reusable-rc-buid.yml b/.github/workflows/release-reusable-rc-buid.yml
index 0222b2aa91e..035b547603e 100644
--- a/.github/workflows/release-reusable-rc-buid.yml
+++ b/.github/workflows/release-reusable-rc-buid.yml
@@ -149,7 +149,6 @@ jobs:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_DEFAULT_REGION: ${{ secrets.AWS_DEFAULT_REGION }}
- SKIP_WASM_BUILD: 1
steps:
- name: Checkout sources
uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
diff --git a/prdoc/pr_7074.prdoc b/prdoc/pr_7074.prdoc
new file mode 100644
index 00000000000..d49e5f8d831
--- /dev/null
+++ b/prdoc/pr_7074.prdoc
@@ -0,0 +1,13 @@
+# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0
+# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json
+
+title: Unset SKIP_WASM_BUILD=1 for aarch64 binaries release
+
+doc:
+ - audience: [ Node Dev, Runtime Dev]
+ description:
+ Fix the release pipeline environment by unsetting SKIP_WASM_BUILD=1
+ so that aarch64 binaries are built so that they contain runtimes
+ accordingly.
+
+crates: [ ]
--
GitLab