From 9bbf8efd02d5ba25f039719450a79c90d51c1b5e Mon Sep 17 00:00:00 2001
From: Liu-Cheng Xu <xuliuchengxlc@gmail.com>
Date: Thu, 1 Sep 2022 04:31:05 +0800
Subject: [PATCH] Only log when the transaction is actually to be propagated
(#12158)
The logging before is confusing as it says Propagating but it's not in fact when gossip_enabled is
false. Now it's also consistent with `propagate_transactions` below.
---
substrate/client/network/src/transactions.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/substrate/client/network/src/transactions.rs b/substrate/client/network/src/transactions.rs
index f7e4d774ca8..f557ec0cec7 100644
--- a/substrate/client/network/src/transactions.rs
+++ b/substrate/client/network/src/transactions.rs
@@ -425,11 +425,11 @@ impl<B: BlockT + 'static, H: ExHashT> TransactionsHandler<B, H> {
/// Propagate one transaction.
pub fn propagate_transaction(&mut self, hash: &H) {
- debug!(target: "sync", "Propagating transaction [{:?}]", hash);
// Accept transactions only when enabled
if !self.gossip_enabled.load(Ordering::Relaxed) {
return
}
+ debug!(target: "sync", "Propagating transaction [{:?}]", hash);
if let Some(transaction) = self.transaction_pool.transaction(hash) {
let propagated_to = self.do_propagate_transactions(&[(hash.clone(), transaction)]);
self.transaction_pool.on_broadcasted(propagated_to);
--
GitLab