From 8216235b480630c5a69636b172f5146711c88c9a Mon Sep 17 00:00:00 2001
From: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
Date: Tue, 26 Nov 2024 10:58:48 +0200
Subject: [PATCH] ci/check-semver: Fix semver failed step (#6535)
The semver-check is failing with the following
[error](https://github.com/paritytech/polkadot-sdk/actions/runs/11908981132/job/33185572284):
```bash
error[E0658]: use of unstable library feature 'error_in_core'
--> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-decode-0.5.0/src/decoding/extrinsic_decoder.rs:56:6
|
56 | impl core::error::Error for ExtrinsicDecodeError {}
| ^^^^^^^^^^^^^^^^^^
|
= note: see issue #103765 <https://github.com/rust-lang/rust/issues/103765> for more information
= help: add `#![feature(error_in_core)]` to the crate attributes to enable
= note: this compiler was built on 2024-05-31; consider upgrading it if it is out of date
```
This is related to the toolchain nightly version 1.80. In rust, 1.81 the
`core::error::Error` is stable.
After updating the rust-toolchain, parity-publish crate must be updated
as well.
The `cargo-semver-checks` dependency of `parity-publish` crate is
updated from 0.34 to 0.38.
This update enables rustdoc v36 that fixes the following
[issue](https://github.com/paritytech/polkadot-sdk/actions/runs/11912689841/job/33196936011):
```bash
validating prdocs...
checking file changes...
checking semver changes...
(1/18) building frame-support-HEAD...
(2/18) building frame-support-28.0.0...
Error: rustdoc format v36 for file /__w/polkadot-sdk/polkadot-sdk/target/doc/frame_support.new is not supported
```
This PR is pending on a release of parity-publish to version 0.9.0
(fixes already on origin/master)
---------
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
---
.github/workflows/check-semver.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/check-semver.yml b/.github/workflows/check-semver.yml
index 78602410cdf..8d77b6a31b7 100644
--- a/.github/workflows/check-semver.yml
+++ b/.github/workflows/check-semver.yml
@@ -11,7 +11,7 @@ concurrency:
cancel-in-progress: true
env:
- TOOLCHAIN: nightly-2024-06-01
+ TOOLCHAIN: nightly-2024-10-19
jobs:
preflight:
@@ -74,7 +74,7 @@ jobs:
- name: install parity-publish
# Set the target dir to cache the build.
- run: CARGO_TARGET_DIR=./target/ cargo install parity-publish@0.8.0 --locked -q
+ run: CARGO_TARGET_DIR=./target/ cargo install parity-publish@0.10.1 --locked -q
- name: check semver
run: |
--
GitLab