From 7d228d9bff23eb442d1e08f6d0a775373a167f32 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alexander=20Thei=C3=9Fen?= <alex.theissen@me.com>
Date: Mon, 2 Sep 2024 18:19:51 +0200
Subject: [PATCH] Update CODEOWNERS and review-bot for new contracts pallet
(#5549)
Created a new @paritytech/smart-contracts team that is now referenced in
the review bot config and CODEOWNERS file. Also excluded the new pallet
in the other review bot rules.
---
.github/CODEOWNERS | 4 ++--
.github/review-bot.yml | 15 +++++++++++++--
2 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index 34335822121..d13add97d41 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -64,8 +64,8 @@
/substrate/primitives/merkle-mountain-range/ @acatangiu
# Contracts
-/substrate/frame/contracts/ @athei @pgherveou @paritytech/docs-audit
-/substrate/frame/revive/ @athei @pgherveou @paritytech/docs-audit
+/substrate/frame/contracts/ @paritytech/smart-contracts @paritytech/docs-audit
+/substrate/frame/revive/ @paritytech/smart-contracts @paritytech/docs-audit
# NPoS and election
/substrate/frame/election-provider-multi-phase/ @paritytech/staking-core @paritytech/docs-audit
diff --git a/.github/review-bot.yml b/.github/review-bot.yml
index adbc480c6ba..c2080142f50 100644
--- a/.github/review-bot.yml
+++ b/.github/review-bot.yml
@@ -29,7 +29,7 @@ rules:
# excluding files from 'Runtime files' and 'CI files' rules
exclude:
- ^cumulus/parachains/common/src/[^/]+\.rs$
- - ^substrate/frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*|aura/.*))
+ - ^substrate/frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|revive/.*|election|nomination-pools/.*|staking/.*|aura/.*))
- ^\.gitlab-ci\.yml
- ^docker/.*
- ^\.github/.*
@@ -56,7 +56,7 @@ rules:
- name: FRAME coders substrate
condition:
include:
- - ^substrate/frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*|aura/.*))
+ - ^substrate/frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|revive/.*|election|nomination-pools/.*|staking/.*|aura/.*))
type: "and"
reviewers:
- minApprovals: 2
@@ -66,6 +66,17 @@ rules:
teams:
- frame-coders
+ # Smart Contracts
+ - name: Smart Contracts
+ type: basic
+ condition:
+ include:
+ - ^substrate/frame/contracts/.*
+ - ^substrate/frame/revive/.*
+ minApprovals: 2
+ teams:
+ - smart-contracts
+
# Protection of THIS file
- name: Review Bot
countAuthor: true
--
GitLab