From 767af862d9d2ccdf30440fced1968e3eb34d421b Mon Sep 17 00:00:00 2001
From: Liam Aharon <liam.aharon@hotmail.com>
Date: Fri, 12 Apr 2024 16:43:40 +0400
Subject: [PATCH] address comment
---
substrate/frame/asset-rewards/src/lib.rs | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/substrate/frame/asset-rewards/src/lib.rs b/substrate/frame/asset-rewards/src/lib.rs
index 18e8a852acf..49bf75c3fd5 100644
--- a/substrate/frame/asset-rewards/src/lib.rs
+++ b/substrate/frame/asset-rewards/src/lib.rs
@@ -551,11 +551,12 @@ pub mod pallet {
Error::<T>::ExpiryBlockMustBeInTheFuture
);
- // Always start by updating the pool rewards.
let pool_info = Pools::<T>::get(pool_id).ok_or(Error::<T>::NonExistentPool)?;
+ ensure!(pool_info.admin == caller, BadOrigin);
+
+ // Always start by updating the pool rewards.
let mut pool_info = Self::update_pool_rewards(pool_info)?;
- ensure!(pool_info.admin == caller, BadOrigin);
pool_info.expiry_block = new_expiry_block;
Pools::<T>::insert(pool_id, pool_info);
--
GitLab