From 724350418e29dce0a1ec5eb167bce77ba0107eae Mon Sep 17 00:00:00 2001
From: Pierre Krieger <pierre.krieger1708@gmail.com>
Date: Tue, 19 Oct 2021 13:56:09 +0200
Subject: [PATCH] Don't print "Discovered new external" line for private IPs
(#10055)
---
substrate/client/network/src/discovery.rs | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/substrate/client/network/src/discovery.rs b/substrate/client/network/src/discovery.rs
index 1ed08cd671d..2a4b25a621e 100644
--- a/substrate/client/network/src/discovery.rs
+++ b/substrate/client/network/src/discovery.rs
@@ -599,14 +599,16 @@ impl NetworkBehaviour for DiscoveryBehaviour {
fn inject_new_external_addr(&mut self, addr: &Multiaddr) {
let new_addr = addr.clone().with(Protocol::P2p(self.local_peer_id.into()));
- // NOTE: we might re-discover the same address multiple times
- // in which case we just want to refrain from logging.
- if self.known_external_addresses.insert(new_addr.clone()) {
- info!(
- target: "sub-libp2p",
- "🔠Discovered new external address for our node: {}",
- new_addr,
- );
+ if self.can_add_to_dht(addr) {
+ // NOTE: we might re-discover the same address multiple times
+ // in which case we just want to refrain from logging.
+ if self.known_external_addresses.insert(new_addr.clone()) {
+ info!(
+ target: "sub-libp2p",
+ "🔠Discovered new external address for our node: {}",
+ new_addr,
+ );
+ }
}
for k in self.kademlias.values_mut() {
--
GitLab