From 4cd7e8650b480e371ee2077f50cc7fbfb13a5f6f Mon Sep 17 00:00:00 2001
From: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Date: Wed, 16 Oct 2024 18:27:45 +0200
Subject: [PATCH] [ci] Small updates (#6085)
PR adds timeouts to some jobs, fixes `node-bench-regression-guard` so it
works on master.
cc https://github.com/paritytech/ci_cd/issues/1063
---
.github/workflows/check-cargo-check-runtimes.yml | 1 -
.github/workflows/check-labels.yml | 1 +
.github/workflows/check-links.yml | 1 +
.github/workflows/check-prdoc.yml | 1 +
.github/workflows/check-semver.yml | 1 +
.github/workflows/command-backport.yml | 6 +++---
.github/workflows/docs.yml | 2 ++
.github/workflows/fork-sync-action.yml | 16 ++++++++--------
.github/workflows/tests-misc.yml | 7 ++++++-
9 files changed, 23 insertions(+), 13 deletions(-)
diff --git a/.github/workflows/check-cargo-check-runtimes.yml b/.github/workflows/check-cargo-check-runtimes.yml
index b49a2cbbfd3..376c34d1f25 100644
--- a/.github/workflows/check-cargo-check-runtimes.yml
+++ b/.github/workflows/check-cargo-check-runtimes.yml
@@ -110,7 +110,6 @@ jobs:
- check-runtime-coretime
- check-runtime-bridge-hubs
- check-runtime-contracts
- - check-runtime-starters
- check-runtime-testing
if: always() && !cancelled()
steps:
diff --git a/.github/workflows/check-labels.yml b/.github/workflows/check-labels.yml
index 6ec35840608..d5c91e7f55e 100644
--- a/.github/workflows/check-labels.yml
+++ b/.github/workflows/check-labels.yml
@@ -12,6 +12,7 @@ on:
jobs:
check-labels:
runs-on: ubuntu-latest
+ timeout-minutes: 10
steps:
- name: Check labels
env:
diff --git a/.github/workflows/check-links.yml b/.github/workflows/check-links.yml
index 0ebd33d417a..baf8cd5b155 100644
--- a/.github/workflows/check-links.yml
+++ b/.github/workflows/check-links.yml
@@ -20,6 +20,7 @@ permissions:
jobs:
link-checker:
runs-on: ubuntu-latest
+ timeout-minutes: 10
steps:
- name: Restore lychee cache
uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v3.3.2 (7. Sep 2023)
diff --git a/.github/workflows/check-prdoc.yml b/.github/workflows/check-prdoc.yml
index fc282477022..8af1dd8cef7 100644
--- a/.github/workflows/check-prdoc.yml
+++ b/.github/workflows/check-prdoc.yml
@@ -21,6 +21,7 @@ env:
jobs:
check-prdoc:
runs-on: ubuntu-latest
+ timeout-minutes: 10
if: github.event.pull_request.number != ''
steps:
- name: Checkout repo
diff --git a/.github/workflows/check-semver.yml b/.github/workflows/check-semver.yml
index 811ec4d5558..24050d9e098 100644
--- a/.github/workflows/check-semver.yml
+++ b/.github/workflows/check-semver.yml
@@ -17,6 +17,7 @@ jobs:
uses: ./.github/workflows/reusable-preflight.yml
check-semver:
runs-on: ubuntu-latest
+ timeout-minutes: 90
needs: [preflight]
container:
image: ${{ needs.preflight.outputs.IMAGE }}
diff --git a/.github/workflows/command-backport.yml b/.github/workflows/command-backport.yml
index 7f1d59bc0f6..8f23bcd75f0 100644
--- a/.github/workflows/command-backport.yml
+++ b/.github/workflows/command-backport.yml
@@ -4,7 +4,7 @@ on:
# This trigger can be problematic, see: https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/
# In our case it is fine since we only run it on merged Pull Requests and do not execute any of the repo code itself.
pull_request_target:
- types: [ closed, labeled ]
+ types: [closed, labeled]
permissions:
contents: write # so it can comment
@@ -66,7 +66,7 @@ jobs:
with:
script: |
const pullNumbers = '${{ steps.backport.outputs.created_pull_numbers }}'.split(' ');
-
+
for (const pullNumber of pullNumbers) {
await github.rest.issues.addLabels({
issue_number: parseInt(pullNumber),
@@ -84,7 +84,7 @@ jobs:
script: |
const pullNumbers = '${{ steps.backport.outputs.created_pull_numbers }}'.split(' ');
const reviewer = '${{ github.event.pull_request.user.login }}';
-
+
for (const pullNumber of pullNumbers) {
await github.pulls.createReviewRequest({
owner: context.repo.owner,
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index 610f45fa386..a257c822959 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -18,6 +18,7 @@ jobs:
test-doc:
runs-on: ${{ needs.preflight.outputs.RUNNER }}
+ timeout-minutes: 60
needs: [preflight]
container:
image: ${{ needs.preflight.outputs.IMAGE }}
@@ -29,6 +30,7 @@ jobs:
build-rustdoc:
runs-on: ${{ needs.preflight.outputs.RUNNER }}
+ timeout-minutes: 40
if: ${{ needs.preflight.outputs.changes_rust }}
needs: [preflight]
container:
diff --git a/.github/workflows/fork-sync-action.yml b/.github/workflows/fork-sync-action.yml
index 69e9e93bf54..065226764be 100644
--- a/.github/workflows/fork-sync-action.yml
+++ b/.github/workflows/fork-sync-action.yml
@@ -1,5 +1,5 @@
# This Workflow is not supposed to run in the paritytech/polkadot-sdk repo.
-# This Workflow is supposed to run only in the forks of the repo,
+# This Workflow is supposed to run only in the forks of the repo,
# paritytech-release/polkadot-sdk specifically,
# to automatically maintain the critical fork synced with the upstream.
# This Workflow should be always disabled in the paritytech/polkadot-sdk repo.
@@ -11,10 +11,10 @@ on:
workflow_dispatch:
jobs:
- job_sync_branches:
- uses: paritytech-release/sync-workflows/.github/workflows/sync-with-upstream.yml@latest
- with:
- fork_writer_app_id: ${{ vars.UPSTREAM_CONTENT_SYNC_APP_ID}}
- fork_owner: ${{ vars.RELEASE_ORG}}
- secrets:
- fork_writer_app_key: ${{ secrets.UPSTREAM_CONTENT_SYNC_APP_KEY }}
+ job_sync_branches:
+ uses: paritytech-release/sync-workflows/.github/workflows/sync-with-upstream.yml@latest
+ with:
+ fork_writer_app_id: ${{ vars.UPSTREAM_CONTENT_SYNC_APP_ID}}
+ fork_owner: ${{ vars.RELEASE_ORG}}
+ secrets:
+ fork_writer_app_key: ${{ secrets.UPSTREAM_CONTENT_SYNC_APP_KEY }}
diff --git a/.github/workflows/tests-misc.yml b/.github/workflows/tests-misc.yml
index 4355cd0a9f8..b51f2c249d8 100644
--- a/.github/workflows/tests-misc.yml
+++ b/.github/workflows/tests-misc.yml
@@ -178,6 +178,11 @@ jobs:
- name: script
id: compare
run: |
+ if [ "${{ github.ref_name }}" = "master" ]; then
+ echo -e "Exiting on master branch"
+ exit 0
+ fi
+
docker run --rm \
-v $PWD/artifacts/master:/artifacts/master \
-v $PWD/artifacts/current:/artifacts/current \
@@ -299,7 +304,7 @@ jobs:
# name: hfuzz-${{ github.sha }}
cargo-check-each-crate:
- timeout-minutes: 140
+ timeout-minutes: 70
needs: [preflight]
runs-on: ${{ needs.preflight.outputs.RUNNER }}
if: ${{ needs.preflight.outputs.changes_rust }}
--
GitLab