From 3e2783f80a6ebbb4f0ac8d6f2236281979166829 Mon Sep 17 00:00:00 2001
From: Alexandru Gheorghe <49718502+alexggh@users.noreply.github.com>
Date: Mon, 13 Jan 2025 18:38:52 +0200
Subject: [PATCH] Increase the number of pvf execute workers (#7116)
Reference hardware requirements have been bumped to at least 8 cores so
we can no allocate 50% of that capacity to PVF execution.
---------
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
(cherry picked from commit f0eec07f93759331e6520ccc67f3d3291f0122c4)
---
polkadot/node/service/src/lib.rs | 11 +++--------
prdoc/pr_7116.prdoc | 8 ++++++++
2 files changed, 11 insertions(+), 8 deletions(-)
create mode 100644 prdoc/pr_7116.prdoc
diff --git a/polkadot/node/service/src/lib.rs b/polkadot/node/service/src/lib.rs
index b4f63bd2aa0..7eaf7217b7c 100644
--- a/polkadot/node/service/src/lib.rs
+++ b/polkadot/node/service/src/lib.rs
@@ -968,14 +968,9 @@ pub fn new_full<
secure_validator_mode,
prep_worker_path,
exec_worker_path,
- pvf_execute_workers_max_num: execute_workers_max_num.unwrap_or_else(
- || match config.chain_spec.identify_chain() {
- // The intention is to use this logic for gradual increasing from 2 to 4
- // of this configuration chain by chain until it reaches production chain.
- Chain::Polkadot | Chain::Kusama => 2,
- Chain::Rococo | Chain::Westend | Chain::Unknown => 4,
- },
- ),
+ // Default execution workers is 4 because we have 8 cores on the reference hardware,
+ // and this accounts for 50% of that cpu capacity.
+ pvf_execute_workers_max_num: execute_workers_max_num.unwrap_or(4),
pvf_prepare_workers_soft_max_num: prepare_workers_soft_max_num.unwrap_or(1),
pvf_prepare_workers_hard_max_num: prepare_workers_hard_max_num.unwrap_or(2),
})
diff --git a/prdoc/pr_7116.prdoc b/prdoc/pr_7116.prdoc
new file mode 100644
index 00000000000..95a5254778a
--- /dev/null
+++ b/prdoc/pr_7116.prdoc
@@ -0,0 +1,8 @@
+title: Increase the number of pvf execution workers from 2 to 4
+doc:
+- audience: Node Dev
+ description: |-
+ Increase the number of pvf execution workers from 2 to 4.
+crates:
+- name: polkadot-service
+ bump: patch
--
GitLab