From 39daa61eb3a0c7395f96cad5c0a30c4cfc2ecfe9 Mon Sep 17 00:00:00 2001
From: Guillaume Thiolliere <gui.thiolliere@gmail.com>
Date: Wed, 31 Jul 2024 17:45:04 +0900
Subject: [PATCH] Run UI tests in CI for some other crates (#5167)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The test name is `test-frame-ui` I don't know if I can also change it to
`test-ui` without breaking other stuff. So I kept the name unchanged.
---------
Co-authored-by: Bastian Köcher <git@kchr.de>
---
.gitlab/pipeline/test.yml | 5 +++++
Cargo.toml | 2 +-
polkadot/xcm/procedural/Cargo.toml | 4 +++-
scripts/update-ui-tests.sh | 1 +
.../frame/election-provider-support/solution-type/Cargo.toml | 4 +++-
5 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/.gitlab/pipeline/test.yml b/.gitlab/pipeline/test.yml
index d171a8a1942..0103c6b76a2 100644
--- a/.gitlab/pipeline/test.yml
+++ b/.gitlab/pipeline/test.yml
@@ -398,6 +398,11 @@ test-frame-ui:
script:
- time cargo test --locked -q --profile testnet -p frame-support-test --features=frame-feature-testing,no-metadata-docs,try-runtime,experimental
- time cargo test --locked -q --profile testnet -p frame-support-test --features=frame-feature-testing,frame-feature-testing-2,no-metadata-docs,try-runtime,experimental
+ - time cargo test --locked -q --profile testnet -p xcm-procedural
+ - time cargo test --locked -q --profile testnet -p frame-election-provider-solution-type
+ - time cargo test --locked -q --profile testnet -p sp-api-test
+ # There is multiple version of sp-runtime-interface in the repo. So we point to the manifest.
+ - time cargo test --locked -q --profile testnet --manifest-path substrate/primitives/runtime-interface/Cargo.toml
- cat /cargo_target_dir/debug/.fingerprint/memory_units-759eddf317490d2b/lib-memory_units.json || true
# This job runs all benchmarks defined in the `/bin/node/runtime` once to check that there are no errors.
diff --git a/Cargo.toml b/Cargo.toml
index 38ef9075a73..703e1ebbcf6 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1323,7 +1323,7 @@ trie-bench = { version = "0.39.0" }
trie-db = { version = "0.29.0", default-features = false }
trie-root = { version = "0.18.0", default-features = false }
trie-standardmap = { version = "0.16.0" }
-trybuild = { version = "1.0.88" }
+trybuild = { version = "1.0.89" }
tt-call = { version = "1.0.8" }
tuplex = { version = "0.1", default-features = false }
twox-hash = { version = "1.6.3", default-features = false }
diff --git a/polkadot/xcm/procedural/Cargo.toml b/polkadot/xcm/procedural/Cargo.toml
index a7db183bcdb..83b35d19cf7 100644
--- a/polkadot/xcm/procedural/Cargo.toml
+++ b/polkadot/xcm/procedural/Cargo.toml
@@ -21,4 +21,6 @@ Inflector = { workspace = true }
[dev-dependencies]
trybuild = { features = ["diff"], workspace = true }
-xcm = { workspace = true, default-features = true }
+# NOTE: we have to explicitly specify `std` because of trybuild
+# https://github.com/paritytech/polkadot-sdk/pull/5167
+xcm = { workspace = true, default-features = true, features = ["std"] }
diff --git a/scripts/update-ui-tests.sh b/scripts/update-ui-tests.sh
index dedee8e641f..d363e51e404 100755
--- a/scripts/update-ui-tests.sh
+++ b/scripts/update-ui-tests.sh
@@ -38,3 +38,4 @@ $RUSTUP_RUN cargo test --manifest-path substrate/primitives/runtime-interface/Ca
$RUSTUP_RUN cargo test -p sp-api-test ui
$RUSTUP_RUN cargo test -p frame-election-provider-solution-type ui
$RUSTUP_RUN cargo test -p frame-support-test --features=no-metadata-docs,try-runtime,experimental ui
+$RUSTUP_RUN cargo test -p xcm-procedural ui
diff --git a/substrate/frame/election-provider-support/solution-type/Cargo.toml b/substrate/frame/election-provider-support/solution-type/Cargo.toml
index 30b00712b3f..e24ed7f079f 100644
--- a/substrate/frame/election-provider-support/solution-type/Cargo.toml
+++ b/substrate/frame/election-provider-support/solution-type/Cargo.toml
@@ -28,6 +28,8 @@ codec = { workspace = true, default-features = true }
scale-info = { workspace = true, default-features = true }
sp-arithmetic = { workspace = true, default-features = true }
# used by generate_solution_type:
-frame-election-provider-support = { workspace = true, default-features = true }
+# NOTE: we have to explicitly specify `std` because of trybuild
+# https://github.com/paritytech/polkadot-sdk/pull/5167
+frame-election-provider-support = { workspace = true, default-features = true, features = ["std"] }
frame-support = { workspace = true, default-features = true }
trybuild = { workspace = true }
--
GitLab