From 3320076f8a6abf2565fadcf509e5903ef45638f9 Mon Sep 17 00:00:00 2001
From: Alexandru Gheorghe <49718502+alexggh@users.noreply.github.com>
Date: Fri, 26 May 2023 14:34:06 +0300
Subject: [PATCH] test-utils: Fix wait_for_blocks in presence of reorgs
(#14215)
In the cases where a reorg happens we might receive notifications
for different blocks at the same level, so instead of the chain having
count new blocks it has less and that will break the tests which use this
function.
So, use the block number to identify that `count` blocks have been built in the
chain.
Examples where this issue was hit:
https://github.com/paritytech/polkadot/issues/7267
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
---
substrate/test-utils/client/src/lib.rs | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/substrate/test-utils/client/src/lib.rs b/substrate/test-utils/client/src/lib.rs
index fc9ba1c9e0d..94006fd9acb 100644
--- a/substrate/test-utils/client/src/lib.rs
+++ b/substrate/test-utils/client/src/lib.rs
@@ -42,7 +42,11 @@ use sc_client_api::BlockchainEvents;
use sc_service::client::{ClientConfig, LocalCallExecutor};
use serde::Deserialize;
use sp_core::{storage::ChildInfo, testing::TaskExecutor};
-use sp_runtime::{codec::Encode, traits::Block as BlockT, OpaqueExtrinsic};
+use sp_runtime::{
+ codec::Encode,
+ traits::{Block as BlockT, Header},
+ OpaqueExtrinsic,
+};
use std::{
collections::{HashMap, HashSet},
pin::Pin,
@@ -410,7 +414,7 @@ where
Box::pin(async move {
while let Some(notification) = import_notification_stream.next().await {
if notification.is_new_best {
- blocks.insert(notification.hash);
+ blocks.insert(*notification.header.number());
if blocks.len() == count {
break
}
--
GitLab