From 1ae674dd76c03691adb4701b86969a6c4254b5fa Mon Sep 17 00:00:00 2001
From: Guillaume Thiolliere <gui.thiolliere@gmail.com>
Date: Thu, 11 Nov 2021 23:53:43 +0100
Subject: [PATCH] Warn about usage of pallet collective set members call.
(#10156)
* warn
* Apply suggestions from code review
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
* fmt
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
---
substrate/frame/collective/src/lib.rs | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/substrate/frame/collective/src/lib.rs b/substrate/frame/collective/src/lib.rs
index 89d4c8a150c..2797d01ffcd 100644
--- a/substrate/frame/collective/src/lib.rs
+++ b/substrate/frame/collective/src/lib.rs
@@ -345,6 +345,13 @@ pub mod pallet {
/// NOTE: Does not enforce the expected `MaxMembers` limit on the amount of members, but
/// the weight estimations rely on it to estimate dispatchable weight.
///
+ /// # WARNING:
+ ///
+ /// The `pallet-collective` can also be managed by logic outside of the pallet through the
+ /// implementation of the trait [`ChangeMembers`].
+ /// Any call to `set_members` must be careful that the member set doesn't get out of sync
+ /// with other logic managing the member set.
+ ///
/// # <weight>
/// ## Weight
/// - `O(MP + N)` where:
--
GitLab