From 15a956321a175e35ebf66cc97396de5482999e24 Mon Sep 17 00:00:00 2001
From: Robert Habermeier <rphmeier@gmail.com>
Date: Sat, 27 Mar 2021 16:13:34 +0100
Subject: [PATCH] use a gauge for approval lag (#2725)
---
polkadot/node/service/src/grandpa_support.rs | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/polkadot/node/service/src/grandpa_support.rs b/polkadot/node/service/src/grandpa_support.rs
index 6ffb9e2ca49..ab03b6d75f3 100644
--- a/polkadot/node/service/src/grandpa_support.rs
+++ b/polkadot/node/service/src/grandpa_support.rs
@@ -42,7 +42,7 @@ use {
#[cfg(feature = "real-overseer")]
#[derive(Clone)]
pub(crate) struct ApprovalCheckingDiagnostic {
- checking_lag: Option<prometheus_endpoint::Histogram>,
+ checking_lag: Option<prometheus_endpoint::Gauge<prometheus_endpoint::U64>>,
overseer: OverseerHandler,
}
@@ -55,11 +55,11 @@ impl ApprovalCheckingDiagnostic {
Ok(ApprovalCheckingDiagnostic {
checking_lag: if let Some(registry) = registry {
Some(prometheus_endpoint::register(
- prometheus_endpoint::Histogram::with_opts(
- prometheus_endpoint::HistogramOpts::new(
+ prometheus_endpoint::Gauge::with_opts(
+ prometheus_endpoint::Opts::new(
"parachain_approval_checking_finality_lag",
"How far behind the head of the chain the Approval Checking protocol wants to vote",
- ).buckets(vec![1.0, 2.0, 3.0, 4.0, 5.0, 10.0, 20.0, 30.0, 40.0, 50.0])
+ )
)?,
registry,
)?)
@@ -154,7 +154,7 @@ impl<B> grandpa::VotingRule<PolkadotBlock, B> for ApprovalCheckingDiagnostic
);
if let Some(ref checking_lag) = checking_lag {
- checking_lag.observe(approval_checking_subsystem_lag as _);
+ checking_lag.set(approval_checking_subsystem_lag as _);
}
tracing::debug!(
--
GitLab