From 0d35be7bc80a9c375db52585866601f4294b1e3d Mon Sep 17 00:00:00 2001
From: ordian <write@reusable.software>
Date: Thu, 30 Jan 2025 15:15:12 +0100
Subject: [PATCH] fix pre-dispatch PoV underweight for ParasInherent (#7378)
This should fix the error log related to PoV pre-dispatch weight being
lower than post-dispatch for `ParasInherent`:
```
ERROR tokio-runtime-worker runtime::frame-support: Post dispatch weight is greater than pre dispatch weight. Pre dispatch weight may underestimating the actual weight. Greater post dispatch weight components are ignored.
Pre dispatch weight: Weight { ref_time: 47793353978, proof_size: 1019 },
Post dispatch weight: Weight { ref_time: 5030321719, proof_size: 135395 }
```
---------
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
---
.../parachains/src/paras_inherent/weights.rs | 7 +++++--
prdoc/pr_7378.prdoc | 13 +++++++++++++
2 files changed, 18 insertions(+), 2 deletions(-)
create mode 100644 prdoc/pr_7378.prdoc
diff --git a/polkadot/runtime/parachains/src/paras_inherent/weights.rs b/polkadot/runtime/parachains/src/paras_inherent/weights.rs
index 81c926a90e0..31958cf4acf 100644
--- a/polkadot/runtime/parachains/src/paras_inherent/weights.rs
+++ b/polkadot/runtime/parachains/src/paras_inherent/weights.rs
@@ -94,10 +94,13 @@ pub fn paras_inherent_total_weight<T: Config>(
bitfields: &UncheckedSignedAvailabilityBitfields,
disputes: &MultiDisputeStatementSet,
) -> Weight {
- backed_candidates_weight::<T>(backed_candidates)
+ let weight = backed_candidates_weight::<T>(backed_candidates)
.saturating_add(signed_bitfields_weight::<T>(bitfields))
.saturating_add(multi_dispute_statement_sets_weight::<T>(disputes))
- .saturating_add(enact_candidates_max_weight::<T>(bitfields))
+ .saturating_add(enact_candidates_max_weight::<T>(bitfields));
+ // Relay chain blocks pre-dispatch weight can be set to any high enough value
+ // but the proof size is irrelevant for the relay chain either way.
+ weight.set_proof_size(u64::MAX)
}
pub fn multi_dispute_statement_sets_weight<T: Config>(
diff --git a/prdoc/pr_7378.prdoc b/prdoc/pr_7378.prdoc
new file mode 100644
index 00000000000..8754966d3e8
--- /dev/null
+++ b/prdoc/pr_7378.prdoc
@@ -0,0 +1,13 @@
+title: fix pre-dispatch PoV underweight for ParasInherent
+doc:
+- audience: Runtime Dev
+ description: |-
+ This should fix the error log related to PoV pre-dispatch weight being lower than post-dispatch for `ParasInherent`:
+ ```
+ ERROR tokio-runtime-worker runtime::frame-support: Post dispatch weight is greater than pre dispatch weight. Pre dispatch weight may underestimating the actual weight. Greater post dispatch weight components are ignored.
+ Pre dispatch weight: Weight { ref_time: 47793353978, proof_size: 1019 },
+ Post dispatch weight: Weight { ref_time: 5030321719, proof_size: 135395 }
+ ```
+crates:
+- name: polkadot-runtime-parachains
+ bump: patch
--
GitLab