From 05a796650531e0526e6000c223754df7ec1b73a1 Mon Sep 17 00:00:00 2001 From: Robert Klotzner <eskimor@users.noreply.github.com> Date: Tue, 16 Aug 2022 16:49:25 +0200 Subject: [PATCH] Don't request votes if there is nothing to request. (#5888) * Don't request votes if there is nothing to request. * Add trace log --- polkadot/node/core/provisioner/src/lib.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/polkadot/node/core/provisioner/src/lib.rs b/polkadot/node/core/provisioner/src/lib.rs index 58725a7706e..0f3099c7df3 100644 --- a/polkadot/node/core/provisioner/src/lib.rs +++ b/polkadot/node/core/provisioner/src/lib.rs @@ -713,6 +713,12 @@ async fn request_votes( sender: &mut impl overseer::ProvisionerSenderTrait, disputes_to_query: Vec<(SessionIndex, CandidateHash)>, ) -> Vec<(SessionIndex, CandidateHash, CandidateVotes)> { + // No need to send dummy request, if nothing to request: + if disputes_to_query.is_empty() { + gum::trace!(target: LOG_TARGET, "No disputes, nothing to request - returning empty `Vec`."); + + return Vec::new() + } let (tx, rx) = oneshot::channel(); // Bounded by block production - `ProvisionerMessage::RequestInherentData`. sender.send_unbounded_message(DisputeCoordinatorMessage::QueryCandidateVotes( -- GitLab