* fix: generate docs for all features

* ci: check for --cfg docsrs

* fix nit: rustdoc::broken_intra_doc_links

* fix: generate docs behind features

* address grumbles

* feat: limit the number of subscriptions

Closing #729

* fix nit

* Update core/src/server/helpers.rs

* add integration tests + some fixes so it works

* cargo fmt

* fix doc links

* Unsubscribe calls should avoid subscription limits

Point to Tokio 1.16 (we use a method from it), and a little special treatment for unsubscribe methods

* No resource limiting for Unsubscribe calls

* Test that we can still unsubscribe after hitting a limit

* Fix a comment typo

Co-authored-by: Alexandru Vasile <[email protected]>

* Update core/src/server/rpc_module.rs

* Update core/src/server/rpc_module.rs

Co-authored-by: James Wilson <[email protected]>
Co-authored-by: Alexandru Vasile <[email protected]>

fix(rpc module): close subscription task when a subscription is `unsubscribed` via the `unsubscribe call` (#743)

* refactor: remove SubscriptionSink::inner_send

* fix: close running task if unsubscribed

* Update core/src/server/rpc_module.rs

* Update core/src/server/rpc_module.rs

* fix nits

* Update core/src/server/rpc_module.rs

* add test for canceling subscriptions

* print subscription info; once per minute

* revert closure stuff

* Revert "print subscription info; once per minute"

This reverts commit 366176a8

.

* use tokio::sync::watch instead of oneshot

The receiver is clonable and it's possible to check whether the sender is still alive

* Update tests/tests/helpers.rs

Co-authored-by: David <[email protected]>

* Update core/src/server/rpc_module.rs

Co-authored-by: David <[email protected]>

* grumbles: use unwrap in tests

* add test for reuse pipe_from_stream

Co-authored-by: David <[email protected]>

* feat: untested web-sys transport

* rewrite me

* make it work

* add hacks and works :)

* add subscription test too

* revert StdError change; still works

* cleanup

* remove hacks

* more wasm tests outside workspace

* kill mutually exclusive features

* merge nits

* remove unsafe hack

* fix nit

* core: fix features and deps

* ci: add WASM test

* test again

* work work

* comeon

* work work

* revert unintentional change

* Update core/Cargo.toml

Co-authored-by: David <[email protected]>

* Update core/src/client/async_client/mod.rs

Co-authored-by: David <[email protected]>

* revert needless change: std hashmap + fxhashmap works

* cleanup

* extract try_connect_until fn

* remove todo

* fix bad merge

* add wasm client wrapper crate

* fix nits

* use gloo-net dependency

* fix build

* grumbles CI: rename to `wasm_tests`

* fix bad merge

* fix grumbles

* fix nit

* comeon CI

Co-authored-by: David <[email protected]>

* fix(rpc module): fail subscription with bad params

* draft; show my point

* fix tests

* fix build

* add tests for proc macros too

* add tests for bad params in proc macros

* fix nits

* commit all files

* add ugly fix for proc macro code

* add more user friendly API

* make SubscriptionSink::close take mut self

* fix grumbles

* show james some code

* Update core/src/server/rpc_module.rs

Co-authored-by: James Wilson <[email protected]>

* remove needless clone

* fix build

* client fix docs + error type

* simplify code: merge connect reset and unsubscribe close reason

* remove unknown close reason

* refactor: remove Error::SubscriptionClosed

* add some nice APIs to ErrorObjectOwned

* unify api

* address grumbles

* remove redundant methods for close and reject

* proc macro: compile err when subscription -> Result

* rpc module: fix test subscription test

* Update core/src/server/rpc_module.rs

Co-authored-by: James Wilson <[email protected]>

* Update core/src/server/rpc_module.rs

Co-authored-by: James Wilson <[email protected]>

* Update core/src/server/rpc_module.rs

Co-authored-by: James Wilson <[email protected]>

* Update core/src/server/rpc_module.rs

Co-authored-by: James Wilson <[email protected]>

* Update core/src/server/rpc_module.rs

Co-authored-by: James Wilson <[email protected]>

* Update proc-macros/src/lib.rs

Co-authored-by: James Wilson <[email protected]>

* address grumbles

* remove faulty comment

* Update core/src/server/rpc_module.rs

Co-authored-by: David <[email protected]>

* Update core/src/server/rpc_module.rs

Co-authored-by: David <[email protected]>

* Update core/src/server/rpc_module.rs

Co-authored-by: David <[email protected]>

* Update core/src/server/rpc_module.rs

Co-authored-by: David <[email protected]>

* Update core/src/server/rpc_module.rs

Co-authored-by: David <[email protected]>

* fix: don't send `RPC Call failed: error`.

* remove debug assert

Co-authored-by: James Wilson <[email protected]>
Co-authored-by: David <[email protected]>

These logs are most likely related to that the client terminated the connection
and they come with significant overhead.

* fix(client): close subscription when server sent `SubscriptionClosed` notification

* Update core/src/client/async_client/helpers.rs

* refactor: make `pipe_from_stream` take stream of result

The rationale for this is that it is more flexible for use cases when `Stream<Item = Result<T, Error>>`.

Take for example `tokio_stream::Broadcast` then one would have to something like:

```rust
   let stream = BroadcastStream::new(rx).take_while(|r| future::ready(r.is_ok())).filter_map(|r| future::ready(r.ok()));
```

Of course it's a bit awkward to return `Result` when the underlying stream can't fail but I think that's fair trade-off
here.

* Update core/src/server/rpc_module.rs

Co-authored-by: Tarik Gul <[email protected]>

* pipe_from_stream: make E: Display instead of StdError

* add a test

* add `pipe_from_try_stream` API to support `TryStream`

* Update tests/tests/integration_tests.rs

* Update proc-macros/src/lib.rs

Co-authored-by: Tarik Gul <[email protected]>

* refactor: get rid off `Error::Request` variant

* fix nit

* to_owned -> to_call_error

* wip wip wip

Use tokio::sync::Notify to signal to the server when a subscriber has gone away without calling unsubscribe

* Cleanup

* Fmt

* More cleanup more TODOs

* fmt

* Address a few todos

* Update core/src/server/rpc_module.rs

Co-authored-by: Niklas Adolfsson <[email protected]>

* Update ws-server/src/server.rs

Co-authored-by: Niklas Adolfsson <[email protected]>

* Fix bad merge

* Test

* fmt

* fix test

* Finish test

* Cleanup
Add a second subscription to serverless test

* Update tests/tests/integration_tests.rs

Co-authored-by: Niklas Adolfsson <[email protected]>

* simplify test

* Review feedback: avoid allocations

* cleanup

* Remove async-channel

* remove async-channel deps

Co-authored-by: Niklas Adolfsson <[email protected]>

* fix(rpc module): unsubscribe ethereum pubsub spec

* update docs

* fix clippy

* fix tests

* refactor(ws server): set_id_provider `Box<dyn>`

* address grumbles: thanks James

* relax trait bounds with ?Sized

* Update ws-server/src/tests.rs

* add docs

* feat(client): support request id as Strings.

* add tests for Id::String

* address grumbles: move id_kind to RequestManager

* Update client/http-client/src/client.rs

* types: take ref to `ID` get rid of some `Clone`

* remove more clone

* grumbles: rename tests

Add a method to RpcModule that transforms the module into a `RpcModule<()>`, i.e. removes the context. (#660)

* Add a method to RpcModule, `decontextualize`, that transforms the module into a `RpcModule<()>`, i.e. removes the context.

* Merging a module with an empty module cannot fail

* fmt

* Address grumbles

* Cleanup macro

* Update core/src/server/rpc_module.rs

Co-authored-by: Maciej Hirsz <[email protected]>

Co-authored-by: Maciej Hirsz <[email protected]>

* feat(rpc module): add_stream to subscription sink

* fix some nits

* unify parameters to rpc methods

* Update core/src/server/rpc_module.rs

* Update tests/tests/integration_tests.rs

Co-authored-by: David <[email protected]>

* address grumbles

* fix subscription tests

* new type for `SubscriptionCallback` and glue code

* remove unsed code

* remove todo

* add missing feature tokio/macros

* make `add_stream` cancel-safe

* rename add_stream and return status

* fix nits

* rename stream API -> streamify

* Update core/src/server/rpc_module.rs

* provide proper close reason

* spelling

* consume_and_streamify + docs

* fmt

* rename API pipe_from_stream

* improve logging; indicate which subscription method that failed

Co-authored-by: David <[email protected]>

Implies MSRV 1.56.x

* PoC

* introduce IdProvider trait

* revert Cow stuff

* Update ws-server/src/server.rs

* fix tests

* cargo fmt

* use 'static lifetime in SubscriptionId

* fix tests

* fmt

* make tests compile again

* fix tests

* Fix tests

* Move IdProvider impls to own module

* move `sub-id gen` types to `core`

* fix doc links

* make rand non-optional dep

* feature gate: id provider

Co-authored-by: David Palm <[email protected]>

* extract ws client to async client

* bring back jsonrpsee-ws-client crate

* new crate core client

* add missing file

* jsonrpsee crate: add core client

* rexport core client

* more re-exports

* downgrade trait bounds

* update version

* fix nits

* send close reason

* Update types/src/traits.rs

* move 'TEN_MB_CONST' to core

* Update client/core-client/Cargo.toml

Co-authored-by: David <[email protected]>

* Update client/core-client/src/lib.rs

Co-authored-by: David <[email protected]>

* cargo fmt

* Update client/ws-client/src/lib.rs

Co-authored-by: David <[email protected]>

* Update client/ws-client/src/lib.rs

Co-authored-by: David <[email protected]>

* move `async-client` core

The `async-client` is hidden behind a new feature flag `async-client`
because it brings in additional dependecies such as tokio rt.

* fix docs

* add example how to use "core client"

* fix build

* Update http-server/Cargo.toml

* Update client/transport/Cargo.toml

Co-authored-by: David <[email protected]>

* Nuke V2

* fmt

* Formatting and imports

* Updated benches

* Fix doc comment link

* Brace imports in ws-server

* Reworking imports

* std first

* fmt

* std on top

* Update to match changed line numbers

* Rename jsonrpsee_utils -> jsonrpsee_core

* Migrating things types -> core

* RpcError -> ErrorResponse

* Merge types::client into core::client

* Continued move types -> core

* Removing features to make checks pass

* Move rpc_module tests to tests crate

* Fixed doc comment links

* Add futures-util dependency for client

* Remove dead code

Co-authored-by: Niklas Adolfsson <[email protected]>

* fmt

* Feature gate the Client trait

* Move `Client` traits to `client` module

Co-authored-by: Niklas Adolfsson <[email protected]>

* Merge all the crates into one

* Rustfmt

* Fix examples

* Fix tests

* Prepare core for no_std support

* Fix missing documentation thingies

* Rustfmt

* For some reason my local rustfmt didn't pick up these changes

* Fix compilation

* Rustfmt

* Replace err-derive with thiserror
* Remove some useless dependencies

Signed-off-by: koushiro <[email protected]>

* Rename Client/Server -> RawClient/RawServer

* SharedClient/Server -> Client/Server

* Rename http/ws constructors

* Rustfmt

* Fix some bad renames

* Rustfmt

* More fixing

* Add a SharedServer

* More work

* More work

* More work

* Make it work

* Copyright update

* Finish work

* Add a SharedClient

* More work

* More work

* More work

* Finish Sharedclient

* Fix merge conflict

* Add From impl

* RawClient -> TransportClient

* RawServer -> TransportServer

* Rustfmt

* Add ClientActiveSubscription::is_closing

* Rustfmt

* Allow closing a subscription from the client side

* Rustfmt

* Apply Rustfmt and add a CI check

* Install rustfmt

dpmkl authored Nov 18, 2019 and Pierre Krieger committed Nov 18, 2019

* Add initial acl implementation

* Implemented access control with utilities from paritytech::jsonrpc

* Incorrect if

* Make allowed_hosts an enum

* Handling CORS in process_request

* Build for AccessControl and naming coherence

* "clean up your room! clean up your room ! that's all i ever hear..."
- preflight requests
- test and bench
- wasm for yew

* Add basic acl tests for 'host'

* Remove 'macro_use'

* Apply rustfmt to server-utils

* Apply rustfmt to http

* Bump lazy_static dependency

* Run rustfmt on core

* Apply rustfmt on ws

* Apply rustfmt on proc-macro

* Servers can no longer error

* Add comment about errors

* Fix comment

* Support generics in proc macro

* Some work on allowing generics for the proc macro