* Renames

* More renames

* fmt

* s/RpcParams/Params/

* Add a type alias `SubscriptionResponse` to `Notification` which is parametrized to `SubscriptionPayload`
Move `SubscriptionResponse` to the `response` module

* Fix doc links

* Cleanup and some docs

* Review feedback

* cleanup

* Add a test illustrating how to use the `call` convenience method

* Extend test + review feedback

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* Add Methods::test_subscription
Log more when params parsing fails

* Add call_with test helper (ty @niklas!) + cleanup

* Remove todo (part of https://github.com/paritytech/jsonrpsee/issues/457

)

* fmt

* Let `test_subscription` be called from other crates

* Manually fix indentation

* fmt

* SSself-review grumbles

* CallError::InvalidParams carries an anyhow::Error

* fmt

* Tweak docs

* Update utils/src/server/rpc_module.rs

Co-authored-by: Niklas Adolfsson <[email protected]>

* review grumble

* Fix todos

* fmt

* Fixup error messages

* Include source in the error message for `CallError`

* fmt

* Update proc-macros/src/render_server.rs

Co-authored-by: Maciej Hirsz <[email protected]>

* Mention needing jsonrpsee crate in scope

* Resolve todo

* Impl ToRpcParams for 0-sized array

* optimized logging

Co-authored-by: Niklas Adolfsson <[email protected]>
Co-authored-by: Maciej Hirsz <[email protected]>

Similar to #435 that adds the same restrictions to subscriptions too.
To avoid having faulty trait bounds on when the subcription actually returns Result.

* feat: alias attribute for proc macros

* implement David's suggested no more unsub field

* keep aliases outside namespace

* revert example

* fix build

* Update proc-macros/src/attributes.rs

Co-authored-by: David <[email protected]>

* grumbles: alias -> aliases

* grumbles v2: alias -> aliases

Co-authored-by: David <[email protected]>

* PoC support generic type params

* more annoying example

* add trait bounds for generic params in proc macros

* add compile-time test for complicated trait

* smarter trait bounds in proc macros

* add non-working example for now

* revert nits

* Update examples/proc_macro.rs

Co-authored-by: David <[email protected]>

* Update proc-macros/src/helpers.rs

Co-authored-by: David <[email protected]>

* add messy code but works

* cleanup

* add some simple compile check in tests

* fix doc link

* fix doc link last time

* address grumbles

* docs

* Update proc-macros/src/helpers.rs

* Update proc-macros/src/helpers.rs

* Update proc-macros/src/helpers.rs

* Update proc-macros/src/helpers.rs

* Update proc-macros/src/visitor.rs

* fix nit: | -> ||

* Update proc-macros/src/helpers.rs

Co-authored-by: David <[email protected]>

* Update proc-macros/src/helpers.rs

Co-authored-by: David <[email protected]>

* Update proc-macros/src/helpers.rs

Co-authored-by: David <[email protected]>

* add issues to introduced TODOs

* generics support where clause on trait

* Update proc-macros/src/helpers.rs

Co-authored-by: David <[email protected]>

* Update proc-macros/src/helpers.rs

* address grumbles

* add more docs

Co-authored-by: David <[email protected]>

* Add license headers where missing and update year

* Update examples/http.rs

Co-authored-by: Niklas Adolfsson <[email protected]>

Co-authored-by: Niklas Adolfsson <[email protected]>

* Doc tweaks

* More tweaks

* Move proc macro code out of the "new" folder

* fmt

* Can't add doc-links to dev-dependencies

* rewrite me

* require proc macro API to return result

* send unknown message when error is not CallError

* show example that auto cast StdError doesn't work

* register_*_method Into<Error>

* clippy

* replace generic errors with anyhow::Error

* fix nits

* example that anyhow::Error in register_method works

* CallError: add missing From impl

* [types]: add helper methods for Error types

The rationale is to make it possible for users to either use anyhow::Error or use the helper methods.

* fmt

* Revert "register_*_method Into<Error>"

This reverts commit 33b4fa28730b72647ba150659d3c0ab1937e524a.

* add better comment

* fix nit

* fix: update example to new proc macros

* remove unused code

* remove client builder

* Do not register methods on servers

* fmt

* Infallible `to_rpc` proc macro

* Remove dead code

* Check for duplicate names at compile time

* Add a UI test for name conflicts

* Apply suggestions from code review

Co-authored-by: David <[email protected]>

Co-authored-by: David Palm <[email protected]>

* Only return the crate name when the crate is `jsonrpsee` as well

* Sort out the type paths in the macros, this time for real (?)

* fmt

* Start working on the new proc macro system

* Add skeleton for rendering

* Improve error reporting

* Main part of 'render_client'

* Implement RPC client generation

* Client successfully rendered

* Add doc-comment generation for the API client

* Check that all the methods have receiver

* Start working on the server impl

* Add helper method to find server crate

* Fix usage of client rpc path

* Decent progress on the server macro implementation

* Server macro compiled successfully

* Remove unneeded re-export

* Insert SubscriptionSink argument to the subscription server signatures

* Add basic doc-comment for the macro

* no_run -> ignore

* Trait with subscription compiles

* Extend the example

* Add integration test for client/server impl

* Add trybuild setup

* Set correct span for attribute parsing related errors

* Add basic set of trybuild tests

* Add tests for client and server generated separately

* Improve proc-macro documentation

* Update proc-macros/src/lib.rs

Co-authored-by: Niklas Adolfsson <[email protected]>

* Fix a couple of bugs in docs

* Fix rendering subscription with params

Co-authored-by: Niklas Adolfsson <[email protected]>

* rewrite me

* v2

* PoC works without batch request

* remove `PartialEq` bounds

* add naive benches types

* misc

* remove useless lifetime

* [ws client]: move request ID generation to client

* make tests compile again

* [client transport]: kill leaky abstractions.

* [http client transport]: minor changes in the API.

* [ws client]: fix batch requests.

* fix nits

* [ws client]: generate two request IDs for subscrib

* fix tests

* remove unused types + less alloc for params.

* fix nits

* more tweaks.

* remove unused code

* fix more nits

* remove unused legacy types

* reorg types_v2 mod

* port macros to new types

* fix tests again; more jsonvalue

* [proc macros]: bring back impl Into for params.

* fix build

* [proc macros]: make it work for external crates.

* [types]: remove weird From<Option<T>> to impl.

* cleanup again

* [examples]: remove unused async-std dep

* Update types/src/v2/mod.rs

* [types]: remove unsed dep smallvec

* rewrite me

* [types]: error code impl ser/deser

Manual implementation of serialize/deserialize to get rid of duplicated message string

* [types v2]: re-org with explicit mods

* fix faulty test

* add missed files

* [ws client]: req_manager reserve unsubscribe slot.

* simplify test code

* add tracking issue for TODO

* remove unused deps

* add wrapper crate

* add jsonrpsee crate back

* [jsonrpsee]: feature gate modules

* [proc macros]: support crate renaming of `types`

* Update proc-macros/src/lib.rs

Co-authored-by: David <[email protected]>

* re-export types

* [proc macros]: remove unused features

* Update proc-macros/Cargo.toml

* fix bad merge

Co-authored-by: David <[email protected]>

The generated enum variants is hack to bound the type params to the enum itself.
Thus, the enum patterns are never used and will always generated warnings so
this commit adds `unused` on all the variants.

* draft: client trait sketch...

* use async_trait instead of `Box<Future>`

* refactor client trait

* [types]: shared client types.

* integrate with `jsonrpsee_proc_macros::rpc_api`

* Update proc-macros/src/lib.rs

* integrate with proc macros

* fix: hacky support for generic types in proc macro

* fix: make the examples work.

* trait: error associated type

* Update types/src/traits.rs

* client trait: make object safe.

Make the trait usable as a trait object i.e, `Box<dyn Trait>`

* client trait: remove `Self::Sized`

* add tests for proc macros.

* fix build

* fmt

* [client trait]: remove unused associated error typ

* [proc macros]: separate enum variant each return_t

* add tracking issue to `TODO`

* doc(client trait): improve documentation.

* separate trait for subscribing client

* add documentation

* proc macros: remove debug impl

* fix compile warns

* address grumbles: remove fn process_response

* Update types/src/client.rs

Co-authored-by: David <[email protected]>

* Update types/src/client.rs

Co-authored-by: David <[email protected]>

* Update types/src/client.rs

Co-authored-by: David <[email protected]>

* Update types/src/client.rs

Co-authored-by: David <[email protected]>

* Update types/src/client.rs

Co-authored-by: David <[email protected]>

* remove old proc macro tests

* address grumbles: shorter lines

Co-authored-by: David <[email protected]>

* update http example

* ungeneric crate

* update dependencies

* [client]: add WebSocket client again.

* [deps]: remove needless dev dependencies

* nits: forgot to commit new files

* [ws client]: `send_text` instead of `send_binary`

This is temporary fix to work with the `server` which assumes that
`WebSocket` resonses are `text`

* chore: add a bunch of more logging

* [ws]: port tests but some are failing.

* chore: fmt

* [server API]: expose `fn local_addr` as public API.

* [tests]: make them less ugly by using `127.0.0.1:0`

* fix: a bunch of compiler warnings.

* [api]: uniform naming, `bind -> new` in transport.

* [websocket server]: reply when deserial fails

When the server receives an request with invalid JSON
`-32700, Parse error shall be returned`

* chore: fmt

* [tests]: fix remaining tests

* [websocket server]: support `binary` and `text`

* [ws server]: fix bug in subscription response.

`.await` was missing in RegisteredSubscription::send() and no responses
were actually sent which this commit fixes.

* [client API]: export `WsSubscription`

* [examples]: use `localhost` instead of `127.0.0.1`

Hostname is required when using `wss` and `127.0.0.1` is not valid hostname.

* [examples]: add subscription example.

* chore: fmt

* [ws server]: fix bug register new subscription.

Fixes newly introduced bug that causes `register_subscription` to have
side-effects even if the subscription fails.

* fmt

* more uniform logs

* [ws server]: simple subscription test.

* [ws server]: subscription tests improved.

* [tests]: extract test helpers to a separate crate (#125)

* [ws server]: don't close connection when `deserialization` fails (#131)

* [ws server]: don't close conn. when `deser` fails

* Update src/ws/transport.rs

* grumbles: prefer matching of if else.

* chore: CI warn `intra_doc_link_resolution_failure` (#139)

Since we have not updated the documentation properly it's annoying that
the entire job fails.

* chore: rustfmt.toml (#138)

* chore: add `rustfmt.toml` for formatting

* style: `cargo fmt --all` with new config

* [server raw params]: fix debug implementation (#137)

* [server]: simply raw params impl

Use debug implementation of `common::Params` instead of doing something
similar that doesn't work properly.

* [raw params]: derive `Debug` impl.

* [ws server]: parse subscription ID for unsubscription instead of hardcoding `JsonValue::Null` (#136)

* [ws server]: fix broken unsubscribe.

Try to parse the subscription ID as the first element of an Array or the `subscription`
field of an Object/Map.

If both of those fails then regard it as a error.

* fmt

* fix grumbles: remove space indentation

* fix(ws server): sub/unsubscribe to same method should generate an error (#140)

* fix(ws server): sub/unsubscribe to same method err

Subscribe and unsubscribe to the same method should generate an error, which this commit fixed.
This bug was introduced by myself in https://github.com/paritytech/jsonrpsee/commit/fc87889de2615dbb3d0cf2d91a306f016d48df2d



* Update src/ws/server.rs

Co-authored-by: David <[email protected]>

Co-authored-by: David <[email protected]>

* chore: add naive benches for request/response (#142)

Co-authored-by: Niklas <[email protected]>

* fix(ws server): remove faulty debug_assert (#145)

The code assumed that `subscription id` is still in `active_subscriptions` when the
connection was dropped.

The list of subscriptions (kept in raw server) are not notified when a client dropped its
subscription/unsubscribed thus it's possible that the actual subscriptions are closed before the
entire client was dropped.

* ci(benches): cargo check on benches. (#146)

* fix(http client): implement `clone` uniform API. (#147)

* chore(deps): update `futures v0.3.7` (#148)

* chore(deps): update remaining crates (#149)

* chore(deps): update `futures v0.3.7`

* chore(deps): bump the rest of deps

* Improve HTTP client background thread (#150)

* refactor: resultify API + some crate reorg (#144)

* [ws client]: resultify API and fix subscribe.

* The commit changes the API to return `Err` when it's possible and to not ignore underlying errors.
* Fix that `fn subscribe` doesn't accept the subscription and unsubscription to be same which causes
errors in the server.

* nits: Err::SubscriptionMetod -> Err::Subscription

* refactor(client): common error type

* refactor(http client): resultify

* refactor(common): rename common -> types..

This commit renames the `common module` to `types` and tries to distinguish the types that is
directly related to the `JSON-RPC v2 specification` from others.

Somethings are a little big sloppy named as naming is hard.

Also, as bonus a removed a bunch of needless stuff in http server related to subscription.

* Update src/ws/tests.rs

* style: cargo fmt

* fix(grumble): matches -> assert(matches)

* fix(grumbles): `jsonrpc_v2` -> `jsonrpc`

* fix(nit): remove unused code.

* fix(benches): make it compile again.

* style: cargo fmt

* fix nits (#151)

* fix(ws client): send binary (1 byte less payload)

* docs(ws server): fix bad comment.

* chore: add `editorconfig` (#152)

* chore: make `debug log` less verbose. (#153)

* chore: make `debug log` less verbose.

The debug logging was just too verbose and this commit simplies it as follows:

```
DEBUG recv: {"jsonrpc":"2.0","method":"<METHOD>","params":<PARAMS>,"id":<ID>}
DEBUG send: {"jsonrpc":"2.0","result":"<RESULT>","id":<ID>}
```

* style: cargo fmt

* fix: missed logs

* [jsonrpc types]: implement Display for Request/Response (#160)

* feat(jsonrpc response/request): impl `Display`

* refactor(logging): use display impl

* use serde_json for verbosity

* [http client]: refactor with "syncronous-like" design (#156)

* experimental

* ci(benches): sync and concurrent roundtrips

Improve benchmarks to take concurrent requests into account.

* ci(benches): sync and concurrent roundtrips

Improve benchmarks to take concurrent requests into account.

* fix(nits)

* feat(http client): limit max request body size

* test(http transport): request limit test

* test(http client): add tests.

* fix typo

* fix(benches): make it compile again.

* fix(ws example): revert unintentional change.

* test(http client): subscription response on call.

* fix(cleanup)

* fix(benches): make it compile again.

* Update src/client/http/transport.rs

* fix(http client): `&str` -> `AsRef<str>`

* docs(client types): better docs for Mismatch type.

* style: `Default::default` -> `HttpConfig::default`

* fix(http client): read body size from header.

Expermential to read number of bytes from `HTTP Content Length` to pre-allocate the number of bytes and bail early
if the length is bigger than the `max_request_body size`

Need to be benched with bigger requests.

* test(raw http): enable tests to works again.

* style: cargo fmt

* benches: address grumbles

* feat(jsonrpc response/request): impl `Display`

* refactor(logging): use display impl

* fix(http client): nits.

* Update benches/benches.rs

* fix bad merge.

* chore(deps): update dependencies. (#164)

* feat(http server): configurable request body limit (#162)

* feat(http server): configurable request body limit

* refactor(crate reorg): to have shared http helpers.

* Merge client and server errors.
* Move `http_server_utils` to `utils/http`
* Minor cleanup

* fix nits

* fix(hyper helper): u64 -> u32

* Update src/utils/http/hyper_helpers.rs

Co-authored-by: David <[email protected]>

* Update src/utils/http/hyper_helpers.rs

Co-authored-by: David <[email protected]>

* fix: grumbles

* Update src/utils/http/hyper_helpers.rs

Co-authored-by: David <[email protected]>

* Update src/http/server.rs

Co-authored-by: David <[email protected]>

Co-authored-by: David <[email protected]>

* ci: remove nightly (#167)

Use stabilized `broken_intra_doc_links` instead of `intra_doc_link_resolution_failure`

* fix(websocket client): drop subscriptions that can't keep up with the internal buffer size (#166)

* fix(ws client): drop subscriptions when full.

This commit changes the behavior in the `WebSocket Client` where each subscription channel is used in a non-blocking
matter until it is determined as full or disconnected. When that occurs the channel is simply dropped and when
the user `poll` the subscription it will return all sent subscriptions before it was and terminate (return None)
once it's polled one last time. Similarly as `Streams` works in Rust.

It also adds configuration for the `WebSocket Client` to configure capacity for the different internal channels to avoid
filling the buffers when it's not expected.

* tests(ws client): simple subscription test.

* fix: nits

* Update src/client/ws/client.rs

* refactor(tests): introduce integration_tests

Make the repo structure more understable w.r.t testing.

* chore(license): add missing license headers

* Update src/client/ws/client.rs

* Update src/client/ws/client.rs

* style: remove unintended spaces.

* tests: add concurrent deadlock test

Ensure that if more than the requested channel buffer capacity is exceeded it should not deadlock.
Such as spawning alot of concurrent requests, notifications or new subscriptions.

* Update src/client/ws/client.rs

* fix: review grumbles

* fix nits: `remove needless closure`

* fix: cargo fmt

* Update src/client/ws/client.rs

Co-authored-by: David <[email protected]>

* fix more nits

Co-authored-by: David <[email protected]>

* fix(ws client): embed request id in `SubscriptionClosed` (#170)

* fix(ws client): embed request id SubscriptClosed

Fixes https://github.com/paritytech/jsonrpsee/issues/169



* Update src/client/ws/client.rs

* Update src/client/ws/client.rs

Co-authored-by: David <[email protected]>

* Update src/client/ws/client.rs

Co-authored-by: David <[email protected]>

Co-authored-by: David <[email protected]>

* chore(deps): bump dependencies (#172)

* [ws client]: add tests (#134)

* [test utils]: add `internal_err` and consts
[errors]: unify client/server errors
[test utils]: fake WebSocket jsonrpc server
[ws client]: export errors
[ws client]: add some basic tests

* fmt

* remove log target

* fix nits

* [ws client]: add subscription test

* revert unintendend changes.

* fmt

* [ws client]: fix panic in tests

* cleanup

* tests(ws client): test for invalid request ID.

* fix nits

* [ws client]: kill raw client (#171)

* getting started

* WIP WIP

* cleanup

* cleanup v2

* cleanup v3

* perf: use BufReader BufWriter

* fix(request manager): resultify insert API

The rationale behind this change is that the `insert_methods` takes ownership of the `send_back_oneshot`
and if the operation fails it should be propagated the frontend.

So returning the `Err(send_back_oneshot)` if it fails makes it possible.

* fix nits

* examples(ws): revert changes

* Update tests/integration_tests.rs

* nits: fix unwraps

* Update src/client/ws/manager.rs

Co-authored-by: David <[email protected]>

* Update src/client/ws/transport.rs

Co-authored-by: David <[email protected]>

* Update src/client/ws/client.rs

Co-authored-by: David <[email protected]>

* fix build

* refactor: simplify `Error::InvalidRequestId`

It was hard to use when the expected id is not known.

* fix(ws client): error handling.

* fix(grumble error type): better error message.

* fix(grumble): docs `JSONRPC WebSocket transport`

* fix(ws manager): fix grumbles.

* Add better documentation
* Rename methods.
* Add `proof` to unreachable!

* fix(ws manager): fix nit in docs.

* fix(grumbles): ws client

* fix more nits

* fix compile warning: export websocket transports.

* Update src/client/ws/manager.rs

Co-authored-by: David <[email protected]>

* deps: tokio 1.0 and hyper 0.14 (#176)

* deps: tokio 1.0 and hyper 0.14

* Update Cargo.toml

* refactor: crate re-organization with separate crates (#177)

* [ci]: feature `http` and `ws` removed.

* refactor: re-org crate with smaller crates.

* fmt

* [ci]: remove default features

Currently there are no features in the crates, so that check is not needed.

* [http client]: remove unused dependency tokio

* docs(http client): fix nits tokio 0.2 -> tokio 1.0 (#178)

* docs(http client): tokio 0.2 -> tokio 1.0

* fix: better link

* [ci]: github actions (#179)

* docs(http client): tokio 0.2 -> tokio 1.0

* [ci]: remove travis

* [ci]: add github actions.

* [ci]: fix identation nits

* [ci]: use cache for actions

* [ci]: filter to clippy

* [ci]: remove hacks

* separate action for ci and benchmarks

* [ci]: tweak to run on master branch.

* examples/subscription -> examples/ws_subscription

* force CI

Co-authored-by: David <[email protected]>
Co-authored-by: Maciej Hirsz <[email protected]>
Co-authored-by: Atkins <[email protected]>

* Adds a ws_server function at the root, and not some async qualifiers

* Rustfmt

* Upgrade to the latest version of rustls

* Fix some warnings

* Move common to crate root

* Move transport traits to own module

* Hide transport::client and transport::server

* Move ws and http to transport

* Typo fix

* Remove the shortcuts for raw client and servers

* Rename core to raw

* Remove commented-out code

* Fix docs of raw module

* Rustfmt

* Force inline

* Rustfmt

* New rpc attribute for rpc_api macro allowing methods to have positional
args.

* Fix some whitespace issues

* Make Cargo Fmt happy again

Co-authored-by: Jim Posen <[email protected]>

* Rename Client/Server -> RawClient/RawServer

* SharedClient/Server -> Client/Server

* Rename http/ws constructors

* Rustfmt

* Fix some bad renames

* Rustfmt

* More fixing

Andrew Jones authored Jan 03, 2020 and Pierre Krieger committed Jan 03, 2020

* Add Deserialize type constraint on server for generic params

* Add generic type params to Tmp struct

* fmt

Co-authored-by: Pierre Krieger <[email protected]>

* RawClient -> TransportClient

* RawServer -> TransportServer

* Rustfmt

* Run rustfmt on core

* Apply rustfmt on ws

* Apply rustfmt on proc-macro

* Don't modify ApiDefinition; instead clone the generics

* Split client functions impl block into own function

* Some doc

* Servers can no longer error

* Add comment about errors

* Fix comment

* Support generics in proc macro

* Some work on allowing generics for the proc macro

* Add license header everywhere

* Update company name

* Fix bad merge

* Changes to the Client requests/subscriptions API

* Fix rest

* Rework the Client to support multiple concurrent requests

* Restore proc-macro functionnality

* More work

* More work

* Work on the Server subscriptions system

* More work on design

* More work

* More work

* Even more work

* Subscriptions working

* Dix docs

* More test fix

* Fix server-sent subscription notifications

* Add some server tests

* Subscriptions pending system working

* Remove TODO from tests

* Implement close() correctly

* Add comment on close()

* Fix proc macro

* Fix doctest

* Fix local doctest

* Add documentation and error variants to Client

* Reexport missing reexports

* Fix proc macro

* Rework the Client to support multiple concurrent requests

* Restore proc-macro functionnality

* More work

* More work

* More work

* Even more work

* Subscriptions working

* Dix docs

* More test fix

* Add a SubscriptionsClosed server event

* Don't attempt to send back response if connection is closed

* Implement into_subscription

* Properly support params in rpc_api!

* Respond with invalid param in case of parsing error