1. 02 Mar, 2021 1 commit
    • Niklas Adolfsson's avatar
      feat: client trait + porting client proc macros (#199) · 50d8bf78
      Niklas Adolfsson authored
      
      
      * draft: client trait sketch...
      
      * use async_trait instead of `Box<Future>`
      
      * refactor client trait
      
      * [types]: shared client types.
      
      * integrate with `jsonrpsee_proc_macros::rpc_api`
      
      * Update proc-macros/src/lib.rs
      
      * integrate with proc macros
      
      * fix: hacky support for generic types in proc macro
      
      * fix: make the examples work.
      
      * trait: error associated type
      
      * Update types/src/traits.rs
      
      * client trait: make object safe.
      
      Make the trait usable as a trait object i.e, `Box<dyn Trait>`
      
      * client trait: remove `Self::Sized`
      
      * add tests for proc macros.
      
      * fix build
      
      * fmt
      
      * [client trait]: remove unused associated error typ
      
      * [proc macros]: separate enum variant each return_t
      
      * add tracking issue to `TODO`
      
      * doc(client trait): improve documentation.
      
      * separate trait for subscribing client
      
      * add documentation
      
      * proc macros: remove debug impl
      
      * fix compile warns
      
      * address grumbles: remove fn process_response
      
      * Update types/src/client.rs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * Update types/src/client.rs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * Update types/src/client.rs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * Update types/src/client.rs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * Update types/src/client.rs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * remove old proc macro tests
      
      * address grumbles: shorter lines
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      50d8bf78
  2. 23 Feb, 2021 1 commit
  3. 22 Feb, 2021 1 commit
  4. 18 Feb, 2021 1 commit
    • Niklas Adolfsson's avatar
      [ws client]: add `wss` test + refactor `WebSocketTransport builder` (#209) · 1cdd1381
      Niklas Adolfsson authored
      * test(ws client): wss (TLS)
      
      * fix(ws client): bug replace target with host.
      
      * address review suggestions
      
      * tests: add tests for non-ascii URLs
      
      * refactor: impl TryFrom for WebSocketTransportBuild
      
      * fix nit: try to connect to all sockaddrs
      
      * document `Host type`
      
      * doc(ws client): default port.
      
      * remove helper function
      1cdd1381
  5. 15 Feb, 2021 1 commit
  6. 12 Feb, 2021 1 commit
  7. 11 Feb, 2021 1 commit
  8. 10 Feb, 2021 1 commit
  9. 08 Feb, 2021 1 commit
  10. 02 Feb, 2021 1 commit
    • Niklas Adolfsson's avatar
      [ws client]: use `max_payload_size` in transport (#198) · 7dc9435e
      Niklas Adolfsson authored
      
      
      * fix examples
      
      * [ws client]: transport use `max_payload_size`
      
      * fix nits
      
      * fix more nits
      
      * Update ws-client/src/client.rs
      
      * fix doc tests
      
      * [ws client]: all transport config configurable
      
      * Update ws-client/src/client.rs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * Update ws-client/src/manager.rs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * address grumbles
      
      * grumbles: WsDnsError -> WsHandshakeError
      
      * grumbles: remove needless clone
      
      * fix lint: remove explicit lifetime
      
      * fix nits: channel capacity + docs
      
      * clippy nits
      
      * clippy nits
      
      * fix grumbles: channel capacity 256
      
      As Maciej pointed out the capacity is the number of messages (not bytes) and each message is 96 bytes.
      Thus, 256 * 96 = ~24kB which is reasonable default value.
      
      * Update ws-client/src/client.rs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * grumbles: docs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      7dc9435e
  11. 28 Jan, 2021 1 commit
  12. 27 Jan, 2021 1 commit
  13. 26 Jan, 2021 1 commit
  14. 21 Jan, 2021 3 commits
  15. 18 Jan, 2021 1 commit
    • Niklas Adolfsson's avatar
      merge v2 to master (#180) · 61656562
      Niklas Adolfsson authored
      * update http example
      
      * ungeneric crate
      
      * update dependencies
      
      * [client]: add WebSocket client again.
      
      * [deps]: remove needless dev dependencies
      
      * nits: forgot to commit new files
      
      * [ws client]: `send_text` instead of `send_binary`
      
      This is temporary fix to work with the `server` which assumes that
      `WebSocket` resonses are `text`
      
      * chore: add a bunch of more logging
      
      * [ws]: port tests but some are failing.
      
      * chore: fmt
      
      * [server API]: expose `fn local_addr` as public API.
      
      * [tests]: make them less ugly by using `127.0.0.1:0`
      
      * fix: a bunch of compiler warnings.
      
      * [api]: uniform naming, `bind -> new` in transport.
      
      * [websocket server]: reply when deserial fails
      
      When the server receives an request with invalid JSON
      `-32700, Parse error shall be returned`
      
      * chore: fmt
      
      * [tests]: fix remaining tests
      
      * [websocket server]: support `binary` and `text`
      
      * [ws server]: fix bug in subscription response.
      
      `.await` was missing in RegisteredSubscription::send() and no responses
      were actually sent which this commit fixes.
      
      * [client API]: export `WsSubscription`
      
      * [examples]: use `localhost` instead of `127.0.0.1`
      
      Hostname is required when using `wss` and `127.0.0.1` is not valid hostname.
      
      * [examples]: add subscription example.
      
      * chore: fmt
      
      * [ws server]: fix bug register new subscription.
      
      Fixes newly introduced bug that causes `register_subscription` to have
      side-effects even if the subscription fails.
      
      * fmt
      
      * more uniform logs
      
      * [ws server]: simple subscription test.
      
      * [ws server]: subscription tests improved.
      
      * [tests]: extract test helpers to a separate crate (#125)
      
      * [ws server]: don't close connection when `deserialization` fails (#131)
      
      * [ws server]: don't close conn. when `deser` fails
      
      * Update src/ws/transport.rs
      
      * grumbles: prefer matching of if else.
      
      * chore: CI warn `intra_doc_link_resolution_failure` (#139)
      
      Since we have not updated the documentation properly it's annoying that
      the entire job fails.
      
      * chore: rustfmt.toml (#138)
      
      * chore: add `rustfmt.toml` for formatting
      
      * style: `cargo fmt --all` with new config
      
      * [server raw params]: fix debug implementation (#137)
      
      * [server]: simply raw params impl
      
      Use debug implementation of `common::Params` instead of doing something
      similar that doesn't work properly.
      
      * [raw params]: derive `Debug` impl.
      
      * [ws server]: parse subscription ID for unsubscription instead of hardcoding `JsonValue::Null` (#136)
      
      * [ws server]: fix broken unsubscribe.
      
      Try to parse the subscription ID as the first element of an Array or the `subscription`
      field of an Object/Map.
      
      If both of those fails then regard it as a error.
      
      * fmt
      
      * fix grumbles: remove space indentation
      
      * fix(ws server): sub/unsubscribe to same method should generate an error (#140)
      
      * fix(ws server): sub/unsubscribe to same method err
      
      Subscribe and unsubscribe to the same method should generate an error, which this commit fixed.
      This bug was introduced by myself in https://github.com/paritytech/jsonrpsee/commit/fc87889de2615dbb3d0cf2d91a306f016d48df2d
      
      
      
      * Update src/ws/server.rs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * chore: add naive benches for request/response (#142)
      
      Co-authored-by: Niklas Adolfsson's avatarNiklas <niklasadolfsson1@gmail.com>
      
      * fix(ws server): remove faulty debug_assert (#145)
      
      The code assumed that `subscription id` is still in `active_subscriptions` when the
      connection was dropped.
      
      The list of subscriptions (kept in raw server) are not notified when a client dropped its
      subscription/unsubscribed thus it's possible that the actual subscriptions are closed before the
      entire client was dropped.
      
      * ci(benches): cargo check on benches. (#146)
      
      * fix(http client): implement `clone` uniform API. (#147)
      
      * chore(deps): update `futures v0.3.7` (#148)
      
      * chore(deps): update remaining crates (#149)
      
      * chore(deps): update `futures v0.3.7`
      
      * chore(deps): bump the rest of deps
      
      * Improve HTTP client background thread (#150)
      
      * refactor: resultify API + some crate reorg (#144)
      
      * [ws client]: resultify API and fix subscribe.
      
      * The commit changes the API to return `Err` when it's possible and to not ignore underlying errors.
      * Fix that `fn subscribe` doesn't accept the subscription and unsubscription to be same which causes
      errors in the server.
      
      * nits: Err::SubscriptionMetod -> Err::Subscription
      
      * refactor(client): common error type
      
      * refactor(http client): resultify
      
      * refactor(common): rename common -> types..
      
      This commit renames the `common module` to `types` and tries to distinguish the types that is
      directly related to the `JSON-RPC v2 specification` from others.
      
      Somethings are a little big sloppy named as naming is hard.
      
      Also, as bonus a removed a bunch of needless stuff in http server related to subscription.
      
      * Update src/ws/tests.rs
      
      * style: cargo fmt
      
      * fix(grumble): matches -> assert(matches)
      
      * fix(grumbles): `jsonrpc_v2` -> `jsonrpc`
      
      * fix(nit): remove unused code.
      
      * fix(benches): make it compile again.
      
      * style: cargo fmt
      
      * fix nits (#151)
      
      * fix(ws client): send binary (1 byte less payload)
      
      * docs(ws server): fix bad comment.
      
      * chore: add `editorconfig` (#152)
      
      * chore: make `debug log` less verbose. (#153)
      
      * chore: make `debug log` less verbose.
      
      The debug logging was just too verbose and this commit simplies it as follows:
      
      ```
      DEBUG recv: {"jsonrpc":"2.0","method":"<METHOD>","params":<PARAMS>,"id":<ID>}
      DEBUG send: {"jsonrpc":"2.0","result":"<RESULT>","id":<ID>}
      ```
      
      * style: cargo fmt
      
      * fix: missed logs
      
      * [jsonrpc types]: implement Display for Request/Response (#160)
      
      * feat(jsonrpc response/request): impl `Display`
      
      * refactor(logging): use display impl
      
      * use serde_json for verbosity
      
      * [http client]: refactor with "syncronous-like" design (#156)
      
      * experimental
      
      * ci(benches): sync and concurrent roundtrips
      
      Improve benchmarks to take concurrent requests into account.
      
      * ci(benches): sync and concurrent roundtrips
      
      Improve benchmarks to take concurrent requests into account.
      
      * fix(nits)
      
      * feat(http client): limit max request body size
      
      * test(http transport): request limit test
      
      * test(http client): add tests.
      
      * fix typo
      
      * fix(benches): make it compile again.
      
      * fix(ws example): revert unintentional change.
      
      * test(http client): subscription response on call.
      
      * fix(cleanup)
      
      * fix(benches): make it compile again.
      
      * Update src/client/http/transport.rs
      
      * fix(http client): `&str` -> `AsRef<str>`
      
      * docs(client types): better docs for Mismatch type.
      
      * style: `Default::default` -> `HttpConfig::default`
      
      * fix(http client): read body size from header.
      
      Expermential to read number of bytes from `HTTP Content Length` to pre-allocate the number of bytes and bail early
      if the length is bigger than the `max_request_body size`
      
      Need to be benched with bigger requests.
      
      * test(raw http): enable tests to works again.
      
      * style: cargo fmt
      
      * benches: address grumbles
      
      * feat(jsonrpc response/request): impl `Display`
      
      * refactor(logging): use display impl
      
      * fix(http client): nits.
      
      * Update benches/benches.rs
      
      * fix bad merge.
      
      * chore(deps): update dependencies. (#164)
      
      * feat(http server): configurable request body limit (#162)
      
      * feat(http server): configurable request body limit
      
      * refactor(crate reorg): to have shared http helpers.
      
      * Merge client and server errors.
      * Move `http_server_utils` to `utils/http`
      * Minor cleanup
      
      * fix nits
      
      * fix(hyper helper): u64 -> u32
      
      * Update src/utils/http/hyper_helpers.rs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * Update src/utils/http/hyper_helpers.rs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * fix: grumbles
      
      * Update src/utils/http/hyper_helpers.rs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * Update src/http/server.rs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * ci: remove nightly (#167)
      
      Use stabilized `broken_intra_doc_links` instead of `intra_doc_link_resolution_failure`
      
      * fix(websocket client): drop subscriptions that can't keep up with the internal buffer size (#166)
      
      * fix(ws client): drop subscriptions when full.
      
      This commit changes the behavior in the `WebSocket Client` where each subscription channel is used in a non-blocking
      matter until it is determined as full or disconnected. When that occurs the channel is simply dropped and when
      the user `poll` the subscription it will return all sent subscriptions before it was and terminate (return None)
      once it's polled one last time. Similarly as `Streams` works in Rust.
      
      It also adds configuration for the `WebSocket Client` to configure capacity for the different internal channels to avoid
      filling the buffers when it's not expected.
      
      * tests(ws client): simple subscription test.
      
      * fix: nits
      
      * Update src/client/ws/client.rs
      
      * refactor(tests): introduce integration_tests
      
      Make the repo structure more understable w.r.t testing.
      
      * chore(license): add missing license headers
      
      * Update src/client/ws/client.rs
      
      * Update src/client/ws/client.rs
      
      * style: remove unintended spaces.
      
      * tests: add concurrent deadlock test
      
      Ensure that if more than the requested channel buffer capacity is exceeded it should not deadlock.
      Such as spawning alot of concurrent requests, notifications or new subscriptions.
      
      * Update src/client/ws/client.rs
      
      * fix: review grumbles
      
      * fix nits: `remove needless closure`
      
      * fix: cargo fmt
      
      * Update src/client/ws/client.rs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * fix more nits
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * fix(ws client): embed request id in `SubscriptionClosed` (#170)
      
      * fix(ws client): embed request id SubscriptClosed
      
      Fixes https://github.com/paritytech/jsonrpsee/issues/169
      
      
      
      * Update src/client/ws/client.rs
      
      * Update src/client/ws/client.rs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * Update src/client/ws/client.rs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * chore(deps): bump dependencies (#172)
      
      * [ws client]: add tests (#134)
      
      * [test utils]: add `internal_err` and consts
      [errors]: unify client/server errors
      [test utils]: fake WebSocket jsonrpc server
      [ws client]: export errors
      [ws client]: add some basic tests
      
      * fmt
      
      * remove log target
      
      * fix nits
      
      * [ws client]: add subscription test
      
      * revert unintendend changes.
      
      * fmt
      
      * [ws client]: fix panic in tests
      
      * cleanup
      
      * tests(ws client): test for invalid request ID.
      
      * fix nits
      
      * [ws client]: kill raw client (#171)
      
      * getting started
      
      * WIP WIP
      
      * cleanup
      
      * cleanup v2
      
      * cleanup v3
      
      * perf: use BufReader BufWriter
      
      * fix(request manager): resultify insert API
      
      The rationale behind this change is that the `insert_methods` takes ownership of the `send_back_oneshot`
      and if the operation fails it should be propagated the frontend.
      
      So returning the `Err(send_back_oneshot)` if it fails makes it possible.
      
      * fix nits
      
      * examples(ws): revert changes
      
      * Update tests/integration_tests.rs
      
      * nits: fix unwraps
      
      * Update src/client/ws/manager.rs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * Update src/client/ws/transport.rs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * Update src/client/ws/client.rs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * fix build
      
      * refactor: simplify `Error::InvalidRequestId`
      
      It was hard to use when the expected id is not known.
      
      * fix(ws client): error handling.
      
      * fix(grumble error type): better error message.
      
      * fix(grumble): docs `JSONRPC WebSocket transport`
      
      * fix(ws manager): fix grumbles.
      
      * Add better documentation
      * Rename methods.
      * Add `proof` to unreachable!
      
      * fix(ws manager): fix nit in docs.
      
      * fix(grumbles): ws client
      
      * fix more nits
      
      * fix compile warning: export websocket transports.
      
      * Update src/client/ws/manager.rs
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      
      * deps: tokio 1.0 and hyper 0.14 (#176)
      
      * deps: tokio 1.0 and hyper 0.14
      
      * Update Cargo.toml
      
      * refactor: crate re-organization with separate crates (#177)
      
      * [ci]: feature `http` and `ws` removed.
      
      * refactor: re-org crate with smaller crates.
      
      * fmt
      
      * [ci]: remove default features
      
      Currently there are no features in the crates, so that check is not needed.
      
      * [http client]: remove unused dependency tokio
      
      * docs(http client): fix nits tokio 0.2 -> tokio 1.0 (#178)
      
      * docs(http client): tokio 0.2 -> tokio 1.0
      
      * fix: better link
      
      * [ci]: github actions (#179)
      
      * docs(http client): tokio 0.2 -> tokio 1.0
      
      * [ci]: remove travis
      
      * [ci]: add github actions.
      
      * [ci]: fix identation nits
      
      * [ci]: use cache for actions
      
      * [ci]: filter to clippy
      
      * [ci]: remove hacks
      
      * separate action for ci and benchmarks
      
      * [ci]: tweak to run on master branch.
      
      * examples/subscription -> examples/ws_subscription
      
      * force CI
      
      Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
      Co-authored-by: default avatarMaciej Hirsz <1096222+maciejhirsz@users.noreply.github.com>
      Co-authored-by: default avatarAtkins <atkinschang@gmail.com>
      61656562
  16. 21 Jul, 2020 1 commit
  17. 30 Jun, 2020 2 commits
  18. 29 Jun, 2020 2 commits
  19. 17 Jun, 2020 2 commits
  20. 13 Jun, 2020 1 commit
  21. 11 Jun, 2020 1 commit
  22. 16 Mar, 2020 2 commits
  23. 28 Feb, 2020 2 commits
  24. 26 Feb, 2020 1 commit
  25. 24 Feb, 2020 1 commit
  26. 19 Feb, 2020 2 commits
  27. 28 Jan, 2020 1 commit
  28. 20 Jan, 2020 2 commits
    • Andrew Jones's avatar
      Support websockets client TLS (#85) · f17b12d4
      Andrew Jones authored and Pierre Krieger's avatar Pierre Krieger committed
      * Experiment using TLS for ws client
      
      * Polkadot example works
      
      * Fmt
      
      * Support both Plain and Tls streams
      
      * Dependencies in alphabetic order
      
      * Use url scheme in connect to determine Plain or Tls
      
      * Fmt
      
      * Fix mode match
      
      * License and docs stream.rs
      
      * Move url parsing to ClientBuilder
      
      * Remove commented out line, remove default port from wss
      f17b12d4
    • Andrew Jones's avatar
      Fix panic when dropping subscription (#87) · 20bce1b1
      Andrew Jones authored and Pierre Krieger's avatar Pierre Krieger committed
      * Fix panic when dropping subscription
      
      * Remove remove active subscription
      20bce1b1
  29. 13 Jan, 2020 1 commit
  30. 09 Jan, 2020 1 commit
  31. 03 Jan, 2020 1 commit