Unverified Commit 9fa817d9 authored by Niklas Adolfsson's avatar Niklas Adolfsson Committed by GitHub
Browse files

fix(rpc module): fail subscription calls with bad params (#728)



* fix(rpc module): fail subscription with bad params

* draft; show my point

* fix tests

* fix build

* add tests for proc macros too

* add tests for bad params in proc macros

* fix nits

* commit all files

* add ugly fix for proc macro code

* add more user friendly API

* make SubscriptionSink::close take mut self

* fix grumbles

* show james some code

* Update core/src/server/rpc_module.rs

Co-authored-by: default avatarJames Wilson <[email protected]>

* remove needless clone

* fix build

* client fix docs + error type

* simplify code: merge connect reset and unsubscribe close reason

* remove unknown close reason

* refactor: remove Error::SubscriptionClosed

* add some nice APIs to ErrorObjectOwned

* unify api

* address grumbles

* remove redundant methods for close and reject

* proc macro: compile err when subscription -> Result

* rpc module: fix test subscription test

* Update core/src/server/rpc_module.rs

Co-authored-by: default avatarJames Wilson <[email protected]>

* Update core/src/server/rpc_module.rs

Co-authored-by: default avatarJames Wilson <[email protected]>

* Update core/src/server/rpc_module.rs

Co-authored-by: default avatarJames Wilson <[email protected]>

* Update core/src/server/rpc_module.rs

Co-authored-by: default avatarJames Wilson <[email protected]>

* Update core/src/server/rpc_module.rs

Co-authored-by: default avatarJames Wilson <[email protected]>

* Update proc-macros/src/lib.rs

Co-authored-by: default avatarJames Wilson <[email protected]>

* address grumbles

* remove faulty comment

* Update core/src/server/rpc_module.rs

Co-authored-by: default avatarDavid <[email protected]>

* Update core/src/server/rpc_module.rs

Co-authored-by: default avatarDavid <[email protected]>

* Update core/src/server/rpc_module.rs

Co-authored-by: default avatarDavid <[email protected]>

* Update core/src/server/rpc_module.rs

Co-authored-by: default avatarDavid <[email protected]>

* Update core/src/server/rpc_module.rs

Co-authored-by: default avatarDavid <[email protected]>

* fix: don't send `RPC Call failed: error`.

* remove debug assert

Co-authored-by: default avatarJames Wilson <[email protected]>
Co-authored-by: default avatarDavid <[email protected]>
parent b96a54bf
Pipeline #189301 passed with stages
in 4 minutes and 21 seconds
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment