Unverified Commit 9bd21274 authored by Niklas Adolfsson's avatar Niklas Adolfsson Committed by GitHub
Browse files

feat(rpc module): `stream API` for SubscriptionSink (#639)

* feat(rpc module): add_stream to subscription sink

* fix some nits

* unify parameters to rpc methods

* Update core/src/server/rpc_module.rs

* Update tests/tests/integration_tests.rs

Co-authored-by: David's avatarDavid <dvdplm@gmail.com>

* address grumbles

* fix subscription tests

* new type for `SubscriptionCallback` and glue code

* remove unsed code

* remove todo

* add missing feature tokio/macros

* make `add_stream` cancel-safe

* rename add_stream and return status

* fix nits

* rename stream API -> streamify

* Update core/src/server/rpc_module.rs

* provide proper close reason

* spelling

* consume_and_streamify + docs

* fmt

* rename API pipe_from_stream

* improve logging; indicate which subscription method that failed

Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
parent 429c196d
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment