Fix clippy (#861)

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

benches/bench.rs

@@ -270,8 +270,8 @@ fn ws_concurrent_conn_subs(rt: &TokioRuntime, crit: &mut Criterion, url: &str, n
 								let fut = client.subscribe::<String>(SUB_METHOD_NAME, None, UNSUB_METHOD_NAME).then(
 									|sub| async move {
 										let mut s = sub.unwrap();
-										let res = s.next().await.unwrap().unwrap();
-										res
+
+										s.next().await.unwrap().unwrap()
 									},
 								);
 

client/transport/src/ws/mod.rs

@@ -120,7 +120,7 @@ impl WsTransportClientBuilder {
 }
 
 /// Stream mode, either plain TCP or TLS.
-#[derive(Clone, Copy, Debug, PartialEq)]
+#[derive(Clone, Copy, Debug, PartialEq, Eq)]
 pub enum Mode {
 	/// Plain mode (`ws://` URL).
 	Plain,

core/src/client/mod.rs

@@ -436,7 +436,7 @@ impl<T: Clone> RequestIdGuard<T> {
 }
 
 /// What certificate store to use
-#[derive(Clone, Copy, Debug, PartialEq)]
+#[derive(Clone, Copy, Debug, PartialEq, Eq)]
 #[non_exhaustive]
 pub enum CertificateStore {
 	/// Use the native system certificate store

core/src/error.rs

@@ -32,7 +32,7 @@ use jsonrpsee_types::error::{
 };
 
 /// Convenience type for displaying errors.
-#[derive(Clone, Debug, PartialEq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub struct Mismatch<T> {
 	/// Expected value.
 	pub expected: T,

types/src/error.rs

@@ -264,7 +264,7 @@ pub const BATCHES_NOT_SUPPORTED_MSG: &str = "Batched requests are not supported
 pub const TOO_MANY_SUBSCRIPTIONS_MSG: &str = "Too many subscriptions on the connection";
 
 /// JSONRPC error code
-#[derive(Error, Debug, PartialEq, Copy, Clone)]
+#[derive(Error, Debug, PartialEq, Eq, Copy, Clone)]
 pub enum ErrorCode {
 	/// Invalid JSON was received by the server.
 	/// An error occurred on the server while parsing the JSON text.

types/src/params.rs

@@ -39,7 +39,7 @@ use serde::{Deserialize, Serialize};
 use serde_json::Value as JsonValue;
 
 /// JSON-RPC v2 marker type.
-#[derive(Clone, Copy, Debug, Default, PartialEq)]
+#[derive(Clone, Copy, Debug, Default, PartialEq, Eq)]
 pub struct TwoPointZero;
 
 struct TwoPointZeroVisitor;
@@ -168,7 +168,7 @@ impl<'a> ParamsSequence<'a> {
 	{
 		let mut json = self.0;
 		tracing::trace!("[next_inner] Params JSON: {:?}", json);
-		match json.as_bytes().get(0)? {
+		match json.as_bytes().first()? {
 			b']' => {
 				self.0 = "";
 

types/src/request.rs

@@ -56,7 +56,7 @@ impl<'a> Request<'a> {
 }
 
 /// JSON-RPC Invalid request as defined in the [spec](https://www.jsonrpc.org/specification#request-object).
-#[derive(Deserialize, Debug, PartialEq)]
+#[derive(Deserialize, Debug, PartialEq, Eq)]
 pub struct InvalidRequest<'a> {
 	/// Request ID
 	#[serde(borrow)]

ws-server/src/server.rs

@@ -463,7 +463,7 @@ async fn background_task<L: Logger>(input: BackgroundTask<'_, L>) -> Result<(),
 						methods,
 						bounded_subscriptions,
 						sink: &sink,
-						id_provider: &*id_provider,
+						id_provider,
 						logger,
 						request_start,
 					};