Unverified Commit 1fbaf45f authored by Niklas Adolfsson's avatar Niklas Adolfsson Committed by GitHub
Browse files

fix(client): adjust TransportSenderT (#852)



* fix(client): adjust TransportSenderT

This is trait contains `WebSocket` specific details and it's difficult to fix it properly with an extension trait
in the current design.

So this PR documents and marks it clearly that these methods are optional to implement, kind of ugly but better.

* fix build

* Update core/src/client/mod.rs

Co-authored-by: default avatarAlexandru Vasile <[email protected]>

* Update core/src/client/mod.rs

Co-authored-by: default avatarAlexandru Vasile <[email protected]>

* increase margin for failing test

* Update core/src/client/mod.rs

Co-authored-by: default avatarJames Wilson <[email protected]>

* remove optional prefix in trait

Co-authored-by: default avatarAlexandru Vasile <[email protected]>
Co-authored-by: default avatarJames Wilson <[email protected]>
parent 80bcef02
Pipeline #207825 passed with stages
in 4 minutes and 46 seconds
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment