Unverified Commit 0f255ad3 authored by Alexandru Vasile's avatar Alexandru Vasile
Browse files

rpc_server: Improve comment regarding dropped error


Signed-off-by: default avatarAlexandru Vasile <alexandru.vasile@parity.io>
parent 77ab7dec
...@@ -751,7 +751,7 @@ impl<Context: Send + Sync + 'static> RpcModule<Context> { ...@@ -751,7 +751,7 @@ impl<Context: Send + Sync + 'static> RpcModule<Context> {
_claimed: claimed, _claimed: claimed,
}; };
// The callback returns an empty `SubscriptionError` for improved API ergonomics. // The callback returns a `SubscriptionResult` for better ergonomics and is not propagated further.
if let Err(_) = callback(params, sink, ctx.clone()) { if let Err(_) = callback(params, sink, ctx.clone()) {
tracing::warn!("subscribe call `{}` failed", subscribe_method_name); tracing::warn!("subscribe call `{}` failed", subscribe_method_name);
} }
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment