• Niklas Adolfsson's avatar
    fix(rpc module): fail subscription calls with bad params (#728) · 9fa817d9
    Niklas Adolfsson authored
    
    
    * fix(rpc module): fail subscription with bad params
    
    * draft; show my point
    
    * fix tests
    
    * fix build
    
    * add tests for proc macros too
    
    * add tests for bad params in proc macros
    
    * fix nits
    
    * commit all files
    
    * add ugly fix for proc macro code
    
    * add more user friendly API
    
    * make SubscriptionSink::close take mut self
    
    * fix grumbles
    
    * show james some code
    
    * Update core/src/server/rpc_module.rs
    
    Co-authored-by: James Wilson's avatarJames Wilson <james@jsdw.me>
    
    * remove needless clone
    
    * fix build
    
    * client fix docs + error type
    
    * simplify code: merge connect reset and unsubscribe close reason
    
    * remove unknown close reason
    
    * refactor: remove Error::SubscriptionClosed
    
    * add some nice APIs to ErrorObjectOwned
    
    * unify api
    
    * address grumbles
    
    * remove redundant methods for close and reject
    
    * proc macro: compile err when subscription -> Result
    
    * rpc module: fix test subscription test
    
    * Update core/src/server/rpc_module.rs
    
    Co-authored-by: James Wilson's avatarJames Wilson <james@jsdw.me>
    
    * Update core/src/server/rpc_module.rs
    
    Co-authored-by: James Wilson's avatarJames Wilson <james@jsdw.me>
    
    * Update core/src/server/rpc_module.rs
    
    Co-authored-by: James Wilson's avatarJames Wilson <james@jsdw.me>
    
    * Update core/src/server/rpc_module.rs
    
    Co-authored-by: James Wilson's avatarJames Wilson <james@jsdw.me>
    
    * Update core/src/server/rpc_module.rs
    
    Co-authored-by: James Wilson's avatarJames Wilson <james@jsdw.me>
    
    * Update proc-macros/src/lib.rs
    
    Co-authored-by: James Wilson's avatarJames Wilson <james@jsdw.me>
    
    * address grumbles
    
    * remove faulty comment
    
    * Update core/src/server/rpc_module.rs
    
    Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
    
    * Update core/src/server/rpc_module.rs
    
    Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
    
    * Update core/src/server/rpc_module.rs
    
    Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
    
    * Update core/src/server/rpc_module.rs
    
    Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
    
    * Update core/src/server/rpc_module.rs
    
    Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
    
    * fix: don't send `RPC Call failed: error`.
    
    * remove debug assert
    
    Co-authored-by: James Wilson's avatarJames Wilson <james@jsdw.me>
    Co-authored-by: David's avatarDavid <dvdplm@gmail.com>
    9fa817d9