Unverified Commit cbe7564c authored by Hero Bird's avatar Hero Bird Committed by GitHub

Fix coverage reports of incorrectly inlined functions (#393)

* Fix coverage reports of incorrectly inlined functions

* [ci] fix -Cpanic=abort flag

* [ci] remove -Zpanic_abort_tests and -Cpanic=abort flags again

They seemed to cause trouble for the coverage reporting system.
parent b62b792f
Pipeline #92510 passed with stages
in 9 minutes and 42 seconds
...@@ -111,11 +111,14 @@ codecov: ...@@ -111,11 +111,14 @@ codecov:
variables: variables:
# Variables partly came from https://github.com/mozilla/grcov/blob/master/README.md # Variables partly came from https://github.com/mozilla/grcov/blob/master/README.md
CARGO_INCREMENTAL: 0 CARGO_INCREMENTAL: 0
RUSTFLAGS: "-Zprofile -Zmir-opt-level=0 -Zpanic_abort_tests -Ccodegen-units=1 RUSTFLAGS: "-Zprofile -Zmir-opt-level=0 -Ccodegen-units=1
-Cinline-threshold=0 -Copt-level=0 -Clink-dead-code -Coverflow-checks=off" -Copt-level=0 -Clink-dead-code -Coverflow-checks=off"
# The `cargo-taurpalin` coverage reporting tool seems to have better code instrumentation and thus # The `cargo-taurpalin` coverage reporting tool seems to have better code instrumentation and thus
# produces better results for Rust codebases in general. However, unlike `grcov` it requires # produces better results for Rust codebases in general. However, unlike `grcov` it requires
# running docker with `--security-opt seccomp=unconfined` which is why we use `grcov` instead. # running docker with `--security-opt seccomp=unconfined` which is why we use `grcov` instead.
# We removed the `-Cinline-threshold=0` flag from the above `RUSTFLAGS` since it was bugged
# at the time and lead to inlining of functions that shouldn't be inlined for the coverage
# report. (More information here: https://github.com/Kogia-sima/rust-covfix/issues/2)
script: script:
# RUSTFLAGS are the cause target cache can't be used here # RUSTFLAGS are the cause target cache can't be used here
- unset "CARGO_TARGET_DIR" - unset "CARGO_TARGET_DIR"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment