fether issueshttps://gitlab.parity.io/parity/fether/-/issues2018-09-10T03:55:45Zhttps://gitlab.parity.io/parity/fether/-/issues/146Parity Signer integration2018-09-10T03:55:45ZGhost UserParity Signer integrationAn obvious request from me ☺️
https://github.com/paritytech/parity-signer
For inspiration:
https://github.com/MyCryptoHQ/MyCrypto/pull/1349
There was #5 , but it's closed An obvious request from me ☺️
https://github.com/paritytech/parity-signer
For inspiration:
https://github.com/MyCryptoHQ/MyCrypto/pull/1349
There was #5 , but it's closed 0.3-betahttps://gitlab.parity.io/parity/fether/-/issues/137Change account import workflow2018-09-10T03:55:45ZddorganChange account import workflow*Created by: ltfschoen*
On the "Accounts" page, if I click "+" and then click "Import Account", and then enter secret phrase and username associated with the account that I want to import on subsequent pages, it eventually asks me to "S...*Created by: ltfschoen*
On the "Accounts" page, if I click "+" and then click "Import Account", and then enter secret phrase and username associated with the account that I want to import on subsequent pages, it eventually asks me to "Secure your account with a password" and asks for me to enter "Password" and "Confirm" (password)... but i was expecting it instead show me a label like "Enter your password" and to have just shown a "Password" input field instead to unlock the encrypted account (since we're importing an existing account instead of creating a new account or specifically changing the password associated with an account). I was able to enter a new password and confirmed that new password without having to enter the existing password at all. Lastly i clicked "Confirm Account Creation".
0.3-betahttps://gitlab.parity.io/parity/fether/-/issues/129Suggestion: Add help icon with a section explaining how to obtain kovan testn...2018-09-10T03:55:45ZddorganSuggestion: Add help icon with a section explaining how to obtain kovan testnet ether*Created by: ltfschoen*
Add a link to: https://github.com/kovan-testnet/faucet*Created by: ltfschoen*
Add a link to: https://github.com/kovan-testnet/faucethttps://gitlab.parity.io/parity/fether/-/issues/175Fether shouldn't download Parity if Parity was not found on the machine but i...2018-09-10T03:55:45ZGhost UserFether shouldn't download Parity if Parity was not found on the machine but is still runningWe should try `isParityRunning` before `getParityPath`We should try `isParityRunning` before `getParityPath`https://gitlab.parity.io/parity/fether/-/issues/167Disable Popup once user clicks on any other form fields on Tx sending screen!2018-09-10T03:55:45ZddorganDisable Popup once user clicks on any other form fields on Tx sending screen!*Created by: Rakhisharma*
On Tx sending screen once user click on `To` form filed, user can see the popup `Please enter a valid Ethereum address`, later when user clicks on any other form field(without entering address) popup is not ge...*Created by: Rakhisharma*
On Tx sending screen once user click on `To` form filed, user can see the popup `Please enter a valid Ethereum address`, later when user clicks on any other form field(without entering address) popup is not getting away. As you see in the screenshot I am still entering amount that I want to send.
![screenshot from 2018-07-30 12-16-01](https://user-images.githubusercontent.com/9638740/43381734-3826f36e-93f3-11e8-8740-c0a6cfcd255c.png)
How to reproduce:
Click on `to` form field on Tx Sending screen, Do not enter anything in `to` field. Just click on any other form filed of screen- popup stays there always!
0.3-betahttps://gitlab.parity.io/parity/fether/-/issues/161Show the amount in $ on account overview and Tx sending screens2018-09-10T03:55:45ZThibaut SardanShow the amount in $ on account overview and Tx sending screensNobody knows how much 0.001Eth is worth.
- On an account overview
- When sending a Tx: We should do the math for the user and show the equivalent in $ for the amount and the gas.
Nobody knows how much 0.001Eth is worth.
- On an account overview
- When sending a Tx: We should do the math for the user and show the equivalent in $ for the amount and the gas.
0.3-betahttps://gitlab.parity.io/parity/fether/-/issues/162[UX] Guide the user into the new account creation2018-09-10T03:55:45ZThibaut Sardan[UX] Guide the user into the new account creationInstead of directly creating a new account (and let him wonder later what this + is)
We could let him land on an empty account overview, and guide him:
![image](https://user-images.githubusercontent.com/33178835/42811833-16810f10-89bc-...Instead of directly creating a new account (and let him wonder later what this + is)
We could let him land on an empty account overview, and guide him:
![image](https://user-images.githubusercontent.com/33178835/42811833-16810f10-89bc-11e8-9466-231b7882756d.png)
0.3-betahttps://gitlab.parity.io/parity/fether/-/issues/160[UX] Be able to send the whole balance of an account2018-09-10T03:55:45ZThibaut Sardan[UX] Be able to send the whole balance of an accountAdding a "max" toggle to allow a user to send his whole balance of Eth/token.
The "amount" sent should be disabled (so that the user can't change it) and calculated according to the chosen gas.Adding a "max" toggle to allow a user to send his whole balance of Eth/token.
The "amount" sent should be disabled (so that the user can't change it) and calculated according to the chosen gas.0.3-betahttps://gitlab.parity.io/parity/fether/-/issues/159[UX] Do not block the UI when waiting for Peers or Tx confirmations2018-09-10T03:55:45ZThibaut Sardan[UX] Do not block the UI when waiting for Peers or Tx confirmationsWhen waiting for peers:
- the little green dot should be present on all pages and turn orange with the message "connecting to the blockchain" or something
When sending a Tx:
- the user sending the Tx actually doesn't care very much ...When waiting for peers:
- the little green dot should be present on all pages and turn orange with the message "connecting to the blockchain" or something
When sending a Tx:
- the user sending the Tx actually doesn't care very much about the confirmations, we should consider a Tx list showing the number of confirmations. Blocking the UI at this stage doesn't bring much. Linked to https://github.com/paritytech/fether/issues/980.3-betahttps://gitlab.parity.io/parity/fether/-/issues/158Add a UI library2019-01-13T12:00:21ZGhost UserAdd a UI libraryWe started this project with @brianflanagan's design, and its minimal and clean style has been approved by many.
While the design itself is excellent, I would like to refactor how it's implemented in the code.
**Right now**: A coll...We started this project with @brianflanagan's design, and its minimal and clean style has been approved by many.
While the design itself is excellent, I would like to refactor how it's implemented in the code.
**Right now**: A collection of SASS files under `fether-react/assets/scss/`, all compiled into one huge CSS file, imported by react.
**Problem**: It's very hard for non-UI developers (read: the whole Parity UI team) to add new components to it. E.g. I wanted to add a on/off toggle button once, I had no idea how to do that.
**Solution**: Add a UI components library to this project, like Semantic UI React (also used in shell, polkadot...). We would override their default theme to match the current Fether theme (maybe with css-in-js?). After that, adding new components like toggle buttons would be easy.https://gitlab.parity.io/parity/fether/-/issues/150Suggestion: define main token per account and show its balance in accounts ov...2018-09-10T03:55:45ZBjörn WagnerSuggestion: define main token per account and show its balance in accounts overviewFeature that enables user to define one specific token (native token or ERC20) as 'main token' for each account. The balance of this main token is shown in accounts overview.
Rationale: I would think that many users in the Ethereum ec...Feature that enables user to define one specific token (native token or ERC20) as 'main token' for each account. The balance of this main token is shown in accounts overview.
Rationale: I would think that many users in the Ethereum ecosystem maintain token-specific accounts (=overall account value is dominated by one specific token). Maybe someone is eager to do a quick analysis based on mainnet accounts (https://ethplorer.io/index seem to provide an API for that)? Or ask other teams such as mycrypto?0.3-betahttps://gitlab.parity.io/parity/fether/-/issues/148Client side key management2018-09-10T03:55:45ZThibaut SardanClient side key managementTo remove the hurdle of key management from the node, this task should be given to the UI.To remove the hurdle of key management from the node, this task should be given to the UI.0.3-betahttps://gitlab.parity.io/parity/fether/-/issues/128Suggestion: Add feedback button2019-01-03T10:12:32ZBjörn WagnerSuggestion: Add feedback buttonAdd feedback button that either links to https://github.com/paritytech/fether/issues/new or automatically creates a GH issue from whatever is put in a short form?
(there are probably more sophisticated methods to achieve this)Add feedback button that either links to https://github.com/paritytech/fether/issues/new or automatically creates a GH issue from whatever is put in a short form?
(there are probably more sophisticated methods to achieve this)0.3-betahttps://gitlab.parity.io/parity/fether/-/issues/122Create a monorepo of all parity JS libs2018-09-10T03:55:45ZGhost UserCreate a monorepo of all parity JS libs1. There are a lot of used and unused JS libs in the parity-js org. I want to create a monorepo of all JS libs used at parity.
It would go in `paritytech/js-libs`, and would contain
- [`@parity/api`](https://github.com/parity-js/api)...1. There are a lot of used and unused JS libs in the parity-js org. I want to create a monorepo of all JS libs used at parity.
It would go in `paritytech/js-libs`, and would contain
- [`@parity/api`](https://github.com/parity-js/api)
- [`@parity/abi`](https://github.com/parity-js/abi)
- [`@parity/jsonrpc`](https://github.com/parity-js/jsonrpc)
- `@parity/contracts`, which would contain [this folder](https://github.com/parity-js/shared/tree/master/src/contracts)
- [`@parity/light.js`](https://github.com/parity-js/light.js)
- `@parity/light.js-react`, which is [this](https://github.com/paritytech/fether/tree/master/packages/light-hoc)
- `@parity/electron`, which is [this](https://github.com/paritytech/fether/tree/master/packages/parity-electron)
Note: a monorepo would really suit here.
~2. In a second step, create a monorepo of JS libs unmaintained by Parity and put it under the community-driven parity-js org: `@parity/ui`, `@parity/mobx`, `@parity/etherscan`, `@parity/shapeshift`...~
@jacogr Any other ideas about this?
PS: Not entirely related to Fether, but it's still the best place to put this since this repo is currently hosting two of those libraries.https://gitlab.parity.io/parity/fether/-/issues/124Code Review, volunteers needed2019-04-08T09:08:14ZGhost UserCode Review, volunteers needed@jacogr was reviewing the code in the beginning and provided useful input, but since he's not working on the codebase and it grew bigger, at one point it was becoming useless for him to review all PRs, esp. architecture-wise.
So I'm l...@jacogr was reviewing the code in the beginning and provided useful input, but since he's not working on the codebase and it grew bigger, at one point it was becoming useless for him to review all PRs, esp. architecture-wise.
So I'm looking for volunteers to help me review the code before we ship Fether.
# Guideline
- I put a list of files/folders in the table below, with some info about each item such as *severity* (security-wise) or *difficulty of review* (how easy would it be to review the item).
- You choose one or several items from the table, and for each item, complete the **Review Template** (inspired from [Yelp](https://engineeringblog.yelp.com/2017/11/code-review-guidelines.html#when-doing-a-code-review)).
- Create a reply in this github thread for each item you review, see **Example**. If you think the review doesn't pass and the code needs change, then open a separate Github issue.
### Review Template
<details><summary>click to expand</summary>
<p>
**Item:** `name of the item in the table`
- [ ] Understand the code. _Make sure you completely understand the code_
- [ ] Check code quality. _Check for well-organized and efficient core logic. Is the code as general as it needs to be, without being more general that it has to be? Make sure the code is maintainable._
- [ ] Verify that the code is tested well. _Confirm adequate test coverage. Check tests having the right dependencies and are testing the right things._
- [ ] Check for any security holes and loop.
- [ ] Answer: If this code breaks at 3am and you’re called to diagnose and fix this issue, will you be able to?
**Comments:** `comments if any`
</p>
</details>
### Example
<details><summary>click to expand (this should be one reply in this thread)</summary>
<p>
**Item:** `myFile.js`
- [x] Understand the code.
- [x] Check code quality.
- [ ] Verify that the code is tested well.
- [x] Check for any security holes and loop.
- [x] Answer: If this code breaks at 3am and you’re called to diagnose and fix this issue, will you be able to?
**Comments:** `Missing some tests, and I think they should be required here. Will open a new github issue for this.`
</p>
</details>
# Review Items
| Name | Description | Severity | Difficuty | Comments |
| ------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------ | -------- | --------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| [MobX sendStore.js](https://github.com/paritytech/fether/blob/master/packages/fether-react/src/stores/sendStore.js) | Logic for sending tx | High | Easy | Make sure that we're sending the correct tx. |
| [MobX parityStore.js](https://github.com/paritytech/fether/blob/master/packages/fether-react/src/stores/parityStore.js) | Require a secure token from the node | Medium | Medium | Make sure that this token is securely stored. |
| [@parity/light.js](https://github.com/parity-js/light.js) | High-level Reactive JS lib (oo7-parity with RxJS) | Medium | Difficult | Can be skipped now, as it's a big codebase. Will create a similar issue as this one on that repo. It might make sense now to have a look at the Readme though. |
| [@parity/light.js-react](https://github.com/paritytech/fether/tree/master/packages/light-hoc) | Using `parity/light.js` with React (equivalent of oo7-react) | Medium | Medium | Uses JS Proxy. |
| [MobX createAccountStore.js](https://github.com/paritytech/fether/blob/master/packages/fether-react/src/stores/createAccountStore.js) | Logic to create an account | Medium | Easy | Holds the user's secret phrase at some point. |
| [fether-electron](https://github.com/paritytech/fether/tree/master/packages/parity-electron) | Electron wrapper | Medium | Medium | Make sure [Electron's guide](https://electronjs.org/docs/tutorial/security) is followed |
| [@parity/electron](https://github.com/paritytech/fether/tree/master/packages/parity-electron) | Interaction between Parity and Electron | Low | Medium | |
| [Other Mobx Stores](https://github.com/paritytech/fether/tree/master/packages/fether-react/src/stores) | The rest of the MobX stores (other than the 3 above) | Low | Easy | Non-critical logic |
| [React app](https://github.com/paritytech/fether/tree/master/packages/fether-react) | React app | Low | Easy | Contains minimal logic, only UI and UI state changes (all logic is in MobX stores) |
| [fether-ui](https://github.com/paritytech/fether/tree/master/packages/fether-ui) | UI Buildling Blocks Components | Low | Easy | |
It would be recommendable to get High- and Medium-severity items reviewed before shipping.0.2-alphahttps://gitlab.parity.io/parity/fether/-/issues/104Enable user to change order of accounts in accounts overview2018-09-10T03:55:46ZBjörn WagnerEnable user to change order of accounts in accounts overview0.3-betahttps://gitlab.parity.io/parity/fether/-/issues/101Add an account with JSON Keystore file2018-12-12T14:39:51ZThibaut SardanAdd an account with JSON Keystore fileRight now it is not possible to add an account using a JSON Keystore file.Right now it is not possible to add an account using a JSON Keystore file.0.3-betahttps://gitlab.parity.io/parity/fether/-/issues/98Be able to see the past transactions2018-12-19T16:54:32ZThibaut SardanBe able to see the past transactions- It could be a link to Etherscan on the account screen- It could be a link to Etherscan on the account screen0.3-betahttps://gitlab.parity.io/parity/fether/-/issues/100Make the recovery phrase confirmation and Account recovery more user friendly2019-03-24T06:06:50ZThibaut SardanMake the recovery phrase confirmation and Account recovery more user friendlyInstead of asking the user to type in his whole recovery phrase, we could ask to type in the 3rd, 7th and 12th word for instance.
This should go together with an account recovery screen with suggestions once the user has typed 3 lette...Instead of asking the user to type in his whole recovery phrase, we could ask to type in the 3rd, 7th and 12th word for instance.
This should go together with an account recovery screen with suggestions once the user has typed 3 letters (in case they stored it with a typo).0.3-betahttps://gitlab.parity.io/parity/fether/-/issues/88UX First start opens first account2019-03-24T06:06:50ZGhost UserUX First start opens first accountI would prefer to see all my accounts first.I would prefer to see all my accounts first.0.2-alpha