fether issueshttps://gitlab.parity.io/parity/fether/-/issues2018-09-10T03:55:45Zhttps://gitlab.parity.io/parity/fether/-/issues/161Show the amount in $ on account overview and Tx sending screens2018-09-10T03:55:45ZThibaut SardanShow the amount in $ on account overview and Tx sending screensNobody knows how much 0.001Eth is worth.
- On an account overview
- When sending a Tx: We should do the math for the user and show the equivalent in $ for the amount and the gas.
Nobody knows how much 0.001Eth is worth.
- On an account overview
- When sending a Tx: We should do the math for the user and show the equivalent in $ for the amount and the gas.
0.3-betahttps://gitlab.parity.io/parity/fether/-/issues/160[UX] Be able to send the whole balance of an account2018-09-10T03:55:45ZThibaut Sardan[UX] Be able to send the whole balance of an accountAdding a "max" toggle to allow a user to send his whole balance of Eth/token.
The "amount" sent should be disabled (so that the user can't change it) and calculated according to the chosen gas.Adding a "max" toggle to allow a user to send his whole balance of Eth/token.
The "amount" sent should be disabled (so that the user can't change it) and calculated according to the chosen gas.0.3-betahttps://gitlab.parity.io/parity/fether/-/issues/137Change account import workflow2018-09-10T03:55:45ZddorganChange account import workflow*Created by: ltfschoen*
On the "Accounts" page, if I click "+" and then click "Import Account", and then enter secret phrase and username associated with the account that I want to import on subsequent pages, it eventually asks me to "S...*Created by: ltfschoen*
On the "Accounts" page, if I click "+" and then click "Import Account", and then enter secret phrase and username associated with the account that I want to import on subsequent pages, it eventually asks me to "Secure your account with a password" and asks for me to enter "Password" and "Confirm" (password)... but i was expecting it instead show me a label like "Enter your password" and to have just shown a "Password" input field instead to unlock the encrypted account (since we're importing an existing account instead of creating a new account or specifically changing the password associated with an account). I was able to enter a new password and confirmed that new password without having to enter the existing password at all. Lastly i clicked "Confirm Account Creation".
0.3-betahttps://gitlab.parity.io/parity/fether/-/issues/124Code Review, volunteers needed2019-04-08T09:08:14ZGhost UserCode Review, volunteers needed@jacogr was reviewing the code in the beginning and provided useful input, but since he's not working on the codebase and it grew bigger, at one point it was becoming useless for him to review all PRs, esp. architecture-wise.
So I'm l...@jacogr was reviewing the code in the beginning and provided useful input, but since he's not working on the codebase and it grew bigger, at one point it was becoming useless for him to review all PRs, esp. architecture-wise.
So I'm looking for volunteers to help me review the code before we ship Fether.
# Guideline
- I put a list of files/folders in the table below, with some info about each item such as *severity* (security-wise) or *difficulty of review* (how easy would it be to review the item).
- You choose one or several items from the table, and for each item, complete the **Review Template** (inspired from [Yelp](https://engineeringblog.yelp.com/2017/11/code-review-guidelines.html#when-doing-a-code-review)).
- Create a reply in this github thread for each item you review, see **Example**. If you think the review doesn't pass and the code needs change, then open a separate Github issue.
### Review Template
<details><summary>click to expand</summary>
<p>
**Item:** `name of the item in the table`
- [ ] Understand the code. _Make sure you completely understand the code_
- [ ] Check code quality. _Check for well-organized and efficient core logic. Is the code as general as it needs to be, without being more general that it has to be? Make sure the code is maintainable._
- [ ] Verify that the code is tested well. _Confirm adequate test coverage. Check tests having the right dependencies and are testing the right things._
- [ ] Check for any security holes and loop.
- [ ] Answer: If this code breaks at 3am and you’re called to diagnose and fix this issue, will you be able to?
**Comments:** `comments if any`
</p>
</details>
### Example
<details><summary>click to expand (this should be one reply in this thread)</summary>
<p>
**Item:** `myFile.js`
- [x] Understand the code.
- [x] Check code quality.
- [ ] Verify that the code is tested well.
- [x] Check for any security holes and loop.
- [x] Answer: If this code breaks at 3am and you’re called to diagnose and fix this issue, will you be able to?
**Comments:** `Missing some tests, and I think they should be required here. Will open a new github issue for this.`
</p>
</details>
# Review Items
| Name | Description | Severity | Difficuty | Comments |
| ------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------ | -------- | --------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| [MobX sendStore.js](https://github.com/paritytech/fether/blob/master/packages/fether-react/src/stores/sendStore.js) | Logic for sending tx | High | Easy | Make sure that we're sending the correct tx. |
| [MobX parityStore.js](https://github.com/paritytech/fether/blob/master/packages/fether-react/src/stores/parityStore.js) | Require a secure token from the node | Medium | Medium | Make sure that this token is securely stored. |
| [@parity/light.js](https://github.com/parity-js/light.js) | High-level Reactive JS lib (oo7-parity with RxJS) | Medium | Difficult | Can be skipped now, as it's a big codebase. Will create a similar issue as this one on that repo. It might make sense now to have a look at the Readme though. |
| [@parity/light.js-react](https://github.com/paritytech/fether/tree/master/packages/light-hoc) | Using `parity/light.js` with React (equivalent of oo7-react) | Medium | Medium | Uses JS Proxy. |
| [MobX createAccountStore.js](https://github.com/paritytech/fether/blob/master/packages/fether-react/src/stores/createAccountStore.js) | Logic to create an account | Medium | Easy | Holds the user's secret phrase at some point. |
| [fether-electron](https://github.com/paritytech/fether/tree/master/packages/parity-electron) | Electron wrapper | Medium | Medium | Make sure [Electron's guide](https://electronjs.org/docs/tutorial/security) is followed |
| [@parity/electron](https://github.com/paritytech/fether/tree/master/packages/parity-electron) | Interaction between Parity and Electron | Low | Medium | |
| [Other Mobx Stores](https://github.com/paritytech/fether/tree/master/packages/fether-react/src/stores) | The rest of the MobX stores (other than the 3 above) | Low | Easy | Non-critical logic |
| [React app](https://github.com/paritytech/fether/tree/master/packages/fether-react) | React app | Low | Easy | Contains minimal logic, only UI and UI state changes (all logic is in MobX stores) |
| [fether-ui](https://github.com/paritytech/fether/tree/master/packages/fether-ui) | UI Buildling Blocks Components | Low | Easy | |
It would be recommendable to get High- and Medium-severity items reviewed before shipping.0.2-alphahttps://gitlab.parity.io/parity/fether/-/issues/100Make the recovery phrase confirmation and Account recovery more user friendly2019-03-24T06:06:50ZThibaut SardanMake the recovery phrase confirmation and Account recovery more user friendlyInstead of asking the user to type in his whole recovery phrase, we could ask to type in the 3rd, 7th and 12th word for instance.
This should go together with an account recovery screen with suggestions once the user has typed 3 lette...Instead of asking the user to type in his whole recovery phrase, we could ask to type in the 3rd, 7th and 12th word for instance.
This should go together with an account recovery screen with suggestions once the user has typed 3 letters (in case they stored it with a typo).0.3-beta